[Bug 23082] New: Fatal error editing a restricted patron
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23082 Bug ID: 23082 Summary: Fatal error editing a restricted patron Change sponsored?: --- Product: Koha Version: 18.11 Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: frinaudo@infocpt.com.ar QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com Target Milestone: --- Para reproducir el error, se debe tener un socio con una restricción, ya sea manual o automática: 1- Editar el socio 2- Marcar el checkbox "eliminar" en la restricción 3- Guardar En ese momento aparece un internal server error En los logs el mensaje es: ==> /var/log/koha/eco/plack-error.log <== No property remove_debarment for Koha::Patron La restricción se elimina, pero se debe abrir una ventana de koha nuevamente. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23082 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Hola Frederico, no puedo reproducir este problema. Cual versión usas? Reiniciaste Plack? I cannot recreate this issue, which version are you using? Did you restart Plack? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23082 --- Comment #2 from Federico Rinaudo <frinaudo@infocpt.com.ar> --- Reinicie plack y sigue saliendo el mismo error. Utilizo debian 8 y koha está en su viersión 18.11.05.000 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23082 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de, | |tomascohen@gmail.com --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I've added adding and deleting restrictions from a patron account in staff in 18.11 and it worked ok, no internal server error. Not sure I tested the right thing, can someone help? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23082 --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Federico, can you locate where you Koha code is (should be something like /usr/share/koha/lib) then copy the output of the following command: % grep -r remove_debarment -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23082 --- Comment #5 from Federico Rinaudo <frinaudo@infocpt.com.ar> --- there is no output for the command -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23082 --- Comment #6 from Tomás Cohen Arazi <tomascohen@gmail.com> --- (In reply to Federico Rinaudo from comment #5)
there is no output for the command
It might come from the templates. Try: $ cd /usr/share/koha $ grep -r remove_debarment -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23082 --- Comment #7 from Federico Rinaudo <frinaudo@infocpt.com.ar> --- /usr/share/koha# grep -r remove_debarment intranet/cgi-bin/members/memberentry.pl:my @debarments_to_remove = $input->multi_param('remove_debarment'); intranet/htdocs/intranet-tmpl/prog/en/modules/members/memberentrygen.tt: <input type="checkbox" id="debarment_[% d.borrower_debarment_id | html %]" name="remove_debarment" value="[% d.borrower_debarment_id | html %]" /> intranet/htdocs/intranet-tmpl/prog/es-ES/modules/members/memberentrygen.tt: <input type="checkbox" id="debarment_[% d.borrower_debarment_id | html %]" name="remove_debarment" value="[% d.borrower_debarment_id | html %]" /> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23082 --- Comment #8 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- This is correct Federico, I have no idea what is going wrong. If you have a test server you could try to apply this debug statement: @ Object.pm:240 @ sub set { foreach my $p ( keys %$properties ) { unless ( grep {/^$p$/} @columns ) { + my @c = caller; use Data::Printer colored => 1; warn p @c; Koha::Exceptions::Object::PropertyNotFound->throw( "No property $p for " . ref($self) ); } } To understand where it comes from. Or, you can turn the dev_install flag on in your koha-conf.xml file, then restart plack. You will get a full stack trace of the error which will be easier to track the problem down. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23082 Andrew <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew@bywatersolutions.com --- Comment #9 from Andrew <andrew@bywatersolutions.com> --- I'm able to recreate this on 18.11.06. Plack log showing the same error "No property remove_debarment for Koha::Patron." When I reload the patron the debarment has been removed, despite the error -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23082 --- Comment #10 from Andrew <andrew@bywatersolutions.com> --- Oh, and I do not get this error when removing the debarment from the restrictions tab on circulation.pl. Only when removing the debarment from memberentry.pl -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23082 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |jonathan.druart@bugs.koha-c |ity.org |ommunity.org Status|NEW |ASSIGNED --- Comment #11 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Andrew from comment #10)
Oh, and I do not get this error when removing the debarment from the restrictions tab on circulation.pl. Only when removing the debarment from memberentry.pl
That was the useful bit, thanks! Confirmed. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23082 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23082 --- Comment #12 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 90954 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90954&action=edit Bug 23082: FIX debarment removing when editing a patron In members/memberentry.pl we have to explicitely remove the template's params that are not patron's attributes. Certainly caused by commit 1bb6cec902088d07c7a43addc4b4adb5b0bf3d4f Bug 20287: Fix update of patrons, clean the data before ->store Test plan: Create a restriction for a patron Edit patron's details Remove the restriction => Without this patch you get "No property remove_debarment for Koha::Patron" => With this patch applied the restriction is removed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23082 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23082 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90954|0 |1 is obsolete| | --- Comment #13 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 90958 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90958&action=edit Bug 23082: FIX debarment removing when editing a patron In members/memberentry.pl we have to explicitely remove the template's params that are not patron's attributes. Certainly caused by commit 1bb6cec902088d07c7a43addc4b4adb5b0bf3d4f Bug 20287: Fix update of patrons, clean the data before ->store Test plan: Create a restriction for a patron Edit patron's details Remove the restriction => Without this patch you get "No property remove_debarment for Koha::Patron" => With this patch applied the restriction is removed Signed-off-by: Mark Tompsett <mtompset@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23082 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23082 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90958|0 |1 is obsolete| | --- Comment #14 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 90963 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90963&action=edit Bug 23082: Fatal error editing a restricted patron In members/memberentry.pl we have to explicitely remove the template's params that are not patron's attributes. Certainly caused by commit 1bb6cec902088d07c7a43addc4b4adb5b0bf3d4f Bug 20287: Fix update of patrons, clean the data before ->store Test plan: Create a restriction for a patron Edit patron's details Remove the restriction => Without this patch you get "No property remove_debarment for Koha::Patron" => With this patch applied the restriction is removed Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23082 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |19.11.00 released in| | Status|Passed QA |Pushed to Master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23082 --- Comment #15 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23082 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|19.11.00 |19.11.00,19.05.01 released in| | Status|Pushed to Master |Pushed to Stable CC| |fridolin.somers@biblibre.co | |m --- Comment #16 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Pushed to 19.05.x for 19.05.01 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23082 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #17 from Lucas Gass <lucas@bywatersolutions.com> --- backported to 18.11.x for 18.11.07 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23082 Magnus Enger <magnus@libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |magnus@libriotech.no --- Comment #18 from Magnus Enger <magnus@libriotech.no> --- *** Bug 23972 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org