[Bug 19767] New: serial-issues.pl is unused and should be removed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19767 Bug ID: 19767 Summary: serial-issues.pl is unused and should be removed Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Serials Assignee: koha-bugs@lists.koha-community.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org CC: colin.campbell@ptfs-europe.com serial-issues.pl is not linked to from anywhere in Koha, and should be considered obsolete. It and its associated templates should be removed. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19767 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- It would be good to get a confirmation from the list -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19767 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19767 --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 69697 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69697&action=edit Bug 19767: serial-issues.pl is unused and should be removed This patch removes three unused files: serials/serial-issues.pl ...and its associated templates: koha-tmpl/intranet-tmpl/prog/en/modules/serials/serial-issues-full.tt koha-tmpl/intranet-tmpl/prog/en/modules/serials/serial-issues.tt To test, apply the patch and search the Koha codebase for references to any of those files. None should exist. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19767 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |oleonard@myacpl.org |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19767 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19767 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #69697|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 69747 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69747&action=edit Bug 19767: serial-issues.pl is unused and should be removed This patch removes three unused files: serials/serial-issues.pl ...and its associated templates: koha-tmpl/intranet-tmpl/prog/en/modules/serials/serial-issues-full.tt koha-tmpl/intranet-tmpl/prog/en/modules/serials/serial-issues.tt To test, apply the patch and search the Koha codebase for references to any of those files. None should exist. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19767 --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Jonathan Druart from comment #1)
It would be good to get a confirmation from the list
http://lists.koha-community.org/pipermail/koha-devel/2017-December/044196.ht... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19767 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #69747|0 |1 is obsolete| | --- Comment #5 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 69760 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69760&action=edit Bug 19767: serial-issues.pl is unused and should be removed This patch removes three unused files: serials/serial-issues.pl ...and its associated templates: koha-tmpl/intranet-tmpl/prog/en/modules/serials/serial-issues-full.tt koha-tmpl/intranet-tmpl/prog/en/modules/serials/serial-issues.tt To test, apply the patch and search the Koha codebase for references to any of those files. None should exist. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19767 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |josef.moravec@gmail.com --- Comment #6 from Josef Moravec <josef.moravec@gmail.com> --- Removing dead code is always good ;) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19767 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #7 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 18.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19767 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |nick@bywatersolutions.com --- Comment #8 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to stable for 17.11.01 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org