[Bug 19797] New: Subscribers to email notifications for new issues are broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19797 Bug ID: 19797 Summary: Subscribers to email notifications for new issues are broken Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Serials Assignee: koha-bugs@lists.koha-community.org Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org CC: colin.campbell@ptfs-europe.com The option to subscribe to email for newly arrived serial issues is something that people like a lot in Koha - currently this is broken a bit in both versions I tested. For master: To test: - Add a subscription - Make sure you set a notice template for 'notification' on the first page - Go to the record in the OPAC - Subscribe to email notifications from the Subscriptions tab - Go back to the subscription detail page - Click on the 'subscribers' link - Verify that the list shown is empty - Verify that the alert table in the database has the entry for the subscribed patron - Verify that in the OPAC it now asks you to cancel subscription For 16.11: (I can move this to a separate bug if needed) - Follow above test plan until "subscribe..." - Verify that the redirect is to an empty page - Verify that the subscriber link doesn't work - Verify that the link doesn't change to cancel and you can subscribe mulitple times - Verify that the alert table will have multiple entries for your borrowernumber and subscription id -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19797 --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Note: In 16.11.x you can only subscribe form the full history, click 'more details' at the bottom of the subscription page to go there. Also the link will only show, when you are logged in. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19797 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19797 --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I think it stems from this change here: http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=27891cbfe216... <input type="hidden" name="externalid" value="[% externalid %]"> - <input type="hidden" name="alerttype" value="issue"> - <input type="hidden" name="biblionumber" value="[% biblionumber %]"> + <input type="hidden" name="alerttype" value="[% alerttype %]"> + <input type="hidden" name="biblionumber" value="[% biblionumber | html When you check the alert table the type is empty, which explains the problem with the subscribers list display and possibly also the problems appearing in 16.11.x. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19797 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Subscribers to email |Subscriptions to email |notifications for new |notifications for new |issues are broken |serial issues are broken -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19797 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- I do not recreate what you describe for master. Make sure you have a surname and a firstname: MariaDB [koha_kohadev]> select surname, firstname from borrowers where borrowernumber=51; +---------+-----------+ | surname | firstname | +---------+-----------+ | koha | NULL | +---------+-----------+ MariaDB [koha_kohadev]> select concat(surname, firstname) from borrowers where borrowernumber=51; +----------------------------+ | concat(surname, firstname) | +----------------------------+ | NULL | +----------------------------+ -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19797 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19797 --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 69933 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69933&action=edit Bug 19797: [16.11.x] Restore alert subscribers This patch fixes a bad conflict between bug 18726 and bug 10357. The alerttype variable was not passed to the template on 16.11.x Test plan: - Add a subscription - Make sure you set a notice template for 'notification' on the first page - Go to the record in the OPAC - Subscribe to email notifications from the Subscriptions tab > More detail - Verify that the alert table in the database has the entry for the subscribed patron - Verify that in the OPAC it now asks you to cancel subscription -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19797 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |jonathan.druart@bugs.koha-c |ity.org |ommunity.org Version|master |16.11 --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Setting to 16.11.x specific, please open another bug report if the behavior is wrong on master as well. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19797 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19797 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #69933|0 |1 is obsolete| | --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 72270 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72270&action=edit Bug 19797: [16.11.x] Restore alert subscribers This patch fixes a bad conflict between bug 18726 and bug 10357. The alerttype variable was not passed to the template on 16.11.x Test plan: - Add a subscription - Make sure you set a notice template for 'notification' on the first page - Go to the record in the OPAC - Subscribe to email notifications from the Subscriptions tab > More detail - Verify that the alert table in the database has the entry for the subscribed patron - Verify that in the OPAC it now asks you to cancel subscription Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19797 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I will retest master, but this fixes the most important blocker. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19797 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #8 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Not for master, sending to RMaints queue. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19797 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #9 from Chris Cormack <chris@bigballofwax.co.nz> --- Pushed to 16.11.x will be in 16.11.17 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org