https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35935 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=35890 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35935 --- Comment #1 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 161623 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161623&action=edit Bug 35935: Ensure login branch will be used after incorrect login If a different branch is selected after an incorrect login, the previous branch will be used. To recreate: * login with foo/bar, select CPL => FAIL * login with koha/koha, select another branch => OK but CPL is picked! It was caused by a dup of "branch" in CGI param list (and first was picked). This patch patch also removes "koha_login_context" to not have it twice. You can also open the source of the page to confirm that form#loginform contains "branch" and "koha_login_context" in hidden inputs. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35935 Magnus Enger <magnus@libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #161623|0 |1 is obsolete| | --- Comment #2 from Magnus Enger <magnus@libriotech.no> --- Created attachment 161625 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161625&action=edit Bug 35935: Ensure login branch will be used after incorrect login If a different branch is selected after an incorrect login, the previous branch will be used. To recreate: * login with foo/bar, select CPL => FAIL * login with koha/koha, select another branch => OK but CPL is picked! It was caused by a dup of "branch" in CGI param list (and first was picked). This patch patch also removes "koha_login_context" to not have it twice. You can also open the source of the page to confirm that form#loginform contains "branch" and "koha_login_context" in hidden inputs. Signed-off-by: Magnus Enger <magnus@libriotech.no> Tested in KTD. Works as advertised. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35935 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #161625|0 |1 is obsolete| | --- Comment #3 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 162236 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162236&action=edit Bug 35935: Ensure login branch will be used after incorrect login If a different branch is selected after an incorrect login, the previous branch will be used. To recreate: * login with foo/bar, select CPL => FAIL * login with koha/koha, select another branch => OK but CPL is picked! It was caused by a dup of "branch" in CGI param list (and first was picked). This patch patch also removes "koha_login_context" to not have it twice. You can also open the source of the page to confirm that form#loginform contains "branch" and "koha_login_context" in hidden inputs. Signed-off-by: Magnus Enger <magnus@libriotech.no> Tested in KTD. Works as advertised. Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35935 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |34478 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35935 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Status|Pushed to master |Pushed to stable Version(s)|24.05.00 |24.05.00,23.11.04 released in| | --- Comment #5 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 23.11.x for 23.11.04 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35935 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to stable |RESOLVED -- You are receiving this mail because: You are watching all bug changes.