[Bug 21846] New: Using emoji as tags doesn't discriminate between emoji when calculating weights or searching
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21846 Bug ID: 21846 Summary: Using emoji as tags doesn't discriminate between emoji when calculating weights or searching Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: nick@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21846 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com --- Comment #1 from Nick Clemens <nick@bywatersolutions.com> --- Tested on mariadb 10.1.26-0+deb9u1 To recreate: 1 - Enable tags and disable moderation (or plan to moderate and accept tags) 2 - Tag 3 records: a - with 🐋 b - with 🌮 c - with 👍 3 - Note the weight on each says '3' 4 - Click the tag to search, you get back all the records -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21846 Heather <heather_hernandez@nps.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |heather_hernandez@nps.gov -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21846 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |koha-bugs@lists.koha-commun | |ity.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21846 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |tomascohen@gmail.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21846 --- Comment #2 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 82621 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82621&action=edit Bug 21846: Add Koha::Tags::Approval(s) and Koha::Tags::Index(es) In order to avoid writing the tests using plain DBIC which would later need to be replaced by a Koha::Object-based counterpart, I introduce this stub classes. Stub tests are added as well. To test: - Apply this patch - Run: $ kshell k$ prove t/db_dependent/Koha/Tags.t \ t/db_dependent/Koha/Tags/Approvals.t \ t/db_dependent/Koha/Tags/Indexes.t => SUCCESS: Tests pass - Sign off :-D -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21846 --- Comment #3 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 82622 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82622&action=edit Bug 21846: Regression tests for add_tag_approval Due to collation issues, add_tag_approval wrongly calculates the weight for strings including extended UNICODE characters. This patch introduces a test for this situation. To test: - Apply this patch on master - Run: $ kshell k$ prove t/db_dependent/Tags.t => FAIL: Tests fail because all extended characters match the same -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21846 --- Comment #4 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 82623 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82623&action=edit Bug 21846: Make 'term' use utf8mb_bin collation on tags tables This patch makes the utf8mb4_bin collation preferred for comparing tags. Otherwise suppolemental unicode characters all match. To test: - Enable tags and disable moderation (or plan to moderate and accept tags) - Tag 3 records: a - with 🐋 b - with 🌮 c - with 👍 - Note the weight on each says '3' - Click the tag to search, you get back all the records - Apply the previous patches from this bug report - Run: $ kshell k$ prove t/db_dependent/Tags.t => FAIL: Tests fail, related to counting stuffs - Apply this patch and (a) Run updatedatabase to upgrade the schema - Run: k$ prove t/db_dependent/Tags.t => SUCCESS: Tests pass! (b) reset_all to get a fresh DB using kohastructure.sql - Run: k$ prove t/db_dependent/Tags.t => SUCCESS: Tests pass too! - Sign off :-D -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21846 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |In Discussion --- Comment #5 from Tomás Cohen Arazi <tomascohen@gmail.com> --- I leave the patches I worked on today here. The only thing that is missing IMO is re-calculating the weight and weight_total in tags_index and tags_approval. This could done easily by going through tags_all in the update process. I need to leave now, but I will implement it next week. The main issue can be tested anyways. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21846 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21846 --- Comment #6 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 83717 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83717&action=edit Bug 21846: (follow-up) Add maintenance script This patch adds a maintenance script that generates the missing tags_approval entries based on the tags_all table, and then recalculates the weights for both tags_approval and tags_index tables. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21846 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21846 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #82621|0 |1 is obsolete| | Attachment #82622|0 |1 is obsolete| | Attachment #82623|0 |1 is obsolete| | Attachment #83717|0 |1 is obsolete| | --- Comment #7 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 83759 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83759&action=edit Bug 21846: Add Koha::Tags::Approval(s) and Koha::Tags::Index(es) In order to avoid writing the tests using plain DBIC which would later need to be replaced by a Koha::Object-based counterpart, I introduce this stub classes. Stub tests are added as well. To test: - Apply this patch - Run: $ kshell k$ prove t/db_dependent/Koha/Tags.t \ t/db_dependent/Koha/Tags/Approvals.t \ t/db_dependent/Koha/Tags/Indexes.t => SUCCESS: Tests pass - Sign off :-D Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21846 --- Comment #8 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 83760 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83760&action=edit Bug 21846: Regression tests for add_tag_approval Due to collation issues, add_tag_approval wrongly calculates the weight for strings including extended UNICODE characters. This patch introduces a test for this situation. To test: - Apply this patch on master - Run: $ kshell k$ prove t/db_dependent/Tags.t => FAIL: Tests fail because all extended characters match the same Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21846 --- Comment #9 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 83761 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83761&action=edit Bug 21846: Make 'term' use utf8mb_bin collation on tags tables This patch makes the utf8mb4_bin collation preferred for comparing tags. Otherwise suppolemental unicode characters all match. To test: - Enable tags and disable moderation (or plan to moderate and accept tags) - Tag 3 records: a - with 🐋 b - with 🌮 c - with 👍 - Note the weight on each says '3' - Click the tag to search, you get back all the records - Apply the previous patches from this bug report - Run: $ kshell k$ prove t/db_dependent/Tags.t => FAIL: Tests fail, related to counting stuffs - Apply this patch and (a) Run updatedatabase to upgrade the schema - Run: k$ prove t/db_dependent/Tags.t => SUCCESS: Tests pass! (b) reset_all to get a fresh DB using kohastructure.sql - Run: k$ prove t/db_dependent/Tags.t => SUCCESS: Tests pass too! - Sign off :-D Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21846 --- Comment #10 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 83762 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83762&action=edit Bug 21846: (follow-up) Add maintenance script This patch adds a maintenance script that generates the missing tags_approval entries based on the tags_all table, and then recalculates the weights for both tags_approval and tags_index tables. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21846 --- Comment #11 from Owen Leonard <oleonard@myacpl.org> --- These patches worked as expected for me. I did get inconsistent results from 'prove t/db_dependent/Tags.t.' It sometimes passed and sometimes didn't. The QA tool has some complaints, but I'm not sure if they're false positives. I'll leave it for QA to decide. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21846 --- Comment #12 from Tomás Cohen Arazi <tomascohen@gmail.com> --- (In reply to Owen Leonard from comment #11)
These patches worked as expected for me. I did get inconsistent results from 'prove t/db_dependent/Tags.t.' It sometimes passed and sometimes didn't.
The QA tool has some complaints, but I'm not sure if they're false positives. I'll leave it for QA to decide.
Owen, thanks for reporting that. The problem is the patchset isn't updating the DBIC schema files. You can do it by issuing the following command $ dbic on the 'vagrant' user. The @RM will provide those schema updates when pushing. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21846 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Status|Signed Off |Failed QA --- Comment #13 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- QA script: FAIL misc/maintenance/fix_tags_weight.pl OK critic FAIL forbidden patterns forbidden pattern: merge marker (=======) (line 85) forbidden pattern: merge marker (=======) (line 124) OK git manipulation Please fix! I also noticed that you can only tag an item with any emoticon once. If I try to add whale and then later add smiley I always get told I can't add the same twice. Is this related? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21846 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #14 from Tomás Cohen Arazi <tomascohen@gmail.com> --- The script I introduce doesn't have merge markers in it, it has some strings it prints in verbose mode. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21846 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #15 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Leaving this for tcohen to have another look: What I did: - Added taco to 2 separate records - Applied patches - updatedatabase - dbic - maint script - Report: Added => 🌮 - Checked the OPAC - Clicking on taco now finds the 2 correct records, other tags work as well - But: tags table in the db is empty (should it be?) - Tag cloud shows 2 tacos instead of one bigger taco -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21846 --- Comment #16 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- So we don't forget again: SET NAMES utf8mb4; will help with SQL. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21846 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #17 from Tomás Cohen Arazi <tomascohen@gmail.com> --- (In reply to Katrin Fischer from comment #15)
Leaving this for tcohen to have another look:
What I did: - Added taco to 2 separate records - Applied patches - updatedatabase - dbic - maint script - Report: Added => 🌮 - Checked the OPAC - Clicking on taco now finds the 2 correct records, other tags work as well - But: tags table in the db is empty (should it be?) - Tag cloud shows 2 tacos instead of one bigger taco
Katrina, in order to test this, you better add a couple tags on different biblios you can differentiate (both the biblios and the tags). I did, and this is what I got: https://snag.gy/VwboRH.jpg The last two SELECT are after the maintenance script is run. So the source for truth is the 'tags_all' table. And, initially, the 'tags_approval' and 'tags_index' tables contain wrong calculated data, due to the fact that all emojis are considered the same. The 'tags' table (which I hadn't had any idea about) is filled by misc/cronjobs/build_browser_and_cloud.pl. I would say leave that for another bug. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21846 --- Comment #18 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 85730 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85730&action=edit Bug 21846: (QA follow-up) Fix maintenance script path Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21846 --- Comment #19 from Tomás Cohen Arazi <tomascohen@gmail.com> --- (In reply to Katrin Fischer from comment #15)
- But: tags table in the db is empty (should it be?)
The 'tags' table is used by a tool that is not related to the tags feature, but the subject cloud for french terms.
- Tag cloud shows 2 tacos instead of one bigger taco
This seems to be a bug in master already, with or without emojis. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21846 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #20 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- 1. Maybe we should display the WARNING during the updatedb process only if really needed? 2. How do I test the maintenance script? 3. Why no module for tags_all? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21846 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=22420 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21846 --- Comment #21 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 85740 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85740&action=edit Bug 21846: Fix pod2usage return values According to existing pattern. However I am not sure it makes sense to return an errno (and print to STDERR) if --help is passed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21846 --- Comment #22 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 85741 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85741&action=edit Bug 21846: Simplify ugly double for loops -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21846 --- Comment #23 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Tomás Cohen Arazi from comment #19)
(In reply to Katrin Fischer from comment #15)
- But: tags table in the db is empty (should it be?)
The 'tags' table is used by a tool that is not related to the tags feature, but the subject cloud for french terms.
OK
- Tag cloud shows 2 tacos instead of one bigger taco
This seems to be a bug in master already, with or without emojis.
You are right, this is a regression. I am not sure when it was introduced, but we need to fix it. The font should go bigger with increased use of a tag to get the normal cloud picture. I know for sure it still works in 17.11 but could not test further. I also had added multiple tags according to Nicks test plan in comment 1. The taco was extra :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21846 --- Comment #24 from Tomás Cohen Arazi <tomascohen@gmail.com> --- (In reply to Katrin Fischer from comment #23)
(In reply to Tomás Cohen Arazi from comment #19)
(In reply to Katrin Fischer from comment #15)
- But: tags table in the db is empty (should it be?)
The 'tags' table is used by a tool that is not related to the tags feature, but the subject cloud for french terms.
OK
- Tag cloud shows 2 tacos instead of one bigger taco
This seems to be a bug in master already, with or without emojis.
You are right, this is a regression. I am not sure when it was introduced, but we need to fix it. The font should go bigger with increased use of a tag to get the normal cloud picture. I know for sure it still works in 17.11 but could not test further.
I filled bug 22420, and Jonathan provided a fix already.
I also had added multiple tags according to Nicks test plan in comment 1. The taco was extra :)
Ok -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21846 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |liz@catalyst.net.nz --- Comment #25 from Tomás Cohen Arazi <tomascohen@gmail.com> --- *** Bug 21247 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21846 --- Comment #26 from Tomás Cohen Arazi <tomascohen@gmail.com> --- (In reply to Jonathan Druart from comment #22)
Created attachment 85741 [details] [review] Bug 21846: Simplify ugly double for loops
C'mon! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21846 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #83759|0 |1 is obsolete| | Attachment #83760|0 |1 is obsolete| | Attachment #83761|0 |1 is obsolete| | Attachment #83762|0 |1 is obsolete| | Attachment #85730|0 |1 is obsolete| | Attachment #85740|0 |1 is obsolete| | Attachment #85741|0 |1 is obsolete| | --- Comment #27 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 85758 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85758&action=edit Bug 21846: Add Koha::Tags::Approval(s) and Koha::Tags::Index(es) In order to avoid writing the tests using plain DBIC which would later need to be replaced by a Koha::Object-based counterpart, I introduce this stub classes. Stub tests are added as well. To test: - Apply this patch - Run: $ kshell k$ prove t/db_dependent/Koha/Tags.t \ t/db_dependent/Koha/Tags/Approvals.t \ t/db_dependent/Koha/Tags/Indexes.t => SUCCESS: Tests pass - Sign off :-D Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21846 --- Comment #28 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 85759 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85759&action=edit Bug 21846: Regression tests for add_tag_approval Due to collation issues, add_tag_approval wrongly calculates the weight for strings including extended UNICODE characters. This patch introduces a test for this situation. To test: - Apply this patch on master - Run: $ kshell k$ prove t/db_dependent/Tags.t => FAIL: Tests fail because all extended characters match the same Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21846 --- Comment #29 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 85760 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85760&action=edit Bug 21846: Make 'term' use utf8mb_bin collation on tags tables This patch makes the utf8mb4_bin collation preferred for comparing tags. Otherwise suppolemental unicode characters all match. To test: - Enable tags and disable moderation (or plan to moderate and accept tags) - Tag 3 records: a - with 🐋 b - with 🌮 c - with 👍 - Note the weight on each says '3' - Click the tag to search, you get back all the records - Apply the previous patches from this bug report - Run: $ kshell k$ prove t/db_dependent/Tags.t => FAIL: Tests fail, related to counting stuffs - Apply this patch and (a) Run updatedatabase to upgrade the schema - Run: k$ prove t/db_dependent/Tags.t => SUCCESS: Tests pass! (b) reset_all to get a fresh DB using kohastructure.sql - Run: k$ prove t/db_dependent/Tags.t => SUCCESS: Tests pass too! - Sign off :-D Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21846 --- Comment #30 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 85761 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85761&action=edit Bug 21846: (follow-up) Add maintenance script This patch adds a maintenance script that generates the missing tags_approval entries based on the tags_all table, and then recalculates the weights for both tags_approval and tags_index tables. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21846 --- Comment #31 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 85762 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85762&action=edit Bug 21846: (QA follow-up) Fix maintenance script path Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21846 --- Comment #32 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 85763 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85763&action=edit Bug 21846: Fix pod2usage return values According to existing pattern. However I am not sure it makes sense to return an errno (and print to STDERR) if --help is passed. Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21846 --- Comment #33 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 85764 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85764&action=edit Bug 21846: Simplify ugly double for loops Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21846 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |josef.moravec@gmail.com QA Contact|testopia@bugs.koha-communit |josef.moravec@gmail.com |y.org | --- Comment #34 from Josef Moravec <josef.moravec@gmail.com> --- The one QA tools complain is false positive here. Tests are passing. I tested maintance script by setting bad data in database manually and let the script fix it ;) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21846 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Signed Off --- Comment #35 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Jonathan Druart from comment #20)
1. Maybe we should display the WARNING during the updatedb process only if really needed?
2. How do I test the maintenance script?
3. Why no module for tags_all?
This is without answer, setting back to SO. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21846 --- Comment #36 from Tomás Cohen Arazi <tomascohen@gmail.com> --- (In reply to Jonathan Druart from comment #35)
(In reply to Jonathan Druart from comment #20)
1. Maybe we should display the WARNING during the updatedb process only if really needed?
2. How do I test the maintenance script?
3. Why no module for tags_all?
This is without answer, setting back to SO.
There is Koha::Tags for that. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21846 --- Comment #37 from Tomás Cohen Arazi <tomascohen@gmail.com> --- (In reply to Jonathan Druart from comment #20)
1. Maybe we should display the WARNING during the updatedb process only if really needed?
2. How do I test the maintenance script?
To test: - Enable tags and disable moderation (or plan to moderate and accept tags) - Tag 3 records: a - with 🐋 b - with 🌮 c - with 👍 - Note the weight on each says '3' - Click the tag to search, you get back all the records - Apply the previous patches from this bug report - Run: $ updatedatabase to upgrade the schema $ kshell k$ perl misc/maintenance/fix_tags_weight.pl => SUCCESS: the weights make sense -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21846 --- Comment #38 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- In my opinion we should fix bug 22420 first. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21846 --- Comment #39 from Tomás Cohen Arazi <tomascohen@gmail.com> --- (In reply to Jonathan Druart from comment #38)
In my opinion we should fix bug 22420 first.
No, 22420 won't be fixed if the weights are wrongly calculated, which is fixed here. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21846 --- Comment #40 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Tomás Cohen Arazi from comment #39)
(In reply to Jonathan Druart from comment #38)
In my opinion we should fix bug 22420 first.
No, 22420 won't be fixed if the weights are wrongly calculated, which is fixed here.
IIRC it affects any tags, not only emoji. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21846 --- Comment #41 from Tomás Cohen Arazi <tomascohen@gmail.com> --- (In reply to Jonathan Druart from comment #40)
(In reply to Tomás Cohen Arazi from comment #39)
(In reply to Jonathan Druart from comment #38)
In my opinion we should fix bug 22420 first.
No, 22420 won't be fixed if the weights are wrongly calculated, which is fixed here.
IIRC it affects any tags, not only emoji.
Yes, what I'm saying is that even though they are both about tags, they aren't really dependent as you propose. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21846 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com --- Comment #42 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- This looks solid to me and seems to work.. can this go to PQA Josef.. or are you waiting on some further feedback here? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21846 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #43 from Josef Moravec <josef.moravec@gmail.com> --- I agree with Tomas, we should fix bug 22420 independently. This patchset works, code is OK and fixes the described bug, so setting PQA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21846 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #44 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21846 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #45 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Pushed to 18.11.x for 18.11.04 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21846 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |Please note, this patch release notes| |fixes issues going forward. | |It includes a maintenance | |script to allow you to fix | |any possible existing | |cases. Please see bugzilla | |for details. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21846 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #46 from Lucas Gass <lucas@bywatersolutions.com> --- not backporting to 18.05.x series -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21846 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to Stable |RESOLVED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21846 Michael Kuhn <mik@adminkuhn.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mik@adminkuhn.ch --- Comment #47 from Michael Kuhn <mik@adminkuhn.ch> --- When updating from Koha 18.11 to Koha 19.05 the update process says: Upgrade to 18.12.00.025 done (Bug 21846 - Using emoji as tags has broken weights) WARNING: (Bug 21846) You need to manually run /usr/share/koha/intranet/cgi-bin/misc/maintenance/fix_tags_weight.pl to fix possible issues with tags. But in fact the script "fix_tags_weight.pl" is located at "/usr/share/koha/bin/maintenance/fix_tags_weight.pl". -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21846 --- Comment #48 from Tomás Cohen Arazi <tomascohen@gmail.com> --- (In reply to Michael Kuhn from comment #47)
When updating from Koha 18.11 to Koha 19.05 the update process says:
Upgrade to 18.12.00.025 done (Bug 21846 - Using emoji as tags has broken weights) WARNING: (Bug 21846) You need to manually run /usr/share/koha/intranet/cgi-bin/misc/maintenance/fix_tags_weight.pl to fix possible issues with tags.
But in fact the script "fix_tags_weight.pl" is located at "/usr/share/koha/bin/maintenance/fix_tags_weight.pl".
Thanks for reporting it. I will file a new bug for this. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21846 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |23056 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23056 [Bug 23056] Wrong path for fix_tags_weight.pl in updatedatabase.pl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21846 --- Comment #49 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- bug 23056 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org