[Bug 15921] New: DataTables JavaScript files included twice on many pages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15921 Bug ID: 15921 Summary: DataTables JavaScript files included twice on many pages Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org datatables.inc loads jquery.dataTables.min.js, dataTables.buttons.min.js, and buttons.colVis.min.js columns_settings.inc also loads dataTables.buttons.min.js, buttons.colVis.min.js This would be fine if each were used independently, but columns_settings.inc is always included along with datatables.inc. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15921 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Is there any reason to include dataTables.buttons.min.js and buttons.colVis.min.js on pages which do not have columns configuration enabled? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15921 --- Comment #2 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- datatables.inc loads dataTables.buttons.min.js and buttons.colVis.min.js since bug 15285: Update common files because the dom param now contains 'B'. The DT init fails with it does not know what 'B' means. So yes, now it does not make sense to have them included in both files. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15921 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15921 --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 48433 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48433&action=edit Bug 15921: Do not include datatables js/css files twice datatables.inc loads dataTables.buttons.min.js and buttons.colVis.min.js since bug 15285: Update common files because the dom param now contains 'B'. The DT init fails with it does not know what 'B' means. Test plan: Test tables using buttons (columns visibility), they should work as before this patch. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15921 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |jonathan.druart@bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15921 Srdjan Jankovic <srdjan@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15921 Srdjan Jankovic <srdjan@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48433|0 |1 is obsolete| | --- Comment #4 from Srdjan Jankovic <srdjan@catalyst.net.nz> --- Created attachment 49082 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49082&action=edit [SIGNED-OFF] Bug 15921: Do not include datatables js/css files twice datatables.inc loads dataTables.buttons.min.js and buttons.colVis.min.js since bug 15285: Update common files because the dom param now contains 'B'. The DT init fails with it does not know what 'B' means. Test plan: Test tables using buttons (columns visibility), they should work as before this patch. Signed-off-by: Srdjan <srdjan@catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15921 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Status|Signed Off |Failed QA --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- With this patch "columns visibility" on administration/currencies doesn't appear to work anymore. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15921 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15921 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #49082|0 |1 is obsolete| | --- Comment #6 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 49386 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49386&action=edit Bug 15921: Do not include datatables js/css files twice datatables.inc loads dataTables.buttons.min.js and buttons.colVis.min.js since bug 15285: Update common files because the dom param now contains 'B'. The DT init fails with it does not know what 'B' means. Test plan: Test tables using buttons (columns visibility), they should work as before this patch. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15921 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #49386|0 |1 is obsolete| | --- Comment #7 from Marc Véron <veron@veron.ch> --- Created attachment 49433 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49433&action=edit Bug 15921: Do not include datatables js/css files twice datatables.inc loads dataTables.buttons.min.js and buttons.colVis.min.js since bug 15285: Update common files because the dom param now contains 'B'. The DT init fails with it does not know what 'B' means. Test plan: Test tables using buttons (columns visibility), they should work as before this patch. Tested with patron search and administration/currencies, works as expected. Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15921 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Trivial patch CC| |veron@veron.ch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15921 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15921 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #49433|0 |1 is obsolete| | --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 49481 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49481&action=edit [PASSED QA] Bug 15921: Do not include datatables js/css files twice datatables.inc loads dataTables.buttons.min.js and buttons.colVis.min.js since bug 15285: Update common files because the dom param now contains 'B'. The DT init fails with it does not know what 'B' means. Test plan: Test tables using buttons (columns visibility), they should work as before this patch. Tested with patron search and administration/currencies, works as expected. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15921 Brendan Gallagher <brendan@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |brendan@bywatersolutions.co | |m Status|Passed QA |Pushed to Master --- Comment #9 from Brendan Gallagher <brendan@bywatersolutions.com> --- Pushed to Master - should be in the May 2016 release. Thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15921 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice@biblibre.com Resolution|--- |FIXED Status|Pushed to Master |RESOLVED --- Comment #10 from Julian Maurice <julian.maurice@biblibre.com> --- Not needed in stable versions, status changed to RESOLVED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org