[Bug 41954] New: Patron hold history table should show hyperhold/hold group information
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41954 Bug ID: 41954 Summary: Patron hold history table should show hyperhold/hold group information Initiative type: --- Sponsorship --- status: Product: Koha Version: 25.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: sbrown@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: andrew@bywatersolutions.com, gmcharlt@gmail.com, kyle@bywatersolutions.com In the staff interface, patrons' Hold history tab/holdshistory.pl should have a column for the hold_group_id. This will allow staff to readily see if an individual hold was part of a hyperhold, which will be important for troubleshooting. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41954 Sara Brown <sbrown@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=41955 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41954 Sara Brown <sbrown@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Patron hold history table |Staff interface: Patron |should show hyperhold/hold |hold history table should |group information |show hyperhold/hold group | |information -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41954 Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |emily.lamancusa@montgomeryc | |ountymd.gov Depends on| |15516 See Also|https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=15516 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 [Bug 15516] Allow to place a hold on first available item from a group of titles -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41954 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |41955 CC| |pedro.amorim@openfifth.co.u | |k Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41955 [Bug 41955] OPAC: Patron hold history table should show hyperhold/hold group information -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41954 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41954 --- Comment #1 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 196728 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196728&action=edit Bug 41954: Update existing tests The logical behavior is different. Hold groups are now meant to be kept for historical reasons -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41954 --- Comment #2 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 196729 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196729&action=edit Bug 41954: Preparation: No longer delete 'empty' hold groups Hold groups are now only deleted if no holds or old_holds are attached at the moment of cleanup -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41954 --- Comment #3 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 196730 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196730&action=edit Bug 41954: Display historic group hold ID in patron holds history table Test plan: 1) Enable DisplayAddHoldGroups sys prefs 2) Go to 'Henry' and click 'Search to hold': <staff_url>/cgi-bin/koha/members/moremember.pl?borrowernumber=19 3) Search for 'test' and click the top 'Select all' link 4) Click the downward arrow in the 'Place hold' button and pick 'Place hold for Henry' 5) Set a pickup location for each hold and tick the 'Treat as hold group' checkbox 6) Click 'Place holds'. 7) Check-out an eligible barcode e.g.: 39999000005578 to Henry 8) Visit Henry's holds history: <staff_url>/cgi-bin/koha/members/holdshistory.pl?borrowernumber=19 9) Confirm that a new 'Hold group ID' column exists. 10) Disable DisplayAddHoldsGroups sys prefs. Confirm table looks as expected without the column. Run all hold groups tests: prove t/db_dependent/Koha/Patron.t prove t/db_dependent/api/v1/patrons_hold_groups.t prove t/db_dependent/Koha/Hold.t prove t/db_dependent/Reserves/HoldGroup.t -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41954 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |pedro.amorim@openfifth.co.u |ity.org |k -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41954 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|25.11 |Main QA Contact|testopia@bugs.koha-communit |andrew@bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41954 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41954 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #196728|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41954 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #196729|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41954 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #196730|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41954 --- Comment #4 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 196749 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196749&action=edit Bug 41954: Update existing tests The logical behavior is different. Hold groups are now meant to be kept for historical reasons Signed-off-by: Bob Bennhoff <bbennhoff@clicweb.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41954 --- Comment #5 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 196750 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196750&action=edit Bug 41954: Preparation: No longer delete 'empty' hold groups Hold groups are now only deleted if no holds or old_holds are attached at the moment of cleanup Signed-off-by: Bob Bennhoff <bbennhoff@clicweb.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41954 --- Comment #6 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 196751 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196751&action=edit Bug 41954: Display historic group hold ID in patron holds history table Test plan: 1) Enable DisplayAddHoldGroups sys prefs 2) Go to 'Henry' and click 'Search to hold': <staff_url>/cgi-bin/koha/members/moremember.pl?borrowernumber=19 3) Search for 'test' and click the top 'Select all' link 4) Click the downward arrow in the 'Place hold' button and pick 'Place hold for Henry' 5) Set a pickup location for each hold and tick the 'Treat as hold group' checkbox 6) Click 'Place holds'. 7) Check-out an eligible barcode e.g.: 39999000005578 to Henry 8) Visit Henry's holds history: <staff_url>/cgi-bin/koha/members/holdshistory.pl?borrowernumber=19 9) Confirm that a new 'Hold group ID' column exists. 10) Disable DisplayAddHoldsGroups sys prefs. Confirm table looks as expected without the column. Run all hold groups tests: prove t/db_dependent/Koha/Patron.t prove t/db_dependent/api/v1/patrons_hold_groups.t prove t/db_dependent/Koha/Hold.t prove t/db_dependent/Reserves/HoldGroup.t Signed-off-by: Bob Bennhoff <bbennhoff@clicweb.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41954 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #196749|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41954 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #196750|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41954 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #196751|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41954 --- Comment #7 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 196752 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196752&action=edit Bug 41954: Update existing tests The logical behavior is different. Hold groups are now meant to be kept for historical reasons Signed-off-by: Bob Bennhoff <bbennhoff@clicweb.org> Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41954 --- Comment #8 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 196753 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196753&action=edit Bug 41954: Preparation: No longer delete 'empty' hold groups Hold groups are now only deleted if no holds or old_holds are attached at the moment of cleanup Signed-off-by: Bob Bennhoff <bbennhoff@clicweb.org> Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41954 --- Comment #9 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 196754 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196754&action=edit Bug 41954: Display historic group hold ID in patron holds history table Test plan: 1) Enable DisplayAddHoldGroups sys prefs 2) Go to 'Henry' and click 'Search to hold': <staff_url>/cgi-bin/koha/members/moremember.pl?borrowernumber=19 3) Search for 'test' and click the top 'Select all' link 4) Click the downward arrow in the 'Place hold' button and pick 'Place hold for Henry' 5) Set a pickup location for each hold and tick the 'Treat as hold group' checkbox 6) Click 'Place holds'. 7) Check-out an eligible barcode e.g.: 39999000005578 to Henry 8) Visit Henry's holds history: <staff_url>/cgi-bin/koha/members/holdshistory.pl?borrowernumber=19 9) Confirm that a new 'Hold group ID' column exists. 10) Disable DisplayAddHoldsGroups sys prefs. Confirm table looks as expected without the column. Run all hold groups tests: prove t/db_dependent/Koha/Patron.t prove t/db_dependent/api/v1/patrons_hold_groups.t prove t/db_dependent/Koha/Hold.t prove t/db_dependent/Reserves/HoldGroup.t Signed-off-by: Bob Bennhoff <bbennhoff@clicweb.org> Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41954 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41954 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Patch doesn't apply CC| |lucas@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41954 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41954 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #196752|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41954 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #196753|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41954 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #196754|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41954 --- Comment #10 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 197497 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=197497&action=edit Bug 41954: Update existing tests The logical behavior is different. Hold groups are now meant to be kept for historical reasons Signed-off-by: Bob Bennhoff <bbennhoff@clicweb.org> Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41954 --- Comment #11 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 197498 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=197498&action=edit Bug 41954: Preparation: No longer delete 'empty' hold groups Hold groups are now only deleted if no holds or old_holds are attached at the moment of cleanup Signed-off-by: Bob Bennhoff <bbennhoff@clicweb.org> Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41954 --- Comment #12 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 197499 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=197499&action=edit Bug 41954: Display historic group hold ID in patron holds history table Test plan: 1) Enable DisplayAddHoldGroups sys prefs 2) Go to 'Henry' and click 'Search to hold': <staff_url>/cgi-bin/koha/members/moremember.pl?borrowernumber=19 3) Search for 'test' and click the top 'Select all' link 4) Click the downward arrow in the 'Place hold' button and pick 'Place hold for Henry' 5) Set a pickup location for each hold and tick the 'Treat as hold group' checkbox 6) Click 'Place holds'. 7) Check-out an eligible barcode e.g.: 39999000005578 to Henry 8) Visit Henry's holds history: <staff_url>/cgi-bin/koha/members/holdshistory.pl?borrowernumber=19 9) Confirm that a new 'Hold group ID' column exists. 10) Disable DisplayAddHoldsGroups sys prefs. Confirm table looks as expected without the column. Run all hold groups tests: prove t/db_dependent/Koha/Patron.t prove t/db_dependent/api/v1/patrons_hold_groups.t prove t/db_dependent/Koha/Hold.t prove t/db_dependent/Reserves/HoldGroup.t Signed-off-by: Bob Bennhoff <bbennhoff@clicweb.org> Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41954 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |26.05.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41954 --- Comment #13 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to main for 26.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41954 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_25_11_candidate -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41954 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Pushed to stable Version(s)|26.05.00 |26.05.00,25.11.05 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41954 --- Comment #14 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Thanks all, pushed to 25.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41954 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Needs documenting CC| |wainuiwitikapark@catalyst.n | |et.nz --- Comment #15 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Enhancement - not backporting to 25.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41954 Sara Brown <sbrown@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=43006 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41954 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@gmail.com Blocks| |43006 --- Comment #16 from Jonathan Druart <jonathan.druart@gmail.com> --- The column is missing from the yml file. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43006 [Bug 43006] 'Current holds' table in patron hold history tab is missing column for hold_group_id -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org