[Bug 7871] New: Crash on suggestion pages when a budget in use has been deleted
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7871 Priority: P5 - low Change sponsored?: --- Bug ID: 7871 Assignee: adrien.saurat@biblibre.com Summary: Crash on suggestion pages when a budget in use has been deleted QA Contact: koha.sekjal@gmail.com Severity: minor Classification: Unclassified OS: All Reporter: adrien.saurat@biblibre.com Hardware: All Status: ASSIGNED Version: master Component: Acquisitions Product: Koha [MT8748] TEST PLAN: 1) Create a new budget/fund which will be deleted later. 2) Add a suggestion attached to the new fund. 3) Delete the fund. 4) When trying to access the suggestion management pages, koha crashes and display this error message: Can't use an undefined value as a HASH reference at /home/asaurat/workspace/versions/community/suggestion/suggestion.pl line 208. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7871 --- Comment #1 from Adrien SAURAT <adrien.saurat@biblibre.com> --- Created attachment 8797 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8797&action=edit proposed patch #1 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7871 Adrien SAURAT <adrien.saurat@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff --- Comment #2 from Adrien SAURAT <adrien.saurat@biblibre.com> --- Sent a patch preventing the undefined hash problem. But maybe we should also do that, when a budget is deleted, all linked "budgetid" in suggestions are set to NULL ? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7871 --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- (In reply to comment #2)
But maybe we should also do that, when a budget is deleted, all linked "budgetid" in suggestions are set to NULL ?
This sounds good to me. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7871 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #8797|0 |1 is obsolete| | --- Comment #4 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 9033 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9033&action=edit Bug 7871: prevents crash when suggestion linked to erased budget Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7871 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |chris@bigballofwax.co.nz -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7871 Ian Walls <koha.sekjal@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #5 from Ian Walls <koha.sekjal@gmail.com> --- Breaks out a complex one-liner with lots of assumptions of existence into multiple lines with the proper conditional checks. Marking Passed QA. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7871 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |paul.poulain@biblibre.com Version|master |rel_3_8 Severity|minor |normal -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org