[Bug 22790] New: The system preference itemBarcodeInputFilter is not applied for barcodes inputed via SIP2
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22790 Bug ID: 22790 Summary: The system preference itemBarcodeInputFilter is not applied for barcodes inputed via SIP2 Change sponsored?: --- Product: Koha Version: 18.11 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: SIP2 Assignee: koha-bugs@lists.koha-community.org Reporter: andreas.jonsson@kreablo.se QA Contact: testopia@bugs.koha-community.org CC: colin.campbell@ptfs-europe.com Target Milestone: --- I would expect the filter specified by the system preference itemBarcodeInputFilter to be applied to any item barcode inputed to the system. As equipment connected via SIP2 is used to input item barcodes, the filter should be applied. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22790 --- Comment #1 from Andreas Jonsson <andreas.jonsson@kreablo.se> --- Created attachment 88966 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88966&action=edit Bug 22790: The system preference itemBarcodeInputFilter is not applied for barcodes inputed via SIP2 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22790 --- Comment #2 from Andreas Jonsson <andreas.jonsson@kreablo.se> --- Testplan for kohadevbox: 1. Set syspref itemBarcodeInputFilter to "Remove spaces from" 2. Disable syspref RequireStrongPassword 3. Add a bibliographic record 4. Add an item with barcode '12' 5. Add a borrower with cardnumber 2 and password aaa 6 Add a borrower with username term1 and password term1 and grant circulate permissions 7. Confirm that this input match the item added in step 2. 8. Login to server via ssh and run 'sudo koha-sip-enable kohadev && sudo koha-start-sip kohadev' 9. Try checking out an item using sip: /usr/share/koha/bin/sip_cli_emulator.pl --sip_user=term1 --sip_pass=term1 --patron=2 --password=aaa --item='1 2' -m checkout -a 127.0.0.1 -p 6001 -l MAIN 10. Without patch, the sip response will be 'Invalid item' 11. With patch, the sip response will be 'Item cannot be issued: TOO_MANY' (or any other response indicating that the item was at least found) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22790 Andreas Jonsson <andreas.jonsson@kreablo.se> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22790 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wizzyrea@gmail.com --- Comment #3 from Liz Rea <wizzyrea@gmail.com> --- Can I just say this test plan is A+ very good, thank you! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22790 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22790 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88966|0 |1 is obsolete| | --- Comment #4 from Liz Rea <wizzyrea@gmail.com> --- Created attachment 89394 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89394&action=edit Bug 22790: The system preference itemBarcodeInputFilter is not applied for barcodes inputed via SIP2 Signed-off-by: Liz Rea <wizzyrea@gmail.com> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22790 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22790 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #89394|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 89476 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89476&action=edit Bug 22790: The system preference itemBarcodeInputFilter is not applied for barcodes inputed via SIP2 Signed-off-by: Liz Rea <wizzyrea@gmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22790 --- Comment #6 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 89477 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89477&action=edit Bug 22790: Add a test Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22790 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |nick@bywatersolutions.com --- Comment #7 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22790 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Resolution|--- |FIXED Status|Pushed to Master |RESOLVED --- Comment #8 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- This bugfix results in a change of behaviour that some systems may not be expecting in a stable release, as such I've chosen not to backport for the 18.11.x series. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org