[Bug 28974] New: Add pagination to holds queue viewer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28974 Bug ID: 28974 Summary: Add pagination to holds queue viewer Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Hold requests Assignee: koha-bugs@lists.koha-community.org Reporter: kyle@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com We have a partner processing thousands of holds per day, per branch. At this number of holds, the script loads very slow if it manages to load at all. Paginating the results of the holds queue will allow this page more flexible and load more quickly. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28974 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28974 --- Comment #1 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 124660 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124660&action=edit Bug 28974: Add pagination to holds queue viewer We have a partner processing thousands of holds per day, per branch. At this number of holds, the script loads very slow if it manages to load at all. Paginating the results of the holds queue will allow this page more flexible and load more quickly. Test Plan 1) Generate a lot of holds in the holds queue 2) Apply this patch 3) Try out the new pagination bar 4) Ensure the limit and page features function correctly -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28974 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |28966 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28966 [Bug 28966] Holds queue viewer too slow to load for large numbers of holds -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28974 --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Will it still be possible to print the whole queue over multiple pages? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28974 --- Comment #3 from Kyle M Hall <kyle@bywatersolutions.com> --- (In reply to Katrin Fischer from comment #2)
Will it still be possible to print the whole queue over multiple pages?
Yes, you can choose the number of results per page. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28974 Emmi Takkinen <emmi.takkinen@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |emmi.takkinen@koha-suomi.fi --- Comment #4 from Emmi Takkinen <emmi.takkinen@koha-suomi.fi> --- I think this needs some improvement. I have over 600 holds on my list. I first selected 10 rows per page and moved to page 3. Then I changed rows per page as 1000 assuming all holds would be displayed. Instead I got blank page. I had to switch back to 10 rows per page, go to page 1 and then select 1000 per page to see all of my holds. IMO it would be more user friendly to e.g. return to the first page if rows per page is changed. Otherwise this works fine. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28974 --- Comment #5 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 124864 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124864&action=edit Bug 28974: Start at first page when change number of results per page -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28974 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |kyle@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28974 Emmi Takkinen <emmi.takkinen@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #124660|0 |1 is obsolete| | --- Comment #6 from Emmi Takkinen <emmi.takkinen@koha-suomi.fi> --- Created attachment 124874 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124874&action=edit Bug 28974: Add pagination to holds queue viewer We have a partner processing thousands of holds per day, per branch. At this number of holds, the script loads very slow if it manages to load at all. Paginating the results of the holds queue will allow this page more flexible and load more quickly. Test Plan 1) Generate a lot of holds in the holds queue 2) Apply this patch 3) Try out the new pagination bar 4) Ensure the limit and page features function correctly Signed-off-by: Emmi Takkinen <emmi.takkinen@koha-suomi.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28974 Emmi Takkinen <emmi.takkinen@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #124864|0 |1 is obsolete| | --- Comment #7 from Emmi Takkinen <emmi.takkinen@koha-suomi.fi> --- Created attachment 124875 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124875&action=edit Bug 28974: Start at first page when change number of results per page Signed-off-by: Emmi Takkinen <emmi.takkinen@koha-suomi.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28974 Emmi Takkinen <emmi.takkinen@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28974 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #124874|0 |1 is obsolete| | Attachment #124875|0 |1 is obsolete| | --- Comment #8 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 125291 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125291&action=edit Bug 28974: Add pagination to holds queue viewer We have a partner processing thousands of holds per day, per branch. At this number of holds, the script loads very slow if it manages to load at all. Paginating the results of the holds queue will allow this page more flexible and load more quickly. Test Plan 1) Generate a lot of holds in the holds queue 2) Apply this patch 3) Try out the new pagination bar 4) Ensure the limit and page features function correctly Signed-off-by: Emmi Takkinen <emmi.takkinen@koha-suomi.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28974 --- Comment #9 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 125292 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125292&action=edit Bug 28974: Start at first page when change number of results per page Signed-off-by: Emmi Takkinen <emmi.takkinen@koha-suomi.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28974 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #125291|0 |1 is obsolete| | Attachment #125292|0 |1 is obsolete| | --- Comment #10 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 125295 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125295&action=edit Bug 28974: Add pagination to holds queue viewer We have a partner processing thousands of holds per day, per branch. At this number of holds, the script loads very slow if it manages to load at all. Paginating the results of the holds queue will allow this page more flexible and load more quickly. Test Plan 1) Generate a lot of holds in the holds queue 2) Apply this patch 3) Try out the new pagination bar 4) Ensure the limit and page features function correctly Signed-off-by: Emmi Takkinen <emmi.takkinen@koha-suomi.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28974 --- Comment #11 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 125296 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125296&action=edit Bug 28974: Start at first page when change number of results per page Signed-off-by: Emmi Takkinen <emmi.takkinen@koha-suomi.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28974 --- Comment #12 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 125297 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125297&action=edit Bug 28974: Hard code page = 1 instead of using javascript -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28974 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #125295|0 |1 is obsolete| | Attachment #125296|0 |1 is obsolete| | Attachment #125297|0 |1 is obsolete| | --- Comment #13 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 125371 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125371&action=edit Bug 28974: Add pagination to holds queue viewer We have a partner processing thousands of holds per day, per branch. At this number of holds, the script loads very slow if it manages to load at all. Paginating the results of the holds queue will allow this page more flexible and load more quickly. Test Plan 1) Generate a lot of holds in the holds queue 2) Apply this patch 3) Try out the new pagination bar 4) Ensure the limit and page features function correctly Signed-off-by: Emmi Takkinen <emmi.takkinen@koha-suomi.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28974 --- Comment #14 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 125372 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125372&action=edit Bug 28974: Start at first page when change number of results per page Signed-off-by: Emmi Takkinen <emmi.takkinen@koha-suomi.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28974 --- Comment #15 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 125373 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125373&action=edit Bug 28974: Hard code page = 1 instead of using javascript -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28974 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #125371|0 |1 is obsolete| | Attachment #125372|0 |1 is obsolete| | Attachment #125373|0 |1 is obsolete| | --- Comment #16 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 125399 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125399&action=edit Bug 28974: Add pagination to holds queue viewer We have a partner processing thousands of holds per day, per branch. At this number of holds, the script loads very slow if it manages to load at all. Paginating the results of the holds queue will allow this page more flexible and load more quickly. Test Plan 1) Generate a lot of holds in the holds queue 2) Apply this patch 3) Try out the new pagination bar 4) Ensure the limit and page features function correctly Signed-off-by: Emmi Takkinen <emmi.takkinen@koha-suomi.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28974 --- Comment #17 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 125400 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125400&action=edit Bug 28974: Start at first page when change number of results per page Signed-off-by: Emmi Takkinen <emmi.takkinen@koha-suomi.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28974 --- Comment #18 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 125401 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125401&action=edit Bug 28974: Hard code page = 1 instead of using javascript -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28974 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #125399|0 |1 is obsolete| | Attachment #125400|0 |1 is obsolete| | Attachment #125401|0 |1 is obsolete| | --- Comment #19 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 125414 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125414&action=edit Bug 28974: Add pagination to holds queue viewer We have a partner processing thousands of holds per day, per branch. At this number of holds, the script loads very slow if it manages to load at all. Paginating the results of the holds queue will allow this page more flexible and load more quickly. Test Plan 1) Generate a lot of holds in the holds queue 2) Apply this patch 3) Try out the new pagination bar 4) Ensure the limit and page features function correctly Signed-off-by: Emmi Takkinen <emmi.takkinen@koha-suomi.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28974 --- Comment #20 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 125415 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125415&action=edit Bug 28974: Start at first page when change number of results per page Signed-off-by: Emmi Takkinen <emmi.takkinen@koha-suomi.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28974 --- Comment #21 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 125416 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125416&action=edit Bug 28974: Hard code page = 1 instead of using javascript -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28974 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #125414|0 |1 is obsolete| | Attachment #125415|0 |1 is obsolete| | Attachment #125416|0 |1 is obsolete| | --- Comment #22 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 125424 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125424&action=edit Bug 28974: Add pagination to holds queue viewer We have a partner processing thousands of holds per day, per branch. At this number of holds, the script loads very slow if it manages to load at all. Paginating the results of the holds queue will allow this page more flexible and load more quickly. Test Plan 1) Generate a lot of holds in the holds queue 2) Apply this patch 3) Try out the new pagination bar 4) Ensure the limit and page features function correctly Signed-off-by: Emmi Takkinen <emmi.takkinen@koha-suomi.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28974 --- Comment #23 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 125425 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125425&action=edit Bug 28974: Start at first page when change number of results per page Signed-off-by: Emmi Takkinen <emmi.takkinen@koha-suomi.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28974 --- Comment #24 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 125426 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125426&action=edit Bug 28974: Hard code page = 1 instead of using javascript -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28974 --- Comment #25 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 126277 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126277&action=edit Bug 28974: (follow-up) Pass total number of items instead of count per page Before pagination the count of items was the same as the total, now they will differ Make sure to pass $total to the template instead fo the count per page -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28974 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply --- Comment #26 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- There is an issue with the depending bug needing some more work, but this also doesn't apply cleanly on top: Bug 28974 Depends on bug 28966 (Signed Off) Follow? [(y)es, (n)o] y Bug 28966 - Holds queue viewer too slow to load for large numbers of holds 125377 - Bug 28966: Prefetch patron data for holds queue viewer Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 28966: Prefetch patron data for holds queue viewer Bug 28974 - Add pagination to holds queue viewer 125424 - Bug 28974: Add pagination to holds queue viewer 125425 - Bug 28974: Start at first page when change number of results per page 125426 - Bug 28974: Hard code page = 1 instead of using javascript 126277 - Bug 28974: (follow-up) Pass total number of items instead of count per page Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 28974: Add pagination to holds queue viewer error: sha1 information is lacking or useless (C4/HoldsQueue.pm). error: could not build fake ancestor Patch failed at 0001 Bug 28974: Add pagination to holds queue viewer hint: Use 'git am --show-current-patch=diff' to see the failed patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-28974-Add-pagination-to-holds-queue-viewer-HdA_x4.patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28974 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28974 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #125424|0 |1 is obsolete| | Attachment #125425|0 |1 is obsolete| | Attachment #125426|0 |1 is obsolete| | Attachment #126277|0 |1 is obsolete| | --- Comment #27 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 168355 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=168355&action=edit Bug 28974: Add pagination to holds queue viewer We have a partner processing thousands of holds per day, per branch. At this number of holds, the script loads very slow if it manages to load at all. Paginating the results of the holds queue will allow this page more flexible and load more quickly. Test Plan 1) Generate a lot of holds in the holds queue 2) Apply this patch 3) Try out the new pagination bar 4) Ensure the limit and page features function correctly Signed-off-by: Emmi Takkinen <emmi.takkinen@koha-suomi.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28974 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com --- Comment #28 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Rebased and squashed follow-ups -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28974 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice@biblibre.com --- Comment #29 from Julian Maurice <julian.maurice@biblibre.com> --- The pagination is working but the datatables features (filter, sort) only work on a single page. I think this can be confusing for users (when I click on a column header to sort, I expect the whole table to be sorted). It's still better than not being able to load the page at all I guess, but it will not be seen as an improvement for users that have more than 20 holds in that table and no problems loading it. Would it be difficult to turn this table into a full server-side/AJAX (filter, sort, pagination) table ? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28974 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |victor@tuxayo.net --- Comment #30 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Confirmed the above observations. There doesn't seems to be way around having to add filter and sort to the server side :/ If there is a way around, feel free to propose. For testing at scale: does anyone have a snippet to mass create holds? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28974 Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |emily.lamancusa@montgomeryc | |ountymd.gov -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org