[Bug 14551] New: Warns when sending a list via email on OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14551 Bug ID: 14551 Summary: Warns when sending a list via email on OPAC Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: aleishaamohia@hotmail.com QA Contact: testopia@bugs.koha-community.org opac-sendshelf.pl: Use of uninitialized value $sort_direction in string eq at /home/vagrant/kohaclone/C4/VirtualShelves.pm line 280 To recreate, select any list from the Lists menu on the OPAC click 'Send list' Enter an email address to send the list to and click 'Send' Notice warn -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14551 Aleisha Amohia <aleishaamohia@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14551 --- Comment #1 from Aleisha Amohia <aleishaamohia@hotmail.com> --- Created attachment 41049 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41049&action=edit Bug 14551: Silencing warn triggered by sending a list via email on OPAC Uninitialized value $sort_direction To test: 1) To recreate, select any list from the Lists menu on the OPAC 2) Click 'Send list' 3) Enter an email address to send the list to and click 'Send' 4) Notice warn in error log 5) Apply patch, refresh page and resend list 6) Notice warn is gone but page still works -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14551 --- Comment #2 from M. Tompsett <mtompset@hotmail.com> --- Comment on attachment 41049 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41049 Bug 14551: Silencing warn triggered by sending a list via email on OPAC Review of attachment 41049: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=14551&attachment=41049) ----------------------------------------------------------------- ::: C4/VirtualShelves.pm @@ +264,4 @@
$sth2->execute($shelfnumber); ($sortfield) = $sth2->fetchrow_array; } + $sort_direction //= '';
Am I missing something? I don't see a difference, except for white space and vertical spacing. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14551 Zeno Tajoli <z.tajoli@cineca.it> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14551 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |frederic@tamil.fr --- Comment #3 from Frédéric Demians <frederic@tamil.fr> --- I don't see any warning. The patch itself does nothing to my eyes. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14551 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |aleishaamohia@hotmail.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14551 Aleisha Amohia <aleishaamohia@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |INVALID Status|Failed QA |RESOLVED --- Comment #4 from Aleisha Amohia <aleishaamohia@hotmail.com> --- I don't see any option to Send List anymore so will set to Resolved -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14551 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Aleisha, have you been logged in when looking at the list? The feature still exists. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14551 Aleisha Amohia <aleishaamohia@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|INVALID |FIXED --- Comment #6 from Aleisha Amohia <aleishaamohia@hotmail.com> --- (In reply to Katrin Fischer from comment #5)
Hi Aleisha, have you been logged in when looking at the list? The feature still exists.
Oops you're right I did something weird there, feature still exists but warns are gone so will change to Fixed! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org