[Bug 39817] New: All list endpoints should have the x-koha-request-id parameter definition
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39817 Bug ID: 39817 Summary: All list endpoints should have the x-koha-request-id parameter definition Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: REST API Assignee: koha-bugs@lists.koha-community.org Reporter: tomascohen@gmail.com QA Contact: testopia@bugs.koha-community.org CC: tomascohen@gmail.com This is mandatory for using them with our `kohaTable` datatables wrapper. I spotted the `/acquisitions/baskets` endpoint doesn't have it. We should have a test for it. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39817 --- Comment #1 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 181869 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181869&action=edit Bug 39817: Add some GET routes tests This patch adds tests for to-be mandatory parameters for plural endpoints: * match * order_by * page * per_page * q_param * q_body * request_id_header Exceptions should be added if found in the wild, but the tests are needed. Another check it adds is GET requests `operationId` should start with: * list * get To test: 1. Run: $ ktd --shell k$ prove xt/api.t => FAIL: Tests pass! But our spec is bad 2. Apply this patch 3. Repeat 1 => SUCCESS: All mistakes make the tests fail! 4. Sign off :-D Note: a follow-up patch/set of patches should make this tests pass! Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org