http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13023 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13023 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt@gmail.com |kyle@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13023 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13023 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #31979|0 |1 is obsolete| | --- Comment #2 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 31980 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31980&action=edit Bug 13023 - Nonpublic note for items should be mapped to a database column like itemnotes An item's public notes are mapped to a db column, but the librarian only notes are not. We need to map these so in the future we may display them in places other than the editor. Test Plan: 1) Create an item with a non-public note 2) Apply this patch 3) Run updatedatabase 4) Run misc/maintenance/touch_all_items.pl 5) Inspect the database, note that your non-public note is now in items.itemnotes_nonpublic -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13023 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |nengard@gmail.com -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13023 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #31980|0 |1 is obsolete| | --- Comment #4 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 32400 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32400&action=edit Bug 13023 - Nonpublic note for items should be mapped to a database column like itemnotes An item's public notes are mapped to a db column, but the librarian only notes are not. We need to map these so in the future we may display them in places other than the editor. Test Plan: 1) Create an item with a non-public note 2) Apply this patch 3) Run updatedatabase 4) Run misc/migration_tools/copy_item_xml_field_to_db.pl --subfield x --column itemnotes_nonpublic -c -v 5) Inspect the database, note that your non-public note is now in items.itemnotes_nonpublic -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13023 --- Comment #6 from Kyle M Hall <kyle@bywatersolutions.com> --- Thanks for testing! The script touch_all_items does not do quite what I thought it did. We need a facility to copy data from more_subfields_xml to the database. As far as I can tell Koha does not have one, so I've written a script to do so and have included it in the patch. Please give it another try! Please note I've updated the test plan to include this. (In reply to Nick Clemens from comment #3)

I tried testing

created items with non-public notes apply patch upgrade database map itemnotes_nonpublic to 952x run touch_all_items.pl

all non-public notes still seemed to be in more_sbfields_xml

new notes worked as expected but I couldn't get old notes to transfer

-- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13023 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #32401|0 |1 is obsolete| | --- Comment #8 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 32513 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32513&action=edit Bug 13023 - Nonpublic note for items should be mapped to a database column like itemnotes An item's public notes are mapped to a db column, but the librarian only notes are not. We need to map these so in the future we may display them in places other than the editor. Test Plan: 1) Create an item with a non-public note 2) Apply this patch 3) Run updatedatabase 4) Update your frameworks to map your nonpublic item note to items.itemnotes_nonpublic 5) Run misc/batchRebuildItemsTables.pl 6) Inspect the database, note that your non-public note is now in items.itemnotes_nonpublic -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13023 Paola Rossi <paola.rossi@cineca.it> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #32513|0 |1 is obsolete| | --- Comment #9 from Paola Rossi <paola.rossi@cineca.it> --- Created attachment 32663 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32663&action=edit Bug 13023 - Nonpublic note for items should be mapped to a database column like itemnotes I've applied against mater 3.17.00.030 IMO everything is OK. I pass the patch to "Signed OFF" status. ------------------- On "Koha to MARC mapping", items' table, I saw these 2 rows about 952-x: itemnotes_nonpublic 952 x Non-public note paidfor 952 x Non-public note I asked to edit paidfor: no text was at the "900s" row. Anyway I unmapped paidfor, and in the items' table I saw: itemnotes_nonpublic 952 x Non-public note paidfor ------------------------- -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13023 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|major |enhancement --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I am not sure why this is marked as a major bug - improving the display of the internal notes seems like an enhancement? -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13023 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #32663|0 |1 is obsolete| | --- Comment #12 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 33501 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33501&action=edit Bug 13023 - Nonpublic note for items should be mapped to a database column like itemnotes An item's public notes are mapped to a db column, but the librarian only notes are not. We need to map these so in the future we may display them in places other than the editor. Test Plan: 1) Create an item with a non-public note 2) Apply this patch 3) Run updatedatabase 4) Update your frameworks to map your nonpublic item note to items.itemnotes_nonpublic 5) Run misc/batchRebuildItemsTables.pl 6) Inspect the database, note that your non-public note is now in items.itemnotes_nonpublic Signed-off-by: Paola Rossi <paola.rossi@cineca.it> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13023 --- Comment #13 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I have been working on a patch to clean up the frameworks, as we still have some mappings to 'paidfor' in the fast add frameworks (inconsistent mappings - ew!). But I think with this bug it would make more sense to update all the frameworks to include a mapping to the new column. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13023 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33501|0 |1 is obsolete| | --- Comment #14 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 34361 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34361&action=edit Bug 13023 - Nonpublic note for items should be mapped to a database column like itemnotes An item's public notes are mapped to a db column, but the librarian only notes are not. We need to map these so in the future we may display them in places other than the editor. Test Plan: 1) Create an item with a non-public note 2) Apply this patch 3) Run updatedatabase 4) Update your frameworks to map your nonpublic item note to items.itemnotes_nonpublic 5) Run misc/batchRebuildItemsTables.pl 6) Inspect the database, note that your non-public note is now in items.itemnotes_nonpublic Signed-off-by: Paola Rossi <paola.rossi@cineca.it> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13023 Brendan Gallagher <brendan@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34361|0 |1 is obsolete| | --- Comment #15 from Brendan Gallagher <brendan@bywatersolutions.com> --- Created attachment 34366 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34366&action=edit Bug 13023 - Nonpublic note for items should be mapped to a database column like itemnotes An item's public notes are mapped to a db column, but the librarian only notes are not. We need to map these so in the future we may display them in places other than the editor. Test Plan: 1) Create an item with a non-public note 2) Apply this patch 3) Run updatedatabase 4) Update your frameworks to map your nonpublic item note to items.itemnotes_nonpublic 5) Run misc/batchRebuildItemsTables.pl 6) Inspect the database, note that your non-public note is now in items.itemnotes_nonpublic Signed-off-by: Paola Rossi <paola.rossi@cineca.it> Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13023 Brendan Gallagher <brendan@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |brendan@bywatersolutions.co | |m --- Comment #17 from Brendan Gallagher <brendan@bywatersolutions.com> --- So this one has been sitting there for 1 months time. I've done some full out testing and I am passing this. Since this was done by Kyle I would encourage another QA to look at this too, if you have the time. Release manager if you feel that this must have another QA, let me know and I'll see who I can bug. This is pretty solid though and I think it would be ok to push. I leave that up to you all - and will acceptable whatever is decided. (My Goal is to just get a little more attention to this) Thanks, Brendan Gallagher -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13023 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34366|0 |1 is obsolete| | --- Comment #18 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 34416 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34416&action=edit Bug 13023 - Nonpublic note for items should be mapped to a database column like itemnotes An item's public notes are mapped to a db column, but the librarian only notes are not. We need to map these so in the future we may display them in places other than the editor. Test Plan: 1) Create an item with a non-public note 2) Apply this patch 3) Run updatedatabase 4) Update your frameworks to map your nonpublic item note to items.itemnotes_nonpublic 5) Run misc/batchRebuildItemsTables.pl 6) Inspect the database, note that your non-public note is now in items.itemnotes_nonpublic Signed-off-by: Paola Rossi <paola.rossi@cineca.it> Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13023 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34417|0 |1 is obsolete| | --- Comment #20 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 34418 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34418&action=edit Bug 13023 [QA Followup] - Add db mapping to default marc21 frameworks -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13023 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34427|0 |1 is obsolete| | --- Comment #22 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 34428 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34428&action=edit Bug 13023 [QA Followup] - Add db mapping to frameworks -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13023 --- Comment #24 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 35611 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35611&action=edit Bug 13023 [QA Followup] - Use db column for storage on item creation -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13023 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen@gmail.com --- Comment #26 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patches pushed to master. Thanks Kyle! -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13023 --- Comment #28 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Because the data is still in more_subfields_xml or items.paidfor (depending on the age of the installation) you will have problems accessing your data. I did a lot of tests when we tried to do that in the first iteration and there always remained problems (see bug 4222). -- You are receiving this mail because: You are watching all bug changes.