https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38839 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor Summary|Items replacementprice |Add validation for |disappears without warning |replacementprice and price | |fields in items form --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Kati, you are right that this should give a warning instead of failing silently. I have adjusted the bug description a little. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38839 Leo Stoyanov <leo.stoyanov@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38839 Leo Stoyanov <leo.stoyanov@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |Main CC| |leo.stoyanov@bywatersolutio | |ns.com Assignee|koha-bugs@lists.koha-commun |leo.stoyanov@bywatersolutio |ity.org |ns.com Patch complexity|--- |Small patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38839 --- Comment #3 from David Nind <david@davidnind.com> --- Created attachment 176285 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176285&action=edit Bug 38839: Add validation for replacement price in item and batch modification forms Adds validation for the replacement price on the item input and batch modification forms. Test plan: 1. Search for a record in the staff interface, select any record with an item, click "Edit", and select "Manage items". 2. Click "Actions" on the item in the table, select "Edit", and input an invalid "v - Cost, replacement price" (e.g., 1,00). 3. Click "Save changes" and the form will submit but with no price shown in the table on the next page. 4. Apply the patch, update the CSS (yarn build) and restart everything (restart_all). 5. Repeat steps 1-3. A red error message will now appear below the input field, notifying the user that only numbers and periods are allowed. The user will not be able to submit the form. 6. The same change was also made to the batch modification form under Cataloging > Batch item modification. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38839 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com Attachment #176279|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38839 --- Comment #6 from Leo Stoyanov <leo.stoyanov@bywatersolutions.com> --- Hi David, Thank you for taking the time to correct my mistakes and improve the clarity of the commit message. I appreciate your thoroughness and the helpful suggestions regarding the guidelines. Best regards, Leo -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38839 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #8 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Hi Leo, Not sure if I am going to give you a first FQA. But just view it as a learning experience :) Two points of attention: [1] Invalid Replacement Price => Seems not in harmony with our current 'case policy'. Only first word needs uc? [2] Validation + if (!/^[0-9.]+$/.test(replacementprice)) { + var isValid = /^[0-9.]*$/.test(value); This allows for a price like ... Shouldnt we have some common way to check a monetary value ? How does Koha do that elsewhere? Too bad that HTML(5) does not seem to have a uniform way for doing this.. Similar question for $("input[name='items.replacementprice']").on("input", function () { Should we check on input or on change btw? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38839 --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Actaully... reading Marcel's comment: If the validator works on this form, we do have something like a standard solution: See Bug 34169 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38839 Leo Stoyanov <leo.stoyanov@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #176285|0 |1 is obsolete| | --- Comment #10 from Leo Stoyanov <leo.stoyanov@bywatersolutions.com> --- Created attachment 176403 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176403&action=edit Bug 38839: Add validation for replacement price in item and batch modification forms Adds validation for the replacement price on the item input and batch modification forms. This new patch utilizes the standard jQuery "decimal" validator to check if monetary input is appropriatly formatted. Test plan: 1. Search for a record in the staff interface, select any record with an item, click "Edit", and select "Manage items". 2. Click "Actions" on the item in the table, select "Edit", and input an invalid "v - Cost, replacement price" (for example, 1,00). 3. Click "Save changes" and the form will submit but with no price shown in the table on the next page. 4. Apply the patch, update the CSS (yarn build) and restart everything (restart_all). 5. Repeat steps 1-3. A red error message will now appear to the right of the input field, notifying the user that only numbers and periods are allowed. The user will not be able to submit the form. 6. The same change was also made to the batch modification form under Cataloging > Batch item modification. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38839 --- Comment #12 from Leo Stoyanov <leo.stoyanov@bywatersolutions.com> --- Created attachment 176407 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176407&action=edit Bug 38839: Added "decimal" validation for replacement price in item and batch modification forms. Adds validation for the replacement price on the item input and batch modification forms. This new patch utilizes the standard jQuery "decimal" validator to check if monetary input is appropriatly formatted. Test plan: 1. Search for a record in the staff interface, select any record with an item, click "Edit", and select "Manage items". 2. Click "Actions" on the item in the table, select "Edit", and input an invalid "v - Cost, replacement price" (for example, 1,00). 3. Click "Save changes" and the form will submit but with no price shown in the table on the next page. 4. Apply the patch, update the CSS (yarn build) and restart everything (restart_all). 5. Repeat steps 1-3. A red error message will now appear to the right of the input field, notifying the user that only numbers and periods are allowed. The user will not be able to submit the form. 6. The same change was also made to the batch modification form under Cataloging > Batch item modification. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38839 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #176403|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38839 Leo Stoyanov <leo.stoyanov@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #14 from Leo Stoyanov <leo.stoyanov@bywatersolutions.com> --- Only the appropriate patch should apply now. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38839 Leo Stoyanov <leo.stoyanov@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38839 --- Comment #17 from Anneli Österman <anneli.osterman@koha-suomi.fi> --- I tested this again and it does not complain about the maximum length anymore. You can add amounts that are 999999.99 but if you add amount of 1 000 000 (one milloin or more) the save process crashes. DBIx::Class::Storage::DBI::_dbh_execute(): DBI Exception: DBD::mysql::st execute failed: Out of range value for column 'replacementprice' at row 1 at /kohadevbox/koha/Koha/Object.pm line 172 at /usr/share/perl5/DBIx/Class/Exception.pm line 77 I checked from the Koha schema that replacementprice field's type is DECIMAL and size is 8,2. I had to google what that means and if I understood correctly, the field accepts 6 digits before the . and two after it. So, it kind of works (milloin has 7 digits before the .) but should it give more descriptive error message? Of course, it is highly unlikely that someone adds that big of a replacement price but I think it should not just "crash". :) -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38839 --- Comment #19 from Anneli Österman <anneli.osterman@koha-suomi.fi> --- Katrin, yes, you can add as big number as you please (for example 900 000 000) and you can try to save it. But I guess the save crashes because the database does not accept the big/long number. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38839 Leo Stoyanov <leo.stoyanov@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38839 Magnus Enger <magnus@libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |magnus@libriotech.no --- Comment #22 from Magnus Enger <magnus@libriotech.no> --- I applied all three patches in KTD and did restart_all, but I can't really see any change in behaviour. Not sure if I am missing something. Also a question: Does this not take the CurrencyFormat syspref into consideration? It seems we always have to enter e.g. 10.00, but it will be displayed as 10,00 if CurrencyFormat = FR? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38839 --- Comment #24 from Magnus Enger <magnus@libriotech.no> --- (In reply to Anneli Österman from comment #23)

CurrencyFormat syspref applies only to what you see, not to how you enter data. Prices must be entered with a dot (10.00) regardless of what you have chosen to CurrencyFormat syspref. :)

Ah, that is as expected, then. Thanks. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38839 Magnus Enger <magnus@libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #25 from Magnus Enger <magnus@libriotech.no> --- $ git bz apply 38839 Bug 38839 - Add validation for replacement price in item input form 176407 - Bug 38839: Added "decimal" validation for replacement price in item and batch modification forms. 176839 - Bug 38839: (follow-up) Removed maxLength check for replacementPrice field. 177093 - Bug 38839: (follow-up) Added stricter validation for replacement price fields. Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 38839: Added "decimal" validation for replacement price in item and batch modification forms. Using index info to reconstruct a base tree... M Koha/UI/Form/Builder/Item.pm M koha-tmpl/intranet-tmpl/prog/en/includes/html_helpers.inc M koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/additem.tt M koha-tmpl/intranet-tmpl/prog/en/modules/tools/batchMod-edit.tt M t/db_dependent/Koha/UI/Form/Builder/Item.t Falling back to patching base and 3-way merge... Auto-merging t/db_dependent/Koha/UI/Form/Builder/Item.t Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/tools/batchMod-edit.tt CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/tools/batchMod-edit.tt Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/additem.tt CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/additem.tt Auto-merging koha-tmpl/intranet-tmpl/prog/en/includes/html_helpers.inc CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/includes/html_helpers.inc Auto-merging Koha/UI/Form/Builder/Item.pm CONFLICT (content): Merge conflict in Koha/UI/Form/Builder/Item.pm error: Failed to merge in the changes. Patch failed at 0001 Bug 38839: Added "decimal" validation for replacement price in item and batch modification forms. hint: Use 'git am --show-current-patch=diff' to see the failed patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-38839-Added-decimal-validation-for-replacement-SpLhcX.patch -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38839 Magnus Enger <magnus@libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #27 from Magnus Enger <magnus@libriotech.no> --- (In reply to Katrin Fischer from comment #26)

This is expected because of the tidy work we pushed. Please see auto_rebase.pl and the notes in channel "changelog" for more instructions.

Setting back to NSO, then. Sadly I don't have the time to look into it myself at the moment. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38839 Lari Taskula <lari.taskula@hypernova.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #176407|0 |1 is obsolete| | --- Comment #28 from Lari Taskula <lari.taskula@hypernova.fi> --- Created attachment 191261 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191261&action=edit Bug 38839: Added "decimal" validation for replacement price in item and batch modification forms. Adds validation for the replacement price on the item input and batch modification forms. This new patch utilizes the standard jQuery "decimal" validator to check if monetary input is appropriatly formatted. Test plan: 1. Search for a record in the staff interface, select any record with an item, click "Edit", and select "Manage items". 2. Click "Actions" on the item in the table, select "Edit", and input an invalid "v - Cost, replacement price" (for example, 1,00). 3. Click "Save changes" and the form will submit but with no price shown in the table on the next page. 4. Apply the patch, update the CSS (yarn build) and restart everything (restart_all). 5. Repeat steps 1-3. A red error message will now appear to the right of the input field, notifying the user that only numbers and periods are allowed. The user will not be able to submit the form. 6. The same change was also made to the batch modification form under Cataloging > Batch item modification. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38839 Lari Taskula <lari.taskula@hypernova.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #177093|0 |1 is obsolete| | --- Comment #30 from Lari Taskula <lari.taskula@hypernova.fi> --- Created attachment 191263 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191263&action=edit Bug 38839: (follow-up) Added stricter validation for replacement price fields. Adds validation for the replacement price on the item input and batch modification forms. This follow-up utilizes a new jQuery "replacement_price_decimal" validator for more strict validation; that is, there may only be up to 6 digits before the decimal and 2 digits after the decimal. Test plan: 1. Search for a record in the staff interface, select any record with an item, click "Edit", and select "Manage items". 2. Click "Actions" on the item in the table, select "Edit", and input an invalid "v - Cost, replacement price" (for example, 1,00). 3. Click "Save changes" and the form will submit but with no price shown in the table on the next page. 4. Apply the patch, update the CSS (yarn build), restart everything (restart_all), AND clear browser cache. 5. Repeat steps 1-3. A red error message will now appear to the right of the input field, notifying the user that only numbers and periods are allowed. The user will not be able to submit the form. 6. The same change was also made to the batch modification form under Cataloging > Batch item modification. -- You are receiving this mail because: You are watching all bug changes.