http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10887 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|3.12 |master CC| |katrin.fischer@bsz-bw.de --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Heather, good catch - it makes no sense there. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10887 --- Comment #2 from Abby <abbyrobertson.student@wegc.school.nz> --- Created attachment 35319 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35319&action=edit Bug 10887: Batch item deletion -- doesn't need Use default values section To test: 1. Go to Home > Tools > Batch item deletion 2. Notice that there is an unnecessary option for "use default values section" to "Populate fields with default values from default work" 3. Apply the patch. 4. Check that this section has disappeared. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10887 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Abby, the same page (bachMod.tt) is used for 2 tools: batch item modification and batch item delete. The 'default values' option only makes sense if you want to batch modify, but not if you want to batch delete. Your patch removes from both tools, what we need is some kind of condition, so it shows only for one, but not the other. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10887 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10887 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10887 Nick Clemens <nick@quecheelibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35934|0 |1 is obsolete| | --- Comment #5 from Nick Clemens <nick@quecheelibrary.org> --- Created attachment 36050 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36050&action=edit [SIGNED OFF] Bug 10887: Batch item deletion -- doesn't need Use default values section To test: 1. Go to Home > Tools > Batch item deletion 2. Notice that there is an unnecessary option for "use default values section" to "Populate fields with default values from default work" 3. Apply the patch. 4. Check that this section has disappeared. Signed-off-by: Nick <Nick@quechelibrary.org> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10887 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36050|0 |1 is obsolete| | --- Comment #6 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 36070 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36070&action=edit [PASSED QA] Bug 10887: Batch item deletion -- doesn't need Use default values section To test: 1. Go to Home > Tools > Batch item deletion 2. Notice that there is an unnecessary option for "use default values section" to "Populate fields with default values from default work" 3. Apply the patch. 4. Check that this section has disappeared. Signed-off-by: Nick <Nick@quechelibrary.org> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10887 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #8 from Chris Cormack <chris@bigballofwax.co.nz> --- Pushed to 3.18.x will be in 3.18.6 release -- You are receiving this mail because: You are watching all bug changes.