[Bug 33150] New: Add specific message for renewal too_soon situation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33150 Bug ID: 33150 Summary: Add specific message for renewal too_soon situation Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Self checkout Assignee: koha-bugs@lists.koha-community.org Reporter: andreas.jonsson@kreablo.se QA Contact: testopia@bugs.koha-community.org The message "No renewals allowed" is incorrect when it is too soon for renewal. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33150 --- Comment #1 from Andreas Jonsson <andreas.jonsson@kreablo.se> --- Created attachment 147792 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147792&action=edit Bug 33150 Add specific message for informing about too_soon for renewal. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33150 --- Comment #2 from Andreas Jonsson <andreas.jonsson@kreablo.se> --- Test plan for koha-testing-docker: - Make sure the system preference SCOAllowCheckin is set to "allow" - Go to Koha administration -> Circulation and fine rules - Edit the rule for all items and change "No renewal before" to 1 and save. - Check out an item to a borrower (for instance barcode 39999000000719 to the user koha with cardnumber 42). - Go to self checkout (http://localhost:8080/cgi-bin/koha/sco/sco-main.pl) - Log in as the user (koha/koha) - Verify that the error message in the Renew column is "This item cannot yet be renewed." -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33150 Andreas Jonsson <andreas.jonsson@kreablo.se> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33150 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |Laura.escamilla@bywatersolu | |tions.com --- Comment #3 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- (In reply to Andreas Jonsson from comment #2)
Test plan for koha-testing-docker:
- Make sure the system preference SCOAllowCheckin is set to "allow" - Go to Koha administration -> Circulation and fine rules - Edit the rule for all items and change "No renewal before" to 1 and save. - Check out an item to a borrower (for instance barcode 39999000000719 to the user koha with cardnumber 42). - Go to self checkout (http://localhost:8080/cgi-bin/koha/sco/sco-main.pl) - Log in as the user (koha/koha) - Verify that the error message in the Renew column is "This item cannot yet be renewed."
Works as expected! Signed-off-by: Laura Escamilla <laura.escamilla@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33150 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |andreas.jonsson@kreablo.se |ity.org | CC| |lucas@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33150 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33150 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33150 --- Comment #4 from Lucas Gass <lucas@bywatersolutions.com> --- Andreas, can you fix your commit message? * Commit title does not start with 'Bug XXXXX: ' - 022c622905 Other than that, this patch looks/works good. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33150 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33150 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33150 --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 148037 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148037&action=edit Bug 33150: Add specific message for informing about too_soon for renewal. The message "No renewals allowed" is incorrect when it is too soon for renewal, this patch adds a specific error message. To test: - Make sure the system preference SCOAllowCheckin is set to "allow" - Go to Koha administration -> Circulation and fine rules - Edit the rule for all items and change "No renewal before" to 1 and save. - Check out an item to a borrower (for instance barcode 39999000000719 to the user koha with cardnumber 42). - Go to self checkout (http://localhost:8080/cgi-bin/koha/sco/sco-main.pl) - Log in as the user (koha/koha) - Verify that the error message in the Renew column is "This item cannot yet be renewed." Signed-off-by: Laura Escamilla <laura.escamilla@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33150 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |katrin.fischer@bsz-bw.de |y.org | --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Andreas, I've fixed the mistake pointed out by Lucas, but I also fixed your commit message. Please make sure to always add a short problem description and the test plan into your commit message. See here: https://wiki.koha-community.org/wiki/Commit_messages Also added Laura's SO line. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33150 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #147792|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33150 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33150 --- Comment #7 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33150 Jacob O'Mara <jacob.omara@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00 |23.05.00,22.11.04 released in| | Status|Pushed to master |Pushed to stable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33150 --- Comment #8 from Jacob O'Mara <jacob.omara@ptfs-europe.com> --- Nice work, thanks everyone! Pushed to 22.11.x for the next release. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33150 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable Version(s)|23.05.00,22.11.04 |23.05.00,22.11.04,22.05.12 released in| | --- Comment #9 from Lucas Gass <lucas@bywatersolutions.com> --- Backported to 22.05.x for upcoming 22.05.12 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33150 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00,22.11.04,22.05.12 |23.05.00,22.11.04,22.05.12, released in| |21.11.20 CC| |arthur.suzuki@biblibre.com Status|Pushed to oldstable |Pushed to oldoldstable --- Comment #10 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- applied to 21.11.x for 21.11.20 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33150 wainuiwitikapark@catalyst.net.nz changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wainuiwitikapark@catalyst.n | |et.nz --- Comment #11 from wainuiwitikapark@catalyst.net.nz --- Not backported to 21.05.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org