[Bug 20559] New: Occurrences of loading-small.gif still exist
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20559 Bug ID: 20559 Summary: Occurrences of loading-small.gif still exist Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: jonathan.druart@bugs.koha-community.org QA Contact: testopia@bugs.koha-community.org Depends on: 16072 Bug 16072 removes it but there are some left: git grep -l loading-small.gif koha-tmpl/intranet-tmpl/prog/en/modules/tools/batch_record_modification.tt koha-tmpl/opac-tmpl/bootstrap/css/opac.css koha-tmpl/opac-tmpl/bootstrap/less/opac.less at least the tools template is relevant Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16072 [Bug 16072] Include only one small spinner gif in the staff client -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20559 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_18_05_candidate -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20559 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |master Component|Architecture, internals, |Templates |and plumbing | Assignee|koha-bugs@lists.koha-commun |oleonard@myacpl.org |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20559 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_18_05_candidate | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20559 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20559 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20559 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 76385 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76385&action=edit Bug 20559: Occurrences of loading-small.gif still exist This patch removes some leftover references to a file which no longer exists. In the OPAC, loading-small.gif was included in CSS which was never used. In the staff client, loading-small.gif should have been corrected to spinner-small.gif. To test, apply the patch and go to Tools -> Batch record modification. - Submit a batch of records to modify - In the table of titles which will be modified, click the 'Show MARC' button. - The modal preview window should show "Loading" and an animated spinner before the MARC record is loaded. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20559 --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 76386 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76386&action=edit Bug 20559: Compiled CSS This patch contains the compiled OPAC CSS. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20559 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20559 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #76385|0 |1 is obsolete| | Attachment #76386|0 |1 is obsolete| | --- Comment #3 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 76528 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76528&action=edit Bug 20559: Occurrences of loading-small.gif still exist This patch removes some leftover references to a file which no longer exists. In the OPAC, loading-small.gif was included in CSS which was never used. In the staff client, loading-small.gif should have been corrected to spinner-small.gif. To test, apply the patch and go to Tools -> Batch record modification. - Submit a batch of records to modify - In the table of titles which will be modified, click the 'Show MARC' button. - The modal preview window should show "Loading" and an animated spinner before the MARC record is loaded. Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20559 --- Comment #4 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 76529 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76529&action=edit Bug 20559: Compiled CSS This patch contains the compiled OPAC CSS. Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20559 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20559 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #76528|0 |1 is obsolete| | Attachment #76529|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 76543 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76543&action=edit Bug 20559: Occurrences of loading-small.gif still exist This patch removes some leftover references to a file which no longer exists. In the OPAC, loading-small.gif was included in CSS which was never used. In the staff client, loading-small.gif should have been corrected to spinner-small.gif. To test, apply the patch and go to Tools -> Batch record modification. - Submit a batch of records to modify - In the table of titles which will be modified, click the 'Show MARC' button. - The modal preview window should show "Loading" and an animated spinner before the MARC record is loaded. Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20559 --- Comment #6 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 76544 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76544&action=edit Bug 20559: Compiled CSS This patch contains the compiled OPAC CSS. Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20559 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |nick@bywatersolutions.com --- Comment #7 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20559 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Status|Pushed to Master |Pushed to Stable --- Comment #8 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Pushed to 18.05.x for 18.05.02 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20559 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #9 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Patch "Compiled CSS" does not apply on 17.11.x. Sorry I have never used this compilation. Must I run it or do we not back-port such patches ? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20559 --- Comment #10 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Fridolin SOMERS from comment #9)
Patch "Compiled CSS" does not apply on 17.11.x.
You should only apply the first one then regenerate the .css
Sorry I have never used this compilation.
There is a wiki page, search for "lessc"
Must I run it or do we not back-port such patches ?
You are the Rmaint ;) IMO it's "just" a loading icon, not really important. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20559 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED Resolution|--- |FIXED --- Comment #11 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- (In reply to Jonathan Druart from comment #10)
(In reply to Fridolin SOMERS from comment #9)
Patch "Compiled CSS" does not apply on 17.11.x.
You should only apply the first one then regenerate the .css
Sorry I have never used this compilation.
There is a wiki page, search for "lessc"
Must I run it or do we not back-port such patches ?
You are the Rmaint ;) IMO it's "just" a loading icon, not really important.
Ok thanks a lot. I prefer to skip this time since its minor. Not pushed to 17.11.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org