[Bug 39646] New: Send overdue notice to guarantor when guarantee has no email
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39646 Bug ID: 39646 Summary: Send overdue notice to guarantor when guarantee has no email Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Notices Assignee: koha-bugs@lists.koha-community.org Reporter: william.lavoie@inLibro.com QA Contact: testopia@bugs.koha-community.org If a guarantee does not have an email address registered to their account, then the script overdue_notices.pl doesn't send an email to their guarantors either. Additionally, if an email is sent, the letter should not be printed. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39646 --- Comment #1 from William Lavoie <william.lavoie@inLibro.com> --- Created attachment 180995 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180995&action=edit Bug 39646: Send overdue notice to guarantor when guarantee has no email Test plan: 1. Have a patron with no email address and an overdue item. 2. Add a guarantor to this patron. The guarantor must have an email address. 3. Run the script overdue_notices.pl. 4. On the staff interface, go to the guarantee patron > Notices. 5. Notice that only a print notice has been created. 6. Apply the patch. 7. Repeat steps 3 and 4. 8. Notice that an email message has been created. 9. Run the script process_message_queue.pl. 10. Verify that the email has been sent to the guarantor's address. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39646 William Lavoie <william.lavoie@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |william.lavoie@inLibro.com |ity.org | Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39646 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose@inlibr | |o.com, | |philippe.blouin@inlibro.com Assignee|william.lavoie@inLibro.com |hammat.wele@inlibro.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39646 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #2 from David Nind <david@davidnind.com> --- I had a go at testing, but it did not work for me. After the patch, there is no email overdue notice for the Guarantor (Mary) with the Guarentee's (Lisa's) overdue item. It just generated a print notice for the Guarantee (Lisa). This may be because I've never generated overdue notices before, and I'm not sure that I have set everything up correctly. Testing notes (using KTD): 1. Add a valid email address you have access to, to the KohaAdminEmailAddress system preference. 2. Update the details for a Guarantee patron: - Lisa Charles - Add Mary Burton as Guarantor - Patron messaging preferences: . Advance notice: 1 and Email selected 3. Update the details for a Guarantor patron: - Mary Burton - Primary email: set a valid email address you have access to - Patron messaging preferences: . Advance notice: 1 and Email selected 4. Set up sending emails using a Google account: 4.1 Set up an App password for your Google Account 4.2 Configure a new 'SMTP Server' under 'Administration > SMTP servers' using the following settings where `User name` = your Google email address and `Password` = your APP password, not your Google account password): - Host: smtp.gmail.com - Port: 587 - Timeout: 5 - SSL: STARTTLS - User name: GOOGLEACCOUNTUSER - Password: GOOGLEAPPPASSWORD - Set this server as default 4.3 Test that this is working by: - Sending a welcome message to Mary Burton - Process the message queue: misc/cronjobs/process_message_queue.pl 5. Set up overdue notice/status triggers: 5.1 Tools > Patrons and circulation > Overdue notice/status triggers 5.2 For default library and the Kid and Patron patron categories: - Delay: 1 - Letter: Overdue notice (ODUE) - Email: selected 6. Check out an item to Lisa Charles and make it overdue: 6.1 I used: Programming perl, 39999000011418 6.2 Search bar: select check out, then enter lisa and select 6.3 Enter the barcode: 39999000011418 6.4 Click the settings icon in the barcode field 6.5 Set specifify due date to the previous month 6.6 Click check out 6.7 Confirm checkout: Yes, check out (Y) 7. Check that an overdue notice will be triggered: misc/cronjobs/overdue_notices.pl --list-all -v 8. Run for real: misc/cronjobs/overdue_notices.pl -v -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39646 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |lucas@bywatersolutions.com --- Comment #3 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- [FAIL] misc/cronjobs/overdue_notices.pl FAIL tidiness File is not tidy, please run `perl misc/devel/tidy.pl misc/cronjobs/overdue_notices.pl` -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39646 Hammat wele <hammat.wele@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #180995|0 |1 is obsolete| | --- Comment #4 from Hammat wele <hammat.wele@inlibro.com> --- Created attachment 189502 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189502&action=edit Bug 39646: Send overdue notice to guarantor when guarantee has no email Test plan: 1. Have a patron with no email address and an overdue item. 2. Add a guarantor to this patron. The guarantor must have an email address. 3. Enable the system preference RedirectGuaranteeEmail. 4. Set up overdue notice/status triggers 4.1 Go to tools -> Overdue notice/status triggers 4.2 For Default library - Delay: 1 - Letter: Overdue notice (ODUE) - Email: selected 5. Run ./misc/cronjobs/overdue_notices.pl. 6. In the staff interface, go to the guarantee patron > Notices. ---> Notice that only a print notice has been created. 7. Apply the patch. 8. Repeat steps 4 and 5. ---> Notice that an email message has been created. You can also verify in SQL Select message_transport_type,to_address from message_queue where letter_code = 'ODUE' and borrowernumber = <borroewrnumber> 9. Run the script process_message_queue.pl. ---> Verify that the email has been sent to the guarantor's address. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39646 Hammat wele <hammat.wele@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39646 Bernard <bernard.scaife@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #189502|0 |1 is obsolete| | --- Comment #5 from Bernard <bernard.scaife@openfifth.co.uk> --- Created attachment 193580 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193580&action=edit Bug 39646: Send overdue notice to guarantor when guarantee has no email Test plan: 1. Have a patron with no email address and an overdue item. 2. Add a guarantor to this patron. The guarantor must have an email address. 3. Enable the system preference RedirectGuaranteeEmail. 4. Set up overdue notice/status triggers 4.1 Go to tools -> Overdue notice/status triggers 4.2 For Default library - Delay: 1 - Letter: Overdue notice (ODUE) - Email: selected 5. Run ./misc/cronjobs/overdue_notices.pl. 6. In the staff interface, go to the guarantee patron > Notices. ---> Notice that only a print notice has been created. 7. Apply the patch. 8. Repeat steps 4 and 5. ---> Notice that an email message has been created. You can also verify in SQL Select message_transport_type,to_address from message_queue where letter_code = 'ODUE' and borrowernumber = <borroewrnumber> 9. Run the script process_message_queue.pl. ---> Verify that the email has been sent to the guarantor's address. Signed-off-by: Bernard Scaife <bernard.scaife@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39646 --- Comment #6 from David Nind <david@davidnind.com> --- Hi Bernard. It looks like you've signed this off. If you could update the status to "Signed Off", then you will get the credit on the dashboard (https://dashboard.koha-community.org/leaderboard). 8-) David -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39646 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|minor |enhancement CC| |andrew@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39646 Blou <philippe.blouin@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org