[Bug 16504] New: All borrower attribute values for a given code deleted if that attribute has branch limits
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16504 Bug ID: 16504 Summary: All borrower attribute values for a given code deleted if that attribute has branch limits Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: critical Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: jweaver@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, jonathan.druart@bugs.koha-community.org, kyle.m.hall@gmail.com Bug 15163 introduced a regression for branch-limited patron attributes; when modifying a patron attribute with branch limits, all of the values for that attribute for every patron will be deleted due to a predecence mistake: WHERE b_branchcode = ? OR b_branchcode IS NULL AND borrowernumber = ? is parsed as: WHERE b_branchcode = ? OR (b_branchcode IS NULL AND borrowernumber = ?) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16504 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16504 --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 51469 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51469&action=edit Bug 16504: Add regression tests -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16504 --- Comment #2 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 51470 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51470&action=edit Bug 16504: (follow-up for bug 15163) Do not remove attributes of other patrons Simple patch for a silly error, this single line is going to fix a critical bug. If a patron attribute is limited to a library, all the values for that attributes for every patrons will be deleted. Test plan: Create a patron attribute limited to a library Set the the attribute for a patron Set the the attribute for another patron => Without this patch applied, the attribute's value for the first patron is deleted => With this patch applied, the 2 values exist in the DB after the second edition -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16504 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |jonathan.druart@bugs.koha-c |ity.org |ommunity.org Depends on| |15163 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15163 [Bug 15163] Patron attributes with branch limiits are not saved when invisible -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16504 Srdjan Jankovic <srdjan@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51469|0 |1 is obsolete| | --- Comment #3 from Srdjan Jankovic <srdjan@catalyst.net.nz> --- Created attachment 51508 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51508&action=edit [SIGNED-OFF] Bug 16504: Add regression tests Signed-off-by: Srdjan <srdjan@catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16504 Srdjan Jankovic <srdjan@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16504 Srdjan Jankovic <srdjan@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51470|0 |1 is obsolete| | --- Comment #4 from Srdjan Jankovic <srdjan@catalyst.net.nz> --- Created attachment 51509 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51509&action=edit [SIGNED-OFF] Bug 16504: (follow-up for bug 15163) Do not remove attributes of other patrons Simple patch for a silly error, this single line is going to fix a critical bug. If a patron attribute is limited to a library, all the values for that attributes for every patrons will be deleted. Test plan: Create a patron attribute limited to a library Set the the attribute for a patron Set the the attribute for another patron => Without this patch applied, the attribute's value for the first patron is deleted => With this patch applied, the 2 values exist in the DB after the second edition Signed-off-by: Srdjan <srdjan@catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16504 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16504 --- Comment #5 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 51923 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51923&action=edit Bug 16504: Add regression tests Signed-off-by: Srdjan <srdjan@catalyst.net.nz> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16504 --- Comment #6 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 51924 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51924&action=edit Bug 16504: (follow-up for bug 15163) Do not remove attributes of other patrons Simple patch for a silly error, this single line is going to fix a critical bug. If a patron attribute is limited to a library, all the values for that attributes for every patrons will be deleted. Test plan: Create a patron attribute limited to a library Set the the attribute for a patron Set the the attribute for another patron => Without this patch applied, the attribute's value for the first patron is deleted => With this patch applied, the 2 values exist in the DB after the second edition Signed-off-by: Srdjan <srdjan@catalyst.net.nz> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16504 --- Comment #7 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 51925 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51925&action=edit Bug 16504: [QA Follow-up] Make koha-qa happy with two newlines Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16504 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16504 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51508|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16504 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51509|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16504 --- Comment #8 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Thanks for regression test. Could have been little more explicit but is sufficient. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16504 --- Comment #9 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Marcel de Rooy from comment #8)
Thanks for regression test. Could have been little more explicit but is sufficient.
What do you mean by "more explicit"? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16504 --- Comment #10 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Jonathan Druart from comment #9)
(In reply to Marcel de Rooy from comment #8)
Thanks for regression test. Could have been little more explicit but is sufficient.
What do you mean by "more explicit"?
It is not directly obvious what happens here. And that you still have one record of a limited type for the other patron, that would be deleted without this patch. No big problem -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16504 Brendan Gallagher <brendan@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |brendan@bywatersolutions.co | |m Status|Passed QA |Pushed to Master --- Comment #11 from Brendan Gallagher <brendan@bywatersolutions.com> --- Pushed to Master - Should be in the November 2016 release. Thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16504 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic@tamil.fr --- Comment #12 from Frédéric Demians <frederic@tamil.fr> --- Pushed in 16.05. Will be in 16.05.01. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16504 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice@biblibre.com Status|Pushed to Master |Pushed to Stable --- Comment #13 from Julian Maurice <julian.maurice@biblibre.com> --- Patches pushed to 3.22.x, will be in 3.22.8 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org