[Bug 18307] New: Branchname is no more displayed in subscription tab wiew
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18307 Bug ID: 18307 Summary: Branchname is no more displayed in subscription tab wiew Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: jean-manuel.broust@univ-lyon2.fr QA Contact: testopia@bugs.koha-community.org Created attachment 61354 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61354&action=edit library name not displayed in opac detail subscription tab The library name is no more displayed in opac-detail.pl's subscription tab. See screenshot attached. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18307 jmbroust <jean-manuel.broust@univ-lyon2.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18307 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron@veron.ch --- Comment #1 from Marc Véron <veron@veron.ch> --- I can reproduce the problem on current master. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18307 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |veron@veron.ch Severity|normal |minor -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18307 --- Comment #2 from Marc Véron <veron@veron.ch> --- Created attachment 61389 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61389&action=edit Bug 18307 - Branchname is no more displayed in subscription tab wiew This patch restores the branchname in OPAC subscription detail view. Additionally, it adds the subscriptons count to the tab title to make it consistent with the other tab titles. To test: - Search a subscription in OPAC catalog - Go to Subscriptions tab (see screenshot in initial comment) - Verify that library name does not display - Apply patch - Verify that library name displays properly in Subscriptons tab - Verify that the tab title displays the subscriptions count e.g.: Subscriptions (2) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18307 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18307 Claire Gravely <claire_gravely@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18307 Claire Gravely <claire_gravely@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61389|0 |1 is obsolete| | --- Comment #3 from Claire Gravely <claire_gravely@hotmail.com> --- Created attachment 61441 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61441&action=edit Bug 18307 - Branchname is no more displayed in subscription tab wiew This patch restores the branchname in OPAC subscription detail view. Additionally, it adds the subscriptons count to the tab title to make it consistent with the other tab titles. To test: - Search a subscription in OPAC catalog - Go to Subscriptions tab (see screenshot in initial comment) - Verify that library name does not display - Apply patch - Verify that library name displays properly in Subscriptons tab - Verify that the tab title displays the subscriptions count e.g.: Subscriptions (2) Signed-off-by: Claire Gravely <claire_gravely@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18307 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org Depends on| |15758 --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Caused by bug 15758 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15758 [Bug 15758] Move the C4::Branch related code to Koha::Libraries - part 4 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18307 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18307 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61441|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 61459 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61459&action=edit Bug 18307 - Branchname is no more displayed in subscription tab wiew This patch restores the branchname in OPAC subscription detail view. Additionally, it adds the subscriptons count to the tab title to make it consistent with the other tab titles. To test: - Search a subscription in OPAC catalog - Go to Subscriptions tab (see screenshot in initial comment) - Verify that library name does not display - Apply patch - Verify that library name displays properly in Subscriptons tab - Verify that the tab title displays the subscriptions count e.g.: Subscriptions (2) Signed-off-by: Claire Gravely <claire_gravely@hotmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18307 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |17946 --- Comment #6 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- I made it depend on bug 17946. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17946 [Bug 17946] Show number of subscriptions on tab in OPAC record details -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18307 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=18350 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18307 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com Summary|Branchname is no more |Branchname is no longer |displayed in subscription |displayed in subscription |tab wiew |tab view -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18307 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #7 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to master for 17.05, thanks Marc! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18307 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Status|Pushed to Master |Pushed to Stable --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- This patch has been pushed to 16.11.x and will be in 16.11.07. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18307 Bug 18307 depends on bug 17946, which changed state. Bug 17946 Summary: Show number of subscriptions on tab in OPAC record details https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17946 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18307 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj@kohaaloha.com --- Comment #9 from Mason James <mtj@kohaaloha.com> --- (In reply to Katrin Fischer from comment #8)
This patch has been pushed to 16.11.x and will be in 16.11.07.
Blocked by Enhancement, skipping for 16.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18307 --- Comment #10 from Mason James <mtj@kohaaloha.com> --- (In reply to Mason James from comment #9)
(In reply to Katrin Fischer from comment #8)
This patch has been pushed to 16.11.x and will be in 16.11.07.
Blocked by Enhancement, skipping for 16.05.x
hi Katrin, 16.11.x may need patch BZ-17946 now -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18307 --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Mason James from comment #10)
(In reply to Mason James from comment #9)
(In reply to Katrin Fischer from comment #8)
This patch has been pushed to 16.11.x and will be in 16.11.07.
Blocked by Enhancement, skipping for 16.05.x
hi Katrin, 16.11.x may need patch BZ-17946 now
Hi Mason, I checked, there is a dependency noted, but the patch works without bug 17946 which is marked enhancement. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org