[Bug 29375] New: Excessive regular expressions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29375 Bug ID: 29375 Summary: Excessive regular expressions Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Lists Assignee: koha-bugs@lists.koha-community.org Reporter: andriiverem@gmail.com QA Contact: testopia@bugs.koha-community.org CC: m.de.rooy@rijksmuseum.nl Depends on: 29114 There are several places throughout the application where regular expressions are used for the whitespaces trimming together with the normalization function C4::Circulation::barcodedecode. It is an overkilling and better to remove those regular expressions, because C4::Circulation::barcodedecode trimming whitespaces by itself. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29114 [Bug 29114] Can not add barcodes with whitespaces at the beginning to the list -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29375 Andrii Veremeienko <andriiverem@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|29114 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29114 [Bug 29114] Can not add barcodes with whitespaces at the beginning to the list -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29375 --- Comment #1 from Andrii Veremeienko <andriiverem@gmail.com> --- Created attachment 127107 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127107&action=edit Bug 29375: Excessive regular expressions There are several places throughout the application where regular expressions are used for the whitespaces trimming together with the normalization function C4::Circulation::barcodedecode. Solution was to remove those regular expressions, because C4::Circulation::barcodedecode trimming whitespaces by itself. How to test: 1. Go to the Koha code base; 2. Do global search by "barcodedecode" key word; 3. Observe that there are several places where barcodedecode used with regular expression together; 4. Apply the patch; 5. Repeat steps 1, 2; 6. Observe that there are no regular expressions used together with barcodedecode; -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29375 Andrii Veremeienko <andriiverem@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |andriiverem@gmail.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29375 Andrii Veremeienko <andriiverem@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29375 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Excessive regular |Excessive regular |expressions |expressions for treating | |barcodes -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29375 Joonas Kylmälä <joonas.kylmala@iki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |joonas.kylmala@iki.fi --- Comment #2 from Joonas Kylmälä <joonas.kylmala@iki.fi> --- Depending on the itemBarcodeInputFilter setting it doesn't do that. This would basically revert the fixes made in bug 25341. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org