[Bug 26434] New: Plugin dirs duplicates in @INC with plack
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26434 Bug ID: 26434 Summary: Plugin dirs duplicates in @INC with plack Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: fridolin.somers@biblibre.com QA Contact: testopia@bugs.koha-community.org Plugin dirs defined in koha-conf.xml are added to @INC in order to compile perl code. Looks like with plack those dirs are added several times. This may lead to an error "INCLUDE_PATH exceeds 64 directories". -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26434 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |fridolin.somers@biblibre.co |ity.org |m Status|NEW |ASSIGNED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26434 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26434 --- Comment #1 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Created attachment 109946 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109946&action=edit Bug 26434: Fix plugin dirs addition to @INC Plugin dirs defined in koha-conf.xml are added to @INC in order to compile perl code. Looks like with plack those dirs are added several times. This may lead to an error "INCLUDE_PATH exceeds 64 directories". This bug was identified with Carrousel plugin : https://inlibro.com/instructions-carrousel/ Test plan : 1) Enable plack and plugins 2) Look at page about.pl : @INC contains one plugin dir 'var/lib/plugins' 3) Install plugin KitchenSink : https://github.com/bywatersolutions/koha-plugin-kitchen-sink 4) Dont apply patch 5) Use configure on KitchenSink 6) Look at page about.pl : @INC contains server plugin dir 'var/lib/plugins' 7) Apply patch and restart plack 8) Use configure on KitchenSink 9) Look at page about.pl : @INC contains one plugin dir 'var/lib/plugins' -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26434 --- Comment #2 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Strangely we also see in @INC the template dirs : koha-tmpl/opac-tmpl and koha-tmpl/intranet-tmpl The duplicates like plugin dirs thats causes the error. With patch thoses dirs aren't duplicate anymore. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26434 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au --- Comment #3 from David Cook <dcook@prosentient.com.au> --- I want to say that I've seen these duplicates as well although I'd have to look again. I'm not sure about this solution though. I think this could use some more investigation. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26434 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com --- Comment #4 from Kyle M Hall <kyle@bywatersolutions.com> --- (In reply to Fridolin SOMERS from comment #2)
Strangely we also see in @INC the template dirs : koha-tmpl/opac-tmpl and koha-tmpl/intranet-tmpl The duplicates like plugin dirs thats causes the error. With patch thoses dirs aren't duplicate anymore.
Considering the way TT finds plugins and include files, I'm not surprised it would push template directories onto @INC. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26434 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26434 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #109946|0 |1 is obsolete| | --- Comment #5 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 110056 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110056&action=edit Bug 26434: Fix plugin dirs addition to @INC Plugin dirs defined in koha-conf.xml are added to @INC in order to compile perl code. Looks like with plack those dirs are added several times. This may lead to an error "INCLUDE_PATH exceeds 64 directories". This bug was identified with Carrousel plugin : https://inlibro.com/instructions-carrousel/ Test plan : 1) Enable plack and plugins 2) Look at page about.pl : @INC contains one plugin dir 'var/lib/plugins' 3) Install plugin KitchenSink : https://github.com/bywatersolutions/koha-plugin-kitchen-sink 4) Dont apply patch 5) Use configure on KitchenSink 6) Look at page about.pl : @INC contains server plugin dir 'var/lib/plugins' 7) Apply patch and restart plack 8) Use configure on KitchenSink 9) Look at page about.pl : @INC contains one plugin dir 'var/lib/plugins' Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26434 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #110056|0 |1 is obsolete| | --- Comment #6 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 110255 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110255&action=edit Bug 26434: Fix plugin dirs addition to @INC Plugin dirs defined in koha-conf.xml are added to @INC in order to compile perl code. Looks like with plack those dirs are added several times. This may lead to an error "INCLUDE_PATH exceeds 64 directories". This bug was identified with Carrousel plugin : https://inlibro.com/instructions-carrousel/ Test plan : 1) Enable plack and plugins 2) Look at page about.pl : @INC contains one plugin dir 'var/lib/plugins' 3) Install plugin KitchenSink : https://github.com/bywatersolutions/koha-plugin-kitchen-sink 4) Dont apply patch 5) Use configure on KitchenSink 6) Look at page about.pl : @INC contains server plugin dir 'var/lib/plugins' 7) Apply patch and restart plack 8) Use configure on KitchenSink 9) Look at page about.pl : @INC contains one plugin dir 'var/lib/plugins' Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26434 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Status|Signed Off |Passed QA --- Comment #7 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Simple clean fix, no regresssions, no QA failures. Passing QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26434 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26434 --- Comment #8 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26434 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|20.11.00 |20.11.00, 20.05.05 released in| | Status|Pushed to master |Pushed to stable CC| |lucas@bywatersolutions.com --- Comment #9 from Lucas Gass <lucas@bywatersolutions.com> --- backported to 20.05.x for 20.05.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26434 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|20.11.00, 20.05.05 |20.11.00, 20.05.05, released in| |19.11.11 Status|Pushed to stable |Pushed to oldstable CC| |aleisha@catalyst.net.nz --- Comment #10 from Aleisha Amohia <aleisha@catalyst.net.nz> --- backported to 19.11.x for 19.11.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26434 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |Pushed to oldoldstable CC| |victor@tuxayo.net Version(s)|20.11.00, 20.05.05, |20.11.00, 20.05.05, released in|19.11.11 |19.11.11, 19.05.16 --- Comment #11 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Backported to 19.05.x branch for 19.05.16 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26434 --- Comment #12 from Mason James <mtj@kohaaloha.com> --- Created attachment 112577 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112577&action=edit Bug 26434: add Array::Utils module [19.05] -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26434 --- Comment #13 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Backport to 19.05.x fixed, thanks James! :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26434 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |26849 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26849 [Bug 26849] Fix Array::Utils dependency in cpanfile -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26434 --- Comment #14 from David Cook <dcook@prosentient.com.au> --- The past couple days after upgrading the coverflow plugin I've found the coverflow plugin has been unable to find the report.tt because the @INC has grown beyond 64 entries. This time it's full of the following repeating over and over again: '/usr/share/koha/lib', '/usr/share/koha/installer', Now I'm sure that I've seen this before... but maybe I was thinking of this bug... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26434 --- Comment #15 from David Cook <dcook@prosentient.com.au> --- (In reply to David Cook from comment #14)
The past couple days after upgrading the coverflow plugin I've found the coverflow plugin has been unable to find the report.tt because the @INC has grown beyond 64 entries.
This time it's full of the following repeating over and over again: '/usr/share/koha/lib', '/usr/share/koha/installer',
Now I'm sure that I've seen this before... but maybe I was thinking of this bug...
Sorry my bad it's these two: /usr/share/koha/installer /usr/share/koha/lib/installer And the only thing that adds those appears to be the following: debian/scripts/koha-z3950-responder debian/scripts/koha-plack And yep it's a koha-plack bug. Again, I'm sure that I fixed this in the past... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26434 --- Comment #16 from David Cook <dcook@prosentient.com.au> --- (In reply to David Cook from comment #15)
(In reply to David Cook from comment #14)
The past couple days after upgrading the coverflow plugin I've found the coverflow plugin has been unable to find the report.tt because the @INC has grown beyond 64 entries.
This time it's full of the following repeating over and over again: '/usr/share/koha/lib', '/usr/share/koha/installer',
Now I'm sure that I've seen this before... but maybe I was thinking of this bug...
Sorry my bad it's these two: /usr/share/koha/installer /usr/share/koha/lib/installer
And the only thing that adds those appears to be the following: debian/scripts/koha-z3950-responder debian/scripts/koha-plack
And yep it's a koha-plack bug.
Again, I'm sure that I fixed this in the past...
Yup bug 25778 I'll continue my rambles there... -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org