https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41920 Kyle M Hall (khall) <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |41921 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41921 [Bug 41921] Add ability to run reports as background jobs -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41920 --- Comment #1 from Kyle M Hall (khall) <kyle@bywatersolutions.com> --- Created attachment 193930 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193930&action=edit Bug 41920: Limit number of concurrent reports that can be run simultaneously for an instance of Koha Building on bug 41918, it would be good to limit the number of reports a given user can run at a time. This control should be conf file based as it is tied to the server resources provided by whoever administers the server. Test Plan: 1) Set total_running_reports_per_user_limit to 3 in your koha-conf.xml 2) Create 3 long running reports like: SELECT COUNT(*) FROM items i1 JOIN items i2 JOIN items i3 JOIN items i4 JOIN items i5 JOIN items i6 3) Run each report in turn by opening a new tab, browsing to the reports module, and choosing to run that report 5) Note the first two continue to run, but the last one gives an error that you have too many reports running simultaneously! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41920 Kyle M Hall (khall) <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41920 Kyle M Hall (khall) <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41920 --- Comment #3 from Alex Carver [Acerock7] <alex@rcls.org> --- When adding the <total_running_reports_per_instance_limit> variable into the config file and trying to run a report I get a long page of debugging info beginning with: Can't locate object method "instanceenv" via package "C4::Context" at /kohadevbox/koha/reports/guided_reports.pl line 819 in (eval) at /kohadevbox/koha/reports/guided_reports.pl line 819 816: # Determine if the Koha instance is running too many reports in total 817: my @total_running_for_instance_report_ids; 818: my $total_running_reports_per_instance_limit = C4::Context->config('total_running_reports_per_instance_limit'); 819: if ( $total_running_reports_per_instance_limit && C4::Context->instanceenv ) { 820: my $instance_id = C4::Context->instanceenv ? C4::Context->instanceenv->{number} : undef; 821: @total_running_for_instance_report_ids = Koha::Reports->running(); 822: } -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41920 Kyle M Hall (khall) <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #193932|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41920 --- Comment #5 from Kyle M Hall (khall) <kyle@bywatersolutions.com> --- (In reply to Alex Carver [Acerock7] from comment #3)

When adding the <total_running_reports_per_instance_limit> variable into the config file and trying to run a report I get a long page of debugging info beginning with:

Can't locate object method "instanceenv" via package "C4::Context" at /kohadevbox/koha/reports/guided_reports.pl line 819

Ack! looks like I messed up a find and replace. This should be fixed in this updated patch! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41920 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #6 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- This doesn't seem to be functioning as intended. When I set: '<total_running_reports_per_instance_limit>1</total_running_reports_per_instance_limit>' I am unable to run _any_ reports. If I increase the limit to 2, I can run as many reports as I like. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41920 Kyle M Hall (khall) <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #198630|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41920 --- Comment #8 from Kyle M Hall (khall) <kyle@bywatersolutions.com> --- (In reply to Andrew Fuerste-Henry from comment #6)

This doesn't seem to be functioning as intended. When I set:

'<total_running_reports_per_instance_limit>1</ total_running_reports_per_instance_limit>'

I am unable to run _any_ reports. If I increase the limit to 2, I can run as many reports as I like.

Fixed! Koha::Reports::Running wasn't returning a list in list context. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41920 Alex Carver [Acerock7] <alex@rcls.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41920 --- Comment #9 from Alex Carver [Acerock7] <alex@rcls.org> --- Created attachment 199390 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=199390&action=edit Bug 41920: Limit number of concurrent reports that can be run simultaneously for an instance of Koha As a continuation of bug 41919, we should limit the total number of simultaneous reports that can be run at a time. Test Plan: 1) Set total_running_reports_per_instance_limit to 2 in your koha-conf.xml 2) Create 3 long running reports like: SELECT COUNT(*) FROM items i1 JOIN items i2 JOIN items i3 JOIN items i4 JOIN items i5 JOIN items i6 3) Run each report in turn by opening a new tab, browsing to the reports module, and choosing to run that report 5) Note the first two continue to run, but the last one gives an error that you have too many reports running simultaneously! Signed-off-by: Alex Carver [Acerock7] <alex@rcls.org> -- You are receiving this mail because: You are watching all bug changes.