[Bug 22008] New: Missing constraints on accountlines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22008 Bug ID: 22008 Summary: Missing constraints on accountlines Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Database Assignee: koha-bugs@lists.koha-community.org Reporter: martin.renvoize@ptfs-europe.com QA Contact: testopia@bugs.koha-community.org The accountlines table optionally references a number of tables, but the foreign key fields are unconstrained. We should add the constraints for: * issue_id (referencing issues) * manager_id (referencing borrowers) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22008 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |14825 Depends on| |21065 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14825 [Bug 14825] Accounts Rewrite Omnibus https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21065 [Bug 21065] Data in account_offsets and accountlines is deleted with the patron leaving gaps in financial reports -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22008 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Target Milestone|--- |19.05 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22008 --- Comment #1 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 83278 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83278&action=edit Bug 22008: Add missing constraints to accountlines -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22008 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #83278|0 |1 is obsolete| | --- Comment #2 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 83280 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83280&action=edit Bug 22008: Add missing constraints to accountlines Add constraints for manager_id referencing the borrowers table and issue_id referencing the issues table and update the itemnumber constraint from `ON UPDATE SET NULL` to `ON UPDATE CASCADE` -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22008 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22008 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |martin.renvoize@ptfs-europe |ity.org |.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22008 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org, | |tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22008 --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Could you provide tests? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22008 --- Comment #4 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Good point.. tests for this hadn't even crossed my mind. I'll have a ponder as to what they should be. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22008 --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Martin Renvoize from comment #4)
Good point.. tests for this hadn't even crossed my mind. I'll have a ponder as to what they should be.
See bug 21065 :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22008 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #83280|0 |1 is obsolete| | --- Comment #6 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 83460 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83460&action=edit Bug 22008: Add missing constraints to accountlines Add constraints for manager_id referencing the borrowers table and issue_id referencing the issues table and update the itemnumber constraint from `ON UPDATE SET NULL` to `ON UPDATE CASCADE` -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22008 --- Comment #7 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 83461 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83461&action=edit Bug 22008: Add tests for new constraints -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22008 --- Comment #8 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 83462 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83462&action=edit Bug 22008: DBIC Schema Updates -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22008 --- Comment #9 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Tests added, rebased now that 21065 is in master and DBIC Schema Updates patch added for easy testing. Man I wish we could just use the relations the dbic gives us for free once we have proper constraints :( -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22008 --- Comment #10 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Oh.. I also made the DB update more reliably idempotent (so this can be easily backported if we want) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22008 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22008 Maryse Simard <maryse.simard@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |maryse.simard@inlibro.com --- Comment #11 from Maryse Simard <maryse.simard@inlibro.com> --- Patch doesn't apply Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 22008: Add missing constraints to accountlines Using index info to reconstruct a base tree... M installer/data/mysql/kohastructure.sql Falling back to patching base and 3-way merge... Auto-merging installer/data/mysql/kohastructure.sql CONFLICT (content): Merge conflict in installer/data/mysql/kohastructure.sql error: Failed to merge in the changes. Patch failed at 0001 Bug 22008: Add missing constraints to accountlines -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22008 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #83460|0 |1 is obsolete| | --- Comment #12 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 85267 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85267&action=edit Bug 22008: Add missing constraints to accountlines Add constraints for manager_id referencing the borrowers table and issue_id referencing the issues table and update the itemnumber constraint from `ON UPDATE SET NULL` to `ON UPDATE CASCADE` -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22008 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #83461|0 |1 is obsolete| | --- Comment #13 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 85268 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85268&action=edit Bug 22008: Add tests for new constraints -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22008 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #83462|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22008 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22008 --- Comment #14 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- To test this you'll need to run the dbic schema updates script. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22008 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |7811 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7811 [Bug 7811] borrowers.borrowernumber should be a foreign key for 8 tables -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22008 Bug 22008 depends on bug 21065, which changed state. Bug 21065 Summary: Data in account_offsets and accountlines is deleted with the patron leaving gaps in financial reports https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21065 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22008 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=22368 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22008 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85268|0 |1 is obsolete| | --- Comment #15 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 85613 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85613&action=edit Bug 22008: Add tests for new constraints -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22008 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85267|0 |1 is obsolete| | --- Comment #16 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 85614 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85614&action=edit Bug 22008: Add missing constraints to accountlines Add constraints for manager_id referencing the borrowers table and issue_id referencing the issues table and update the itemnumber constraint from `ON UPDATE SET NULL` to `ON UPDATE CASCADE` -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22008 --- Comment #17 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Rebased and switch to `foreign_key_exists` method. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22008 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Keywords| |Academy -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22008 --- Comment #18 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Comment on attachment 85614 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85614 Bug 22008: Add missing constraints to accountlines Review of attachment 85614: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=22008&attachment=85614) ----------------------------------------------------------------- Replace NOT IN with LEFT JOIN... NOT NULL? ::: installer/data/mysql/atomicupdate/bug_22008.perl @@ +14,5 @@
+ $dbh->do("ALTER TABLE accountlines ADD CONSTRAINT `accountlines_ibfk_issues` FOREIGN KEY (`issue_id`) REFERENCES `issues` (`issue_id`) ON DELETE SET NULL ON UPDATE CASCADE"); + } + + # Rename accountlines_ibfk_2 to accountlines_ibfk_items + if( foreign_key_exists( 'accountlines', 'accountlines_ibfk_2' ) ) {
You should test for accountlines_ibfk_items as well. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22008 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |In Discussion --- Comment #19 from Kyle M Hall <kyle@bywatersolutions.com> --- Won't this cause all accountline issue_ids to be nullified on checkin? I think that's a showstopper for that constraint. One solution would be to have issue_id and old_issue_id columns in the accountlines, and move the issue_id between them at checkin time. Also, Bug 19489 relies on issue_id not being nullified at checkin time. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22008 --- Comment #20 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Hmm, you're right Kyle. I think the relationship should probably the in the opposite direction in that case.. with the issues and old_issues tables each having an accountline_id field referencing account lines rather than the current case. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22008 --- Comment #21 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- ack.. ignore that.. we can't go that way around either as it's a one issue may refer to many accountlines... i -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22008 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Missing constraints on |accountlines.manager_id is |accountlines |missing a foreign key | |constraint -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22008 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85613|0 |1 is obsolete| | --- Comment #22 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 85767 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85767&action=edit Bug 22008: Add tests for new constraints -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22008 --- Comment #23 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 85768 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85768&action=edit Bug 22008: Add missing constraints -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22008 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |22421 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22421 [Bug 22421] accountlines.issue_id is missing a foreign key constraint -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22008 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85614|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22008 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff --- Comment #24 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Reduced the scope here to just add the constraint for manager_id. Also converted from NOT IN to LEFT JOIN query. New bug created for the more complex case involving issue_id. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22008 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #25 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- There is still a bit more to this: CONSTRAINT `accountlines_ibfk_items` FOREIGN KEY (`itemnumber`) REFERENCES `items` (`itemnumber`) ON DELETE SET NULL ON UPDATE CASCADE, I wonder if the same applies here as for issues. (items > deleteditems). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22008 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|14825 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14825 [Bug 14825] Accounts Rewrite Omnibus -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22008 --- Comment #26 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Erm, the item constraint isn't added here, it's one of the few that was already in place. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22008 --- Comment #27 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Argh, sory, I misread the diff. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22008 Hayley Mapley <hayleymapley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hayleymapley@catalyst.net.n | |z --- Comment #28 from Hayley Mapley <hayleymapley@catalyst.net.nz> --- Is there a test plan for this? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22008 --- Comment #29 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- The test plan is basically to run the included unit tests. They test for adding a non-existant user as the manager for an accountline, and they then try deleting a user whose attached to an accountline as a manager and test that the accountline isn't deleted. You could replicate all that manually if you wanted to take the belt and braces approach. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22008 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22008 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85767|0 |1 is obsolete| | Attachment #85768|0 |1 is obsolete| | --- Comment #30 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 86162 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86162&action=edit Bug 22008: Add tests for new constraints Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22008 --- Comment #31 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 86163 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86163&action=edit Bug 22008: Add missing constraints Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22008 --- Comment #32 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 86164 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86164&action=edit Bug 22008: Fixes to make unit tests pass Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22008 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |josef.moravec@gmail.com |y.org | CC| |josef.moravec@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22008 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22008 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86162|0 |1 is obsolete| | Attachment #86163|0 |1 is obsolete| | Attachment #86164|0 |1 is obsolete| | --- Comment #33 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 86659 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86659&action=edit Bug 22008: Add tests for new constraints Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22008 --- Comment #34 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 86660 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86660&action=edit Bug 22008: Add missing constraints Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22008 --- Comment #35 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 86661 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86661&action=edit Bug 22008: Fixes to make unit tests pass Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22008 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |nick@bywatersolutions.com --- Comment #36 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22008 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |additional_work_needed --- Comment #37 from Nick Clemens <nick@bywatersolutions.com> --- There is an issue here. Currently we use 0 to indicate an action performed by command line scripts (userenv is undef, default to 0) With this patch we must have a real borrowernumber. If we simply default to 'NULL' we will no longer be able to differentiate fines from command line from those of deleted users -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22008 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |22577 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22577 [Bug 22577] Cronjobs (and other scripts) should be attributed to a 'real' user -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22008 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=22577 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22008 --- Comment #38 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 86994 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86994&action=edit Bug 22008: Fix failing tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22008 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86994|0 |1 is obsolete| | --- Comment #39 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 86995 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86995&action=edit Bug 22008: Fix failing tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22008 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |22593 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22593 [Bug 22593] Scripts dealing with accountlines need updating for bug 22008 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22008 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|22577 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22577 [Bug 22577] Cronjobs (and other scripts) should be attributed to a 'real' user -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22008 --- Comment #40 from Nick Clemens <nick@bywatersolutions.com> --- (In reply to Nick Clemens from comment #39)
Created attachment 86995 [details] [review] Bug 22008: Fix failing tests
Followup pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22008 --- Comment #41 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 87066 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87066&action=edit Bug 22008: (follow-up) Additional test fix and fix typo -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22008 --- Comment #42 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 87072 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87072&action=edit Bug 22008: (follow-up) Additional fix for bad test Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22008 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|22421 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22421 [Bug 22421] accountlines.issue_id is missing a foreign key constraint -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22008 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |22600 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22600 [Bug 22600] We should add an 'interface' field to accountlines -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22008 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|22600 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22600 [Bug 22600] We should add an 'interface' field to accountlines -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22008 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to Master |RESOLVED --- Comment #43 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Enhancement will not be backported to 18.11.x series. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22008 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|Academy, | |additional_work_needed | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22008 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |26332 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26332 [Bug 26332] Koha::Account::pay incorrectly defaults to '0' for manager_id -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22008 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |26506 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26506 [Bug 26506] Koha::Account::pay will fail if $userenv is not set -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22008 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |24658 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24658 [Bug 24658] Deleting items with fines does not update itemnumber in accountlines to NULL causing ISE -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org