[Bug 37684] New: Direct link to expired news are broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37684 Bug ID: 37684 Summary: Direct link to expired news are broken Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: baptiste.wojtkowski@biblibre.com QA Contact: testopia@bugs.koha-community.org When using a direct link to a news (koha.url/cgi-bin/koha/opac-main.pl?news_id=XXX), the link is broken if the news is expired. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37684 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |regression -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37684 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=37629 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37684 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=37628 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37684 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |baptiste.wojtkowski@biblibr | |e.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37684 --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I think there was some discussion about accessibility of news once they have expired. Might be worth doing a bugzilla search first. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37684 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37684 --- Comment #2 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- Created attachment 170495 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170495&action=edit Bug 37684: Direct link to expired news are broken When using a direct link to a news (koha.url/cgi-bin/koha/opac-main.pl?news_id=XXX), the link is broken if the news is expired. Formerly, a using AdditionalContent->get( id => "my_news_id") on an expired news was returning a news, and calling get without id was returning all news but the expired ones. This patch adds tests to check this behaviour by adding one expired news and performing following new tests: 1 - It may not be returned by AdditionalContent.get() 2 - It must be returned by AdditionalContent.get() using its id This patch fixes the behaviour by addind the new behaviour or AdditionalContent.get: 1 - Any news must be returned by AdditionalContent.get() using its id; TEST PLAN: 1 - Apply patch 2 - Remove the changes made to Koha/AdditionalContents.pm 3 - Run tests -> one test must fail 4 - Create a news with a expired expiration date, notice the id of the news in the url of the modification panel 5 - Go to "opac.url/cgi-bin/koha/opac-main.pl?news_id=MY_ID" -> notice it does not work 6 - Reapply the whole patch 7 - Run test -> all test must pass 8 - Go to "opac.url/cgi-bin/koha/opac-main.pl?news_id=MY_ID" -> notice it does work now -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37684 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Direct link to expired news |Direct links to expired |are broken |news are broken -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37684 --- Comment #3 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- (In reply to Katrin Fischer from comment #1)
I think there was some discussion about accessibility of news once they have expired. Might be worth doing a bugzilla search first.
Hi ! I do not think this behaviour is done on purpose. Formerly, direct access to news was working. In BZ 31383 this link has been totally broken, it has been partially restablished with BZ 37629 but we did not test on expired news.
From what I see in discussions, expired news are hidden by default in the intranet list of news -> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27766 But this is the lonely point is of our concerns when searching for "news" and "expir"
Finally, when picking an expiration date, there is still a tooltip telling the user the link will still be available once expired -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37684 --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Baptiste, happy to be wrong. Thanks for figuring that all out! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37684 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |31383 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31383 [Bug 31383] Additional contents: We need a parent and child table -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37684 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|31383 |37629 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31383 [Bug 31383] Additional contents: We need a parent and child table https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37629 [Bug 37629] Link to news are broken -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37684 Olivier V <ovezina@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #170495|0 |1 is obsolete| | --- Comment #5 from Olivier V <ovezina@inlibro.com> --- Created attachment 171147 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171147&action=edit Bug 37684: Direct link to expired news are broken When using a direct link to a news (koha.url/cgi-bin/koha/opac-main.pl?news_id=XXX), the link is broken if the news is expired. Formerly, a using AdditionalContent->get( id => "my_news_id") on an expired news was returning a news, and calling get without id was returning all news but the expired ones. This patch adds tests to check this behaviour by adding one expired news and performing following new tests: 1 - It may not be returned by AdditionalContent.get() 2 - It must be returned by AdditionalContent.get() using its id This patch fixes the behaviour by addind the new behaviour or AdditionalContent.get: 1 - Any news must be returned by AdditionalContent.get() using its id; TEST PLAN: 1 - Apply patch 2 - Remove the changes made to Koha/AdditionalContents.pm 3 - Run tests -> one test must fail 4 - Create a news with a expired expiration date, notice the id of the news in the url of the modification panel 5 - Go to "opac.url/cgi-bin/koha/opac-main.pl?news_id=MY_ID" -> notice it does not work 6 - Reapply the whole patch 7 - Run test -> all test must pass 8 - Go to "opac.url/cgi-bin/koha/opac-main.pl?news_id=MY_ID" -> notice it does work now Signed-off-by: Olivier V <olivier.vezina@inLibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37684 Olivier V <ovezina@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ovezina@inlibro.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37684 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37684 Kyle M Hall (khall) <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37684 Kyle M Hall (khall) <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #171147|0 |1 is obsolete| | --- Comment #6 from Kyle M Hall (khall) <kyle@bywatersolutions.com> --- Created attachment 173867 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173867&action=edit Bug 37684: Direct link to expired news are broken When using a direct link to a news (koha.url/cgi-bin/koha/opac-main.pl?news_id=XXX), the link is broken if the news is expired. Formerly, a using AdditionalContent->get( id => "my_news_id") on an expired news was returning a news, and calling get without id was returning all news but the expired ones. This patch adds tests to check this behaviour by adding one expired news and performing following new tests: 1 - It may not be returned by AdditionalContent.get() 2 - It must be returned by AdditionalContent.get() using its id This patch fixes the behaviour by addind the new behaviour or AdditionalContent.get: 1 - Any news must be returned by AdditionalContent.get() using its id; TEST PLAN: 1 - Apply patch 2 - Remove the changes made to Koha/AdditionalContents.pm 3 - Run tests -> one test must fail 4 - Create a news with a expired expiration date, notice the id of the news in the url of the modification panel 5 - Go to "opac.url/cgi-bin/koha/opac-main.pl?news_id=MY_ID" -> notice it does not work 6 - Reapply the whole patch 7 - Run test -> all test must pass 8 - Go to "opac.url/cgi-bin/koha/opac-main.pl?news_id=MY_ID" -> notice it does work now Signed-off-by: Olivier V <olivier.vezina@inLibro.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37684 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |kyle@bywatersolutions.com |y.org | CC| |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37684 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |24.11.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37684 --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.11! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37684 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Version(s)|24.11.00 |24.11.00,24.05.06 released in| | Status|Pushed to main |Pushed to stable --- Comment #8 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Backported to 24.05.x for upcoming 24.05.06 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37684 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37684 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Status|Pushed to oldstable |Pushed to oldoldstable Version(s)|24.11.00,24.05.06 |24.11.00,24.05.06,23.11.11 released in| | --- Comment #9 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 23.11.x for 23.11.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37684 Jesse Maseto <jesse@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |jesse@bywatersolutions.com Status|Pushed to oldoldstable |RESOLVED --- Comment #10 from Jesse Maseto <jesse@bywatersolutions.com> --- Not pushed to LTS. Marked Resolved. If you feel this should be in LTS please reply with your reason. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37684 Bug 37684 depends on bug 37629, which changed state. Bug 37629 Summary: Link to news are broken https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37629 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org