http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9263 Fridolyn SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|koha-bugs@lists.koha-commun |fridolyn.somers@biblibre.co |ity.org |m --- Comment #1 from Fridolyn SOMERS <fridolyn.somers@biblibre.com> --- Created attachment 14005 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14005&action=edit Proposed patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9263 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #14005|0 |1 is obsolete| | --- Comment #2 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 14042 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14042&action=edit [SIGNED-OFF] Bug 9263: Trim barcodes in offline circulation Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9263 --- Comment #4 from Fridolyn SOMERS <fridolyn.somers@biblibre.com> --- (In reply to comment #3)

Bug 9263 - Followup - Improve speed of substitution.

Thanks. I think also 'g' regexp option was missing in my patch. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9263 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #14046|0 |1 is obsolete| | --- Comment #6 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 14051 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14051&action=edit Bug 9263: Trim barcodes in offline circulation Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9263 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |m.de.rooy@rijksmuseum.nl --- Comment #7 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- QA Comment: Trivial patch. Did not test offline circ. But this patch is just housekeeping and trims spaces from barcode and cardnumber. Looks good to me. Will not hurt anyone. Passed QA -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9263 --- Comment #9 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to comment #8)

This patch has been pushed to master.

Please try to remember to sign off on patches when QAing.

Hi Jared, I explicitly did not add an additional signoff line because I did not test the offline circ as mentioned in my QA comment. Would a Passed-QA-by line in such exceptional (!) cases be of use? (Also note that this is a trivial patch.) Marcel --- Comment #10 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to comment #8)

This patch has been pushed to master.

Please try to remember to sign off on patches when QAing.

Hi Jared, I explicitly did not add an additional signoff line because I did not test the offline circ as mentioned in my QA comment. Would a Passed-QA-by line in such exceptional (!) cases be of use? (Also note that this is a trivial patch.) Marcel -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9263 --- Comment #11 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- (In reply to comment #10)

(In reply to comment #8)

...

This patch has been pushed to master.

Please try to remember to sign off on patches when QAing.

Hi Jared, I explicitly did not add an additional signoff line because I did not test the offline circ as mentioned in my QA comment. Would a Passed-QA-by line in such exceptional (!) cases be of use? (Also note that this is a trivial patch.) Marcel

Yes, a Passed-QA-by line would be much appreciated. -- You are receiving this mail because: You are watching all bug changes.