[Bug 6399] New: tooltip for tags that says 'separate by comma'
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6399 Bug #: 6399 Summary: tooltip for tags that says 'separate by comma' Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Platform: All OS/Version: All Status: NEW Severity: enhancement Priority: P5 Component: OPAC AssignedTo: oleonard@myacpl.org ReportedBy: nengard@gmail.com QAContact: koha-bugs@lists.koha-community.org Would be nice if there was a tool tip on tag adding forms that noted that tags should be separated by commas. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6399 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6399 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 18149 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18149&action=edit Bug 6399 - tooltip for tags that says 'separate by comma' Some sites split tags on spaces, some on commas. Since Koha splits on a comma, we should make that clear to the patron. This patch adds additional text to the "New tag(s)" label. To test, enable TagsEnabled, TagsInputOnDetail, and TagsInputOnList. Click "Add tag" on both OPAC search results and an OPAC detail page. Confirm that the revised label appears correctly. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6399 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|master |3.14 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6399 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18149|0 |1 is obsolete| | --- Comment #2 from Nicole C. Engard <nengard@gmail.com> --- Created attachment 18150 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18150&action=edit [SIGNED-OFF] Bug 6399 - tooltip for tags that says 'separate by comma' Some sites split tags on spaces, some on commas. Since Koha splits on a comma, we should make that clear to the patron. This patch adds additional text to the "New tag(s)" label. To test, enable TagsEnabled, TagsInputOnDetail, and TagsInputOnList. Click "Add tag" on both OPAC search results and an OPAC detail page. Confirm that the revised label appears correctly. Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com> all tests pass -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6399 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6399 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- This works on the results and details screen for tagging a single record. We also have options for tagging in the cart, the lists and in the result list menu - maybe we should add a hint there too? I like the initial idea of a tooltip, but I agree that on the detail pages having it directly in the label is more obvious. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6399 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6399 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |String patch -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6399 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18150|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 18225 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18225&action=edit [PASSED QA] Bug 6399 - tooltip for tags that says 'separate by comma' Some sites split tags on spaces, some on commas. Since Koha splits on a comma, we should make that clear to the patron. This patch adds additional text to the "New tag(s)" label. To test, enable TagsEnabled, TagsInputOnDetail, and TagsInputOnList. Click "Add tag" on both OPAC search results and an OPAC detail page. Confirm that the revised label appears correctly. Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com> all tests pass Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> All tests pass. There are some more places where we can add tags to multiple records at once, I noted them on the bug. http://bugs.koha-community.org/show_bug.cgi?id=10259 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6399 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt@gmail.com --- Comment #5 from Galen Charlton <gmcharlt@gmail.com> --- Pushed to master. Thanks, Owen! I agree with Katrin's comment that we should consider adjusting the text at the other three places where a tag can be added. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6399 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |tomascohen@gmail.com --- Comment #6 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to 3.12.x. This will be on 3.12.1. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6399 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bgkriegel@gmail.com --- Comment #7 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Pushed to 3.10.x, will be on 3.10.7 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6399 Chris Hall <chrish@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chrish@catalyst.net.nz --- Comment #8 from Chris Hall <chrish@catalyst.net.nz> --- This patch seems like a good candidate for 3.8.x, however the patch doesn't apply cleanly as is. Is it possible for you to resubmit a version for 3.8.x? -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org