http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5910 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 |PATCH-Sent Patch Status|--- |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5910 --- Comment #2 from Chris Cormack <chris@bigballofwax.co.nz> 2011-04-01 00:25:34 UTC --- Hmm I cant see the send off patch anywhere, did you forget to send it Julian? -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5910 --- Comment #4 from Chris Cormack <chris@bigballofwax.co.nz> 2011-04-28 21:28:21 UTC --- I still seem to be missing the signed off patch. Not on the mailing lists or attached. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5910 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #3373|0 |1 is obsolete| | --- Comment #6 from Paul Poulain <paul.poulain@biblibre.com> 2011-08-09 15:05:09 UTC --- Created attachment 4909 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=4909 proposed patch for T::TT This patch add a "search on all authority type" select on the authorities search. It works for UNIMARC, i'm not sure at all it works for MARC21. Maybe it's related to other change in record.abs & things like that. Chris/anyone with a marc21 setup = could you test please = A signoff of a marc21 user is required. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5910 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Patch Status|Needs Signoff |Failed QA --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2011-08-14 15:39:24 UTC --- Patch applies. Testing procedure: - Added topical term: smith - Added personal name: smith, herbert On master: - A search with 'Default' brings up both authorities, all tabs Search Authorities Search Main Heading Search All Headings are working. After adding patch an additional entry is shown in the search pull down "All authority Types" I get the same search results for 'Default' and 'All Authority Types'. Small problem: After searching for 'Default' the pull down stays on 'Default', same for other frameworks. After searching for 'All Authority Types' it jumps back to 'Default'. I question if we need both? Where is the difference between both search options? As we also have a 'Default' framework for bibliographic cataloging I am not sure if renaming it might cause confusion. I am marking this 'Failed QA' becaue I don't see how this is useful and there is a small problem to be addressed if we want this to go in. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5910 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Needs Signoff |Failed QA --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2011-08-14 15:48:01 UTC --- Sorry for causing confusion - tests ARE valid. The right types are in my auth_header table. It seems there is a display problem on the authority detail page. I am going to file a separate bug for that. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5910 --- Comment #11 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- Created attachment 10117 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10117&action=edit Bug 5910: only add "All authority types" for UNIMARC UNIMARC is the only marcflavour that does not already have an option for searching all authority types, so check that the marcflavour is UNIMARC before displaying the additional "All authority types" option. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5910 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10117|0 |1 is obsolete| | --- Comment #12 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 10249 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10249&action=edit Bug 5910: [SIGNED-OFF] only add "All authority types" for UNIMARC UNIMARC is the only marcflavour that does not already have an option for searching all authority types, so check that the marcflavour is UNIMARC before displaying the additional "All authority types" option. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5910 Ian Walls <koha.sekjal@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #13 from Ian Walls <koha.sekjal@gmail.com> --- Both patches together add the "all authority types" option for UNIMARC in a safe and sane way. Marking Passed QA. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5910 --- Comment #15 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- (In reply to comment #14)

if it works under MARC21, why wouldn't we use the same method for UNIMARC ? How does it work for MARC21 ?

Actually, the way it works for MARC21 can only be called... uhhh... weird? There is actually a blank authority type for MARC21, and since Zebra cannot search on blank fields, that is de facto the same as all authority types. The way UNIMARC does it is a lot better. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5910 --- Comment #17 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- (In reply to comment #16)

What about doing a follow-up like : * removing blank authority type in an updatedatabase * remove the [% if (unimarc) %] would it do the job ?

Unfortunately, it seems like old Koha installations are actually dependent on the "Default" authority type. I hope to reduce the dependency on the Default authority type with my work in the authority module, but as of right now, I don't think we can safely remove it. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.