https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40871 Cheryl <clackman@fargolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |clackman@fargolibrary.org -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40871 --- Comment #2 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- Created attachment 192332 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192332&action=edit Bug 40871: Exclude void payments from cashup/bankable transactions -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40871 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40871 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com Status|Needs Signoff |Failed QA --- Comment #4 from David Nind <david@davidnind.com> --- I attempted to test, but after applying the patches I get a 500: Internal Server Error when accessing the transaction history for the register. Developer tools says: Got 500 (Internal Server Error) DataTables warning: table id=table_cashups - Ajax error. Lots of these warnings in /var/log/koha/kohadev/plack-intranet-error.log: [WARN] Use of uninitialized value $CGI::Compile::ROOT::kohadevbox_koha_members_pay_2epl:: change_given in concatenation (.) or string at /kohadevbox/koha/members/pay.pl line 194. Note: I'm not sure what the result expected here is, for example, is this what the result should be after the patches? 1. Two $10 manual transactions added to a patron's account. 2. Two payments made. 3. Cash register bankable total = $20 (More > Tools > Cash management > Cash summary for Centerville) 4. One of the payments voided. 5. Cash register bankable total now = $10 Testing notes (using KTD): 1. Set UseCashRegisters to "Use". 2. Set up a cash register (Administration > Accounting > Cash registers > New cash register). 3. Add two $10 manual transactions to a patron's account. 4. Pay the two amounts. 5. Void one of the payments. 6. Cash register bankable total = $10 (More > Tools > Cash management > Cash summary for Centerville). -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40871 Juliet Heltibridle <jheltibridle@rcplib.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jheltibridle@rcplib.org --- Comment #5 from Juliet Heltibridle <jheltibridle@rcplib.org> --- I'm not sure if this patch addresses it, but the cashup summary also does weird things with voided credit card transactions. In this case: 1. Make a credit payment on a patron account for $10. 2. Note that the bankable amount is $0 (because you didn't take cash) but the total income (cash) is $10. 3. Void the transaction: note that the total income (cash) is still $10. 4. Run the cashup: it won't tell you to remove any $$ from the drawer (because you didn't take cash) 4. Look at the Cashup Summary. It will say that the total amount for the day was $10, but the Total Credit was -$10. -- You are receiving this mail because: You are watching all bug changes.