[Bug 21308] New: Results from order search do not show the search parameters.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21308 Bug ID: 21308 Summary: Results from order search do not show the search parameters. Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: barton@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org A report from one of our partner libraries: "It would be nice if the system told us what our search was. We are often interrupted and then come back and have to get back into our previous work flow. ... it would be nice to see the search parameter explicitly shown in the breadcrumb trail - or somewhere" The breadcrumb trail showed Home › Acquisitions › Orders search › Search results ... and there was no indication of what had been searched for in the URL, or anywhare on the page (aside from implicitly in the returned results). I ran several searches from cgi-bin/koha/acqui/histsearch.pl myself, and confirmed this. To re-create: 1) Navigate to Home › Acquisitions 2) Click on 'Orders Search' under the masthead search bar 3) Search for a title and click 'Submit' 4) Run a browser search for the the title, note that it appears only in the results. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21308 --- Comment #1 from Barton Chittenden <barton@bywatersolutions.com> --- Created attachment 78359 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78359&action=edit Screenshot of search results, search for Title 'test' -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21308 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21308 --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 85525 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85525&action=edit Bug 21308: Results from order search do not show the search parameters This patch modifies the orders search results page so that the search form appears in the sidebar. This allows the user to view and re-use their search parameters. This patch also moves the "no search results" message to the top of the page in a message box. To test, apply the patch and go to Acquisitions -> Orders search. - Perform a search which will return results. In the sidebar you should see the full orders search form with your search parameters in the form fields. - Perform a search which will return no results. You should see the "Your search returned no results." message in a standard message dialog. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21308 Genevieve Beaudry <genevieve.beaudry@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |genevieve.beaudry@inlibro.c | |om Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21308 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |oleonard@myacpl.org |ity.org | Status|Signed Off |Needs Signoff CC| |josef.moravec@gmail.com --- Comment #3 from Josef Moravec <josef.moravec@gmail.com> --- I don't think it is signed off... -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21308 Bin <bin.wen@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85525|0 |1 is obsolete| | --- Comment #4 from Bin <bin.wen@inlibro.com> --- Created attachment 85913 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85913&action=edit Bug 21308: Results from order search do not show the search parameters This patch modifies the orders search results page so that the search form appears in the sidebar. This allows the user to view and re-use their search parameters. This patch also moves the "no search results" message to the top of the page in a message box. To test, apply the patch and go to Acquisitions -> Orders search. - Perform a search which will return results. In the sidebar you should see the full orders search form with your search parameters in the form fields. - Perform a search which will return no results. You should see the "Your search returned no results." message in a standard message dialog. Signed-off-by: Bin Wen <bin.wen@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21308 --- Comment #5 from Josef Moravec <josef.moravec@gmail.com> --- (In reply to Bin from comment #4)
Signed-off-by: Bin Wen <bin.wen@inlibro.com>
Bin, you should also change status of report to "Signed off" when you are signing off. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21308 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85913|0 |1 is obsolete| | --- Comment #6 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 88078 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88078&action=edit Bug 21308: Results from order search do not show the search parameters This patch modifies the orders search results page so that the search form appears in the sidebar. This allows the user to view and re-use their search parameters. This patch also moves the "no search results" message to the top of the page in a message box. To test, apply the patch and go to Acquisitions -> Orders search. - Perform a search which will return results. In the sidebar you should see the full orders search form with your search parameters in the form fields. - Perform a search which will return no results. You should see the "Your search returned no results." message in a standard message dialog. Signed-off-by: Bin Wen <bin.wen@inlibro.com> Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21308 Séverine Queune <severine.queune@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |severine.queune@bulac.fr --- Comment #7 from Séverine Queune <severine.queune@bulac.fr> --- Seems ok to me ! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21308 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |katrin.fischer@bsz-bw.de |y.org | Summary|Results from order search |Results from order search |do not show the search |do not show the search |parameters. |parameters CC| |katrin.fischer@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21308 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21308 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88078|0 |1 is obsolete| | --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 88114 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88114&action=edit Bug 21308: Results from order search do not show the search parameters This patch modifies the orders search results page so that the search form appears in the sidebar. This allows the user to view and re-use their search parameters. This patch also moves the "no search results" message to the top of the page in a message box. To test, apply the patch and go to Acquisitions -> Orders search. - Perform a search which will return results. In the sidebar you should see the full orders search form with your search parameters in the form fields. - Perform a search which will return no results. You should see the "Your search returned no results." message in a standard message dialog. Signed-off-by: Bin Wen <bin.wen@inlibro.com> Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21308 --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I like it! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21308 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Results from order search |Show acq history search |do not show the search |filters on search results |parameters |page -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21308 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |nick@bywatersolutions.com --- Comment #10 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21308 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |19.05.00 released in| | Status|Pushed to Master |RESOLVED Resolution|--- |FIXED CC| |martin.renvoize@ptfs-europe | |.com --- Comment #11 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Enhancement will not be backported to 18.11.x series. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21308 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This enhancement modifies release notes| |the orders search results | |page so that the search | |form appears in the | |sidebar. | | | |This allows the | |user to view and re-use | |their search parameters. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21308 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Show acq history search |Show the search filters |filters on search results |used on the search results |page |page for acquisitions | |history searches -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org