[Bug 18163] New: Elasticsearch itemtype indexing correctly for unimarc
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18163 Bug ID: 18163 Summary: Elasticsearch itemtype indexing correctly for unimarc Change sponsored?: --- Product: Koha Version: 16.11 Hardware: All OS: Linux Status: NEW Severity: minor Priority: P5 - low Component: Searching Assignee: gmcharlt@gmail.com Reporter: pjamorim91@gmail.com QA Contact: testopia@bugs.koha-community.org After installing and indexing Elasticsearch, a search for itemtype is not working correctly. The reason for this I think is that Marc21 uses the index itype whereas Unimarc uses the index itemtype. The index mapped in mappings.yml is itype, and a search for item type in unimarc will search on itemtype index, which has nothing mapped to. Furthermore, trying to change the index from itype to itemtype in the mappings panel for elasticsearch will trigger the following error: Can't call method "label" on an undefined value at /usr/share/koha/intranet/cgi-bin/admin/searchengine/elasticsearch/mappings.pl line 69 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18163 Pedro Amorim <pjamorim91@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Elasticsearch itemtype |Elasticsearch unimarc |indexing correctly for |advanced search by item |unimarc |type not working -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18163 --- Comment #1 from Pedro Amorim <pjamorim91@gmail.com> --- I added the itemtype index in mappings.yaml and reset it. Still not working. The itype is indeed being used in unimarc and working properly but only from the facets. Searching from the advanced search still returns no results and the search is being conducted with "itemtype,phr:TYPE". If I manually change this to "itemtype:TYPE" it's returning the records with item type TYPE correctly. Can the problem be in the phrase? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18163 Pedro Amorim <pjamorim91@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Elasticsearch unimarc |Elasticsearch advanced |advanced search by item |search by item type not |type not working |working with | |item-level_itypes turned | |off (biblio record) --- Comment #2 from Pedro Amorim <pjamorim91@gmail.com> --- Turns out the the difference between itype and itemtype is related to the item-level_itypes preference, which i had it set to biblio record instead of item. I changed the preference back to item-level and now the search is working. However, upon indexing, the following message is thrown: "item-level_itypes set but no itemtype set for item (ID) at /usr/share/koha/lib/Koha/Schema/Result/Item.pm line 698. " Which is confusing because the item type info is in biblioitems.itemtype for the items and also the search is apparently working fine. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18163 --- Comment #3 from Pedro Amorim <pjamorim91@gmail.com> --- The reason the search is throwing the warning: "item-level_itypes set but no itemtype set for item (ID) at /usr/share/koha/lib/Koha/Schema/Result/Item.pm line 698. " is because the items.itype are indeed NULL (no info at the time of import). And the reason the search is working is because it falls back to the biblioitems.itemtype after throwing the error: https://github.com/Koha-Community/Koha/blob/4f178fad53fb748bd1ccf67680e02411... With all that, the bug remains, the advanced search by item type will return no results because it's searching as "itemtype, phr". "itemtype" alone will return the results correctly. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18163 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|16.11 |unspecified CC| |jonathan.druart@bugs.koha-c | |ommunity.org Depends on| |12478 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12478 [Bug 12478] Elasticsearch support for Koha -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18163 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit | |y.org | Component|Searching |Searching - Elasticsearch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18163 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18163 --- Comment #4 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 75564 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75564&action=edit Bug 18163: Unit tests prove -v t/db_dependent/Koha/SearchEngine/Elasticsearch/QueryBuilder.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18163 --- Comment #5 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 75565 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75565&action=edit Bug 18163: Pass through limits in ES Before these patches we only allow a small subset of indexes to be used as limits - if we are going to let users add new fields eventually we probably don't want to strip out terms we didn't plan for. To test: 1 - Enable ES 2 - Using sample kohadevbox data try a search like this (or adjust as necessary): http://localhost:8080/cgi-bin/koha/opac-search.pl?idx=kw&idx=kw&idx=kw&limit=subject%2Cphr%3Astreet&sort_by=relevance&do=Search 3 - Note nothing is found 4 - Apply patches 5 - Repeat search 6 - It works! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18163 Cab Vinton <bibliwho@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bibliwho@gmail.com --- Comment #6 from Cab Vinton <bibliwho@gmail.com> --- Unable to replicate in Biblibre sandboxes 11 (this patch) & 12 (master), w/ database 2 (UNIMARC). Tried searching by subject and subject phrase, & both with and without an item type limit: opac-search.pl?idx=su%2Cphr&q=rugby&op=and&idx=kw&q=&op=and&idx=kw&q=&do=Search&limit=mc-itype%2Cphr%3ALIVR Search returned the same 2 results in both sandboxes. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18163 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #75564|0 |1 is obsolete| | Attachment #75565|0 |1 is obsolete| | --- Comment #7 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 85891 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85891&action=edit Bug 18163: Unit tests prove -v t/db_dependent/Koha/SearchEngine/Elasticsearch/QueryBuilder.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18163 --- Comment #8 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 85892 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85892&action=edit Bug 18163: Pass through limits in ES Before these patches we only allow a small subset of indexes to be used as limits - if we are going to let users add new fields eventually we probably don't want to strip out terms we didn't plan for. To test: 1 - Enable ES 2 - Using sample kohadevbox data try a search like this (or adjust as necessary): http://localhost:8080/cgi-bin/koha/opac-search.pl?idx=kw&idx=kw&idx=kw&limit=subject%2Cphr%3Astreet&sort_by=relevance&do=Search 3 - Note nothing is found 4 - Apply patches 5 - Repeat search 6 - It works! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18163 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA Assignee|gmcharlt@gmail.com |nick@bywatersolutions.com CC| |josef.moravec@gmail.com --- Comment #9 from Josef Moravec <josef.moravec@gmail.com> --- Hi Nick, nice enhancement, but the test does not cover the change - it passes with and without the second patch. I am attaching rebased patches, as there were some minor conflicts. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18163 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Failed QA |RESOLVED --- Comment #10 from Nick Clemens <nick@bywatersolutions.com> --- Fixed by bug 19575 commit 6d53910f0ca05ae41b0d10ce6f3eb274efd3aca4 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org