[Bug 15765] New: Request to replace patron number list by patron barcode list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15765 Bug ID: 15765 Summary: Request to replace patron number list by patron barcode list Change sponsored?: --- Product: Koha Version: 3.22 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Label/patron card printing Assignee: cnighswonger@foundations.edu Reporter: Heinrich.Hartl@email.de QA Contact: testopia@bugs.koha-community.org Change request: Substitute patron barcodes for patron numbers Patron card creator is working with something called a batch. A batch is a list of patron numbers where patron number is the koha internal index of a patron. Unfortunately the patron number is to my knowledge a patron property that is not known elsewhere. E.g. it is not shown when displaying patron details. But even in the patron search part of patron card creator that number is not shown. In the patron search we see e.g. name and barcode of the patron. Patron barcodes are familiar and found in many reports, in patron import and in patron displays. I suggest to replace the list of patron numbers by a list of patron barcodes. Patron barcodes are also unique identifers of patrons, an unambigous index into the borrowers table. An entered barcode not necessarily identifies an existing patron. However an entered patron number is not more reliable since a patron may have been deleted or may not be existent. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15765 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Summary|Request to replace patron |Request to replace |number list by patron |borrowernumber list by |barcode list |cardnumber --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Patron cardnumbers can be changed - that's the reason Koha uses the borrowernumber internally. The borrower number (I think that is meant by patron number?) is displayed on the details tab of the patron account, probably labelled as "Benutzernummer". Maybe instead of replacing, we could make it also possible to use cardnumbers for adding to a batch? And also display the cardnumber in the table? Similar to how the items batch tools accept both - the barcode and the internal itemnumber. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15765 --- Comment #2 from Heinrich Hartl <Heinrich.Hartl@email.de> --- Keep it simple is my only argument against adding a column. I tried to make clear that a borrower number entered is not yet validated (existing borrower?). For this reason borrower numbers are no better than barcodes, both need validation. I am not against adding the column but I think replacing is better. The not very likely change of a borrower barcode (here i may be wrong ... there could be situations when systematic changes of barcodes are done but in that situation would we reuse an old batch?) is the only situation where an entry in a batch would remain valid if the batch is kept as a borrower number list. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15765 --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- We could just add the column for display - not in the database. The borrowernumber will be used to look up the information, like it does for the name already. In the database we should consistently use the borrowernumber for linking between tables, as it's the primary key. You can also use FK constraints to automatically delete a patron from the batches, when the patron record is deleted (not sure if that is the case currently, I haven't checked). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15765 --- Comment #4 from Chris Nighswonger <cnighswonger@foundations.edu> --- Created attachment 47862 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47862&action=edit Attempt to add a non-existent borrower number -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15765 --- Comment #5 from Chris Nighswonger <cnighswonger@foundations.edu> --- (In reply to Heinrich Hartl from comment #2)
I tried to make clear that a borrower number entered is not yet validated (existing borrower?). For this reason borrower numbers are no better than barcodes, both need validation.
Maybe I'm misunderstanding what you mean by "not validated" in the context above. But the way in which borrowers are added to a batch is by selecting them from patron search results. Because of this, one cannot add a "non-existent" borrower number to a batch. If you attempt to add an "invalid" borrower number via cgi call such as this: cgi-bin/koha/patroncards/edit-batch.pl?borrower_number=10000&batch_id=738&op=add The script will return an error like the one on the attached screen shot. However, adding the patron barcode to the batch display should be straightforward. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15765 --- Comment #6 from Heinrich Hartl <Heinrich.Hartl@email.de> --- Thank you Chris for your comments, they made me look at my proposal again. I did some testing: I tried to enter an invalid borrowernumber. It was silently ignored when pushing the ADD button. Since something I normally would like to be achieved failed, I would prefer to get a warning message. After the batch was set up I deleted a patron (both with tool batch deletion and also with patro/more/delete). In both cases the patron was also removed from the batch list. +++ The required input validation is in place :-) I scanned through the patron reports. There I found an almost balanced result: cardnumber is used only slightly more frequently than borrower number. It seem to be a personal preference, finding myself clearly on the cardnumber side. To accomodate both preferences I agree with Katrin: why not have both in the table. Please have a look at patroncards/add_user_search.pl table: Card / Name / Category / Library / Expires / Notes / Add where Card holds cardnumber (which barcode string), Name holds surname, firstname(cardnumber), ... and compare it with patroncards/edit-batch.pl table: Borrower Name / Borrower number / Action / Select Where Borrower Name again is surname, firstname and Action is Delete | Export add_user_search displays barcodes string twice. add_user_search panal could be improved by more clearly indicating which fields are searched for the entered search string. I would like very much if a select column together with "select all" and "add selected" buttons were added! If the contents of the add_user_search table are judged satisfactory why not display consistent and rich information when displaying edit-batch.pl table? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15765 Michael Hafen <michael.hafen@washk12.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |michael.hafen@washk12.org --- Comment #7 from Michael Hafen <michael.hafen@washk12.org> --- Re: the "select all" and "add selected". I have an enhancement bug to add sort1 and sort2 to add_user_search.pl which also adds those buttons. See Bug 28726 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org