[Bug 16742] New: Dead code (?) - catalogue/subject.tt seems never to be used
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16742 Bug ID: 16742 Summary: Dead code (?) - catalogue/subject.tt seems never to be used Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt@gmail.com Reporter: veron@veron.ch QA Contact: testopia@bugs.koha-community.org It seems that catalogue/subject.tt is never used. There is a call in catalogue/moredetail.pl line 52 depending on a param 'subject', but catalogue/moredetail.pl is never called with such param. See also FIXME comment on line 45 and comment 2 in Bug 15927: Catalog -> subject.tt (is this template used? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16742 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=15927 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16742 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- (In reply to Marc Véron from comment #0)
It seems that catalogue/subject.tt is never used.
As far as I know it hasn't been used since version 1.x. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16742 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Dead code (?) - |Remove unused template |catalogue/subject.tt seems |subject.tt |never to be used | Status|NEW |ASSIGNED Assignee|gmcharlt@gmail.com |veron@veron.ch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16742 --- Comment #2 from Marc Véron <veron@veron.ch> --- Created attachment 52424 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52424&action=edit Bug 16742: Remove unused template subject.tt The template koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/subject.tt is not used and can be removed. To test: - Apply patch - Verify that catalogue/moredetail.pm works as before (go to a biblio with items and click 'Items' in left hand menue) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16742 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16742 Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #52424|0 |1 is obsolete| | --- Comment #3 from Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> --- Created attachment 52469 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52469&action=edit [SIGNED-OFF]Bug 16742: Remove unused template subject.tt The template koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/subject.tt is not used and can be removed. To test: - Apply patch - Verify that catalogue/moredetail.pl works as before (go to a biblio with items and click 'Items' in left hand menu) Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16742 Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |hector.hecaxmmx@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16742 --- Comment #4 from Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> --- Created attachment 52471 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52471&action=edit Bug 16742: (follow-up)Remove unused template subject.tt Delete extra useless comment line: "# if its a subject we need to use the subject.tt" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16742 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16742 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #52469|0 |1 is obsolete| | Attachment #52471|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 52517 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52517&action=edit Bug 16742: Remove unused template subject.tt The template koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/subject.tt is not used and can be removed. To test: - Apply patch - Verify that catalogue/moredetail.pl works as before (go to a biblio with items and click 'Items' in left hand menu) Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16742 --- Comment #6 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 52518 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52518&action=edit Bug 16742: (follow-up)Remove unused template subject.tt Delete extra useless comment line: "# if its a subject we need to use the subject.tt" Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16742 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #7 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Hard to say if it's not used by anyone, but it is out-of-sync with other templates and need work anyway. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16742 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #8 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to master for 16.11, thanks Marc! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16742 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic@tamil.fr --- Comment #9 from Frédéric Demians <frederic@tamil.fr> --- Pushed in 16.05. Will be in 16.05.02. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16742 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16742 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice@biblibre.com --- Comment #10 from Julian Maurice <julian.maurice@biblibre.com> --- Patches pushed to 3.22.x, will be in 3.22.10 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org