https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41313 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs@lists.koha-commun |arthur.suzuki@biblibre.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41313 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=41768 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41313 --- Comment #1 from Thibaud Guillot (thibaud_g) <thibaud.guillot@biblibre.com> --- Created attachment 201660 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=201660&action=edit Bug 41313: only provide pickup locations for holdable items Test plan : - set "AllowHoldPolicyOverride" to "Don't allow" - set "UseBranchTransferLimits" to "enforce" and "BranchTransferLimitsType" to "collection code" - set "ReserveControlBranch" to "item library" - go to branch transfer limit configuration and clear/disallow all. - add a new circulation rule in centerville to allow record-level holds and set "onshelfholdsallowed" to "if any unavailable". - add a new circulation rule in midway to allow record-level holds but set "onshelfholdsallowed" to "Yes". - go to http://localhost:8081/cgi-bin/koha/reserve/request.pl?borrowernumber=51&biblionumber=155 - see that all libraries are available for pickup (although transfer are disallowed) - apply patch, restart_all, reload page - see that no pickup locations are available and record-level holds are thus not possible. Sponsored-by: BibLibre -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41313 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #3 from David Nind <david@davidnind.com> --- This did not work for me after the patches (see my testing notes): 1. All the pickup locations are still shown for "Pickup at" under "Hold next available item". 2. For "Hold a specific item": - The three items are listed (before the patch, they were not listed) - Holds can be placed for the two items located at Midway - For the item located at Centerville, there is a message in red: "No valid pickup location" in the "Hold" column 3. If other settings are required to make this work as per the test plan, then please include them in the test plan. Notes: 1. The bug title should be be in sentence case. That is, start with "Bug 41313: Only...", not "Bug 41313: only". 2. It needs a description. 3. Please number the test plan steps, as it makes it easier to comment. 4. Some steps in the test plan are incorrect or not clear. 5. See commit message guidelines: https://wiki.koha-community.org/wiki/Commit_messages Testing notes (using KTD): 1. AllowHoldPolicyOverride: default in KTD is "Don't allow" 2. UseBranchTransferLimits: change from "Don't enforce" to "Enforce", BranchTransferLimitsType default in KTD is "collection code". 3. There is no ReserveControlBranch system preference, it is ReservesControlBranch (Reserves with an s at the end); set to "item's home library" 4. "branch transfer limit configuration" - this located under Administration > Patrons and circulation > Library transfer limits (Advanced editor) 5. For each collection code tab, click "Clear all", then click "Save" once done. 6. New circulation rules: - Clone the "All All" rule to Centerville and Midway - Edit rules as per the test plan: . Allow record-level holds: is this the default? Don't see any setting sto change. . Centerville: . On shelf holds allowed: set to "in any unavailable" . Midway: . On shelf holds allowed: set to "Yes" (default All All rule) 7. When placing a hold for "The Korean Go Association's learn to play go": - Before the patch: . Hold next available item: all the pickup locations are shown . Hold a specific item: can't place a hold for a specific item as there are now items shown in the table - After the patch: . Hold next available item: all the pickup locations are still shown . Hold a specific item: - The three items are listed (before the patch, they were not listed) - Holds can be placed for the two items located at Midway - For the item located at Centerville, there is a message in red: "No valid pickup location" in the "Hold" column -- You are receiving this mail because: You are watching all bug changes.