http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8853 mathieu saby <mathieu.saby@univ-rennes2.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mathieu.saby@univ-rennes2.f | |r --- Comment #1 from mathieu saby <mathieu.saby@univ-rennes2.fr> --- Hello Nicole In your title you speak of "closed baskets", but I think you mean "closed basket groups"? If you mean basket groups, we have seen the same behavior, and it is clearly a UX problem. Clicking on closed basketgroups should show some summary, or it should be impossible, but it should NOT reopen basketgroup! For the moment I can make a very small patch : deleting the link. And if somebody wants to create a summary page, it will be an ENH Do you agree with that? M. Saby Rennes 2 University -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8853 mathieu saby <mathieu.saby@univ-rennes2.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|clicking basket name in |clicking basketgroup name |closed baskets reopens it |in closed basketgroups | |reopens it -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8853 mathieu saby <mathieu.saby@univ-rennes2.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |mathieu.saby@univ-rennes2.f |ity.org |r -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8853 --- Comment #4 from mathieu saby <mathieu.saby@univ-rennes2.fr> --- I will take profit of the occasion to add more information on basketgroup list page, so it won't be necessary to click on each basketgroup to know some basical details (billingplace, deliveryplace, number of baskets in each basketgroup, number of orders, number of received orders...) In basketgroups, actions are triggered by buttons. In other pages (as booksellers), they are triggered by links. It sound strange for me. Is there a rule for that in Koha? M. Saby -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8853 mathieu saby <mathieu.saby@univ-rennes2.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8853 mathieu saby <mathieu.saby@univ-rennes2.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8853 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15998|0 |1 is obsolete| | --- Comment #7 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 16038 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16038&action=edit [SIGNED-OFF] Bug 8853: Suppress links in basketgroups list In the table listing all closed basketgroups, clicking the name of a basketgroup reopen it. To edit an open basketgroup or reopen a closed basketgroup, there are specific buttons in "Action" column. So the link around basketgroup name is an UX problem. This patch suppress the link around basketgroup name, in both "closed" and "open" tab. To test : 1. create some closed and open basketgroups 2. check links are not showing anymore Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8853 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |jonathan.druart@biblibre.co | |m --- Comment #8 from Jonathan Druart <jonathan.druart@biblibre.com> --- QA comment: This patch fixes an ergonomic issue (action edit or reopen on clicking a basketgroup name link). qa tools complains on tabulation characters but the file contains too much tab. Marked as Passed QA. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8853 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #10 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- This patch has been pushed to master. -- You are receiving this mail because: You are watching all bug changes.