http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4811 --- Comment #1 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 2164 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=2164 suggestion.pl: display borrowers name in suggestion information filters (Suggested By, Managed by, Accepted by) -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4811 Ian Walls <ian.walls@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ian.walls@bywatersolutions. | |com --- Comment #3 from Ian Walls <ian.walls@bywatersolutions.com> --- My tests (performed on 3.01.00.143 and latest HEAD): Suggested By: works functionally, but does not display the name (only has the borrowernumber in the option value) Managed By: works, both functionally and visually Accepted By: does not work either functionally or visually. Only options are 'ANY', '' and '0'. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4811 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 |PATCH-Sent Blocks| |5580 Patch Status|--- |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4811 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |nengard@gmail.com Patch Status|Needs Signoff |Failed QA AssignedTo|chris@bigballofwax.co.nz |alex.arnaud@biblibre.com --- Comment #6 from Nicole C. Engard <nengard@gmail.com> 2011-03-25 00:34:51 UTC --- After applying this patch the suggestions page was unviewable - instead I had this: Software error: Global symbol "$tmpstatus" requires explicit package name at /home/nengard/kohaclone/suggestion/suggestion.pl line 128. Global symbol "$tmpstatus" requires explicit package name at /home/nengard/kohaclone/suggestion/suggestion.pl line 128. Global symbol "$tmpstatus" requires explicit package name at /home/nengard/kohaclone/suggestion/suggestion.pl line 128. Global symbol "$reason" requires explicit package name at /home/nengard/kohaclone/suggestion/suggestion.pl line 128. Global symbol "$reason" requires explicit package name at /home/nengard/kohaclone/suggestion/suggestion.pl line 128. Global symbol "$reason" requires explicit package name at /home/nengard/kohaclone/suggestion/suggestion.pl line 128. Global symbol "$reason" requires explicit package name at /home/nengard/kohaclone/suggestion/suggestion.pl line 128. Global symbol "$tmpstatus" requires explicit package name at /home/nengard/kohaclone/suggestion/suggestion.pl line 128. Global symbol "$reason" requires explicit package name at /home/nengard/kohaclone/suggestion/suggestion.pl line 128. Global symbol "$reason" requires explicit package name at /home/nengard/kohaclone/suggestion/suggestion.pl line 128. Global symbol "$reason" requires explicit package name at /home/nengard/kohaclone/suggestion/suggestion.pl line 128. Global symbol "$reason" requires explicit package name at /home/nengard/kohaclone/suggestion/suggestion.pl line 128. Global symbol "$suggestionid" requires explicit package name at /home/nengard/kohaclone/suggestion/suggestion.pl line 128. Global symbol "$suggestionid" requires explicit package name at /home/nengard/kohaclone/suggestion/suggestion.pl line 128. Global symbol "$suggestionid" requires explicit package name at /home/nengard/kohaclone/suggestion/suggestion.pl line 128. Global symbol "$delete_field" requires explicit package name at /home/nengard/kohaclone/suggestion/suggestion.pl line 128. Global symbol "$delete_field" requires explicit package name at /home/nengard/kohaclone/suggestion/suggestion.pl line 128. Global symbol "$criteria_list" requires explicit package name at /home/nengard/kohaclone/suggestion/suggestion.pl line 128. Global symbol "@allsuggestions" requires explicit package name at /home/nengard/kohaclone/suggestion/suggestion.pl line 128. Global symbol "$reasonsloop" requires explicit package name at /home/nengard/kohaclone/suggestion/suggestion.pl line 128. Global symbol "$criteriumvalue" requires explicit package name at /home/nengard/kohaclone/suggestion/suggestion.pl line 128. Global symbol "$criteria_list" requires explicit package name at /home/nengard/kohaclone/suggestion/suggestion.pl line 128. Global symbol "$definedvalue" requires explicit package name at /home/nengard/kohaclone/suggestion/suggestion.pl line 128. Global symbol "$definedvalue" requires explicit package name at /home/nengard/kohaclone/suggestion/suggestion.pl line 128. Global symbol "$criteriumvalue" requires explicit package name at /home/nengard/kohaclone/suggestion/suggestion.pl line 128. Global symbol "$criteriumvalue" requires explicit package name at /home/nengard/kohaclone/suggestion/suggestion.pl line 128. Global symbol "$criteriumvalue" requires explicit package name at /home/nengard/kohaclone/suggestion/suggestion.pl line 128. Global symbol "$suggestions" requires explicit package name at /home/nengard/kohaclone/suggestion/suggestion.pl line 128. Global symbol "$suggestion" requires explicit package name at /home/nengard/kohaclone/suggestion/suggestion.pl line 128. Global symbol "$suggestions" requires explicit package name at /home/nengard/kohaclone/suggestion/suggestion.pl line 128. Global symbol "$suggestion" requires explicit package name at /home/nengard/kohaclone/suggestion/suggestion.pl line 128. Global symbol "$suggestion" requires explicit package name at /home/nengard/kohaclone/suggestion/suggestion.pl line 128. Global symbol "$suggestion" requires explicit package name at /home/nengard/kohaclone/suggestion/suggestion.pl line 128. Global symbol "$date" requires explicit package name at /home/nengard/kohaclone/suggestion/suggestion.pl line 128. Global symbol "$suggestion" requires explicit package name at /home/nengard/kohaclone/suggestion/suggestion.pl line 128. Global symbol "$date" requires explicit package name at /home/nengard/kohaclone/suggestion/suggestion.pl line 128. Global symbol "$suggestion" requires explicit package name at /home/nengard/kohaclone/suggestion/suggestion.pl line 128. Global symbol "$date" requires explicit package name at /home/nengard/kohaclone/suggestion/suggestion.pl line 128. Global symbol "$suggestion" requires explicit package name at /home/nengard/kohaclone/suggestion/suggestion.pl line 128. Global symbol "$date" requires explicit package name at /home/nengard/kohaclone/suggestion/suggestion.pl line 128. Global symbol "$suggestion" requires explicit package name at /home/nengard/kohaclone/suggestion/suggestion.pl line 128. Global symbol "$date" requires explicit package name at /home/nengard/kohaclone/suggestion/suggestion.pl line 128. Global symbol "$suggestion" requires explicit package name at /home/nengard/kohaclone/suggestion/suggestion.pl line 128. Global symbol "$date" requires explicit package name at /home/nengard/kohaclone/suggestion/suggestion.pl line 128. Global symbol "@allsuggestions" requires explicit package name at /home/nengard/kohaclone/suggestion/suggestion.pl line 128. Global symbol "$criteriumvalue" requires explicit package name at /home/nengard/kohaclone/suggestion/suggestion.pl line 128. Global symbol "$criteriumvalue" requires explicit package name at /home/nengard/kohaclone/suggestion/suggestion.pl line 128. Global symbol "$suggestions" requires explicit package name at /home/nengard/kohaclone/suggestion/suggestion.pl line 128. Global symbol "$suggestions" requires explicit package name at /home/nengard/kohaclone/suggestion/suggestion.pl line 128. Global symbol "$reasonsloop" requires explicit package name at /home/nengard/kohaclone/suggestion/suggestion.pl line 128. Global symbol "$definedvalue" requires explicit package name at /home/nengard/kohaclone/suggestion/suggestion.pl line 216. Global symbol "@allsuggestions" requires explicit package name at /home/nengard/kohaclone/suggestion/suggestion.pl line 223. Execution of /home/nengard/kohaclone/suggestion/suggestion.pl aborted due to compilation errors. For help, please send mail to the webmaster (webmaster@debian), giving this error message and the time and date of the error. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4811 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Patch Status|Failed QA |--- Resolution| |FIXED --- Comment #7 from Paul Poulain <paul.poulain@biblibre.com> 2011-04-05 08:09:17 UTC --- This feature is already here. Something in the followup from Chris was fixed yesterday in 6046 : + if ( $displayby =~ /managedby/ || $displayby =~ /acceptedby/ || $displayby =~ /suggestedby/) { Nicole: the follow-up from Chris is wrong, it contains many <<< and === and >>> (a git conflict, not solved) -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.