[Bug 26518] New: Adding a record can succeed even if adding the biblioitem fails
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26518 Bug ID: 26518 Summary: Adding a record can succeed even if adding the biblioitem fails Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Cataloging Assignee: koha-bugs@lists.koha-community.org Reporter: nick@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: m.de.rooy@rijksmuseum.nl We can end up creating biblios in the catalog that are malformed To test: 1 - Add new record with field 010: ThisisgoingtobetoomanycharactersfortheLCCNfield 2 - Check the logs, note the error about failure to create biblioitem: DBD::mysql::st execute failed: Data too long for column 'lccn' at row 1 [for Statement "INSERT INTO biblioitems SET biblionumber = ?, volume = ?, number = ?, itemtype = ?, isbn = ?, issn = ?, publicationyear = ?, publishercode = ?, volumedate = ?, volumedesc = ?, collectiontitle = ?, collectionissn = ?, collectionvolume= ?, editionstatement= ?, editionresponsibility = ?, illus = ?, pages = ?, notes = ?, size = ?, place = ?, lccn = ?, url = ?, cn_source = ?, cn_class = ?, cn_item = ?, cn_suffix = ?, cn_sort = ?, totalissues = ?, ean = ?, agerestriction = ? " with ParamValues: 0='1681', 1=undef, 2=undef, 3=undef, 4=undef, 5=undef, 6=undef, 7=undef, 8=undef, 9=undef, 10=undef, 11=undef, 12=undef, 13=undef, 14=undef, 15=undef, 16=undef, 17=undef, 18=undef, 19=undef, 20="This is the ongest field i can think of", 21=undef, 22=undef, 23=undef, 24=undef, 25=undef, 26='', 27=undef, 28=undef, 29=undef] at /kohadevbox/koha/C4/Biblio.pm line 2926. ERROR in _koha_add_biblioitem INSERT INTO biblioitems SET 3 - Record saves successfully otherwise 4 - Attempt to add an item: Can't call method "biblioitemnumber" on an undefined value at /kohadevbox/koha/Koha/Item.pm line 83. at /kohadevbox/koha/Koha/Item.pm line 82 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26518 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26518 --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 110902 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110902&action=edit Bug 26518: Use Koha::Biblio[item] in AddBiblio -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26518 --- Comment #2 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 110903 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110903&action=edit Bug 26518: Raise exception if the insert failed -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26518 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com, tomascohen@gmail.com --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- This first patch fixes the problem when using the UI, but the tests fail. I guess there is something do tweak for the dev_install and strict_mode config flag. Attaching them here in case someone else wants to give it a try. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26518 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=26523 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26518 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |jonathan.druart@bugs.koha-c |ity.org |ommunity.org Status|NEW |In Discussion --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Can I get some help on this one please? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26518 --- Comment #5 from Nick Clemens <nick@bywatersolutions.com> --- (In reply to Jonathan Druart from comment #4)
Can I get some help on this one please?
The return in the catch returns from the catch, not the AddBiblio function. Have the catch set biblionumber and biblioitemnumber as undef and it clears up part The other problem is that the test is nested in a transaction so the inner one fails but leaves the rollback for the outer, so the bib count changes until the tests finish. I don't know how to fix it - you can move the txn->begin in the tests after the first test but that seems dangerous -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26518 --- Comment #6 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 111387 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111387&action=edit Bug 26518: Does not return from the catch block -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26518 --- Comment #7 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- I am scared a bit. Take the following code: #!/usr/bin/perl use Modern::Perl; use Test::More tests => 1; use Koha::Database; use Koha::Cities; use Koha::Exceptions; use Try::Tiny; my $schema = Koha::Database->new->schema; subtest 'City' => sub { plan tests => 2; my $nb_cities = Koha::Cities->count; my $city_id; $city_id = add_city(); is( $city_id, undef); is( Koha::Cities->count, $nb_cities ); }; sub add_city{ my $city_id; try { $schema->txn_do(sub { $city_id = Koha::City->new({ city_name => "test" })->store->cityid; Koha::Exceptions::ObjectNotCreated->throw; }); } catch { $city_id = undef; warn $_; }; return $city_id; } => The city won't be added. Now surround $city_id = add_city(); with a transaction: $schema->storage->txn_do(sub { $city_id = add_city(); }); => The city is added. Which means that what we are doing in the "sub add_city" depends on how the caller is handling things, and that is very scary. We are going to hit very weird side-effects. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26518 --- Comment #8 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- See also https://metacpan.org/pod/distribution/DBIx-Class/lib/DBIx/Class/Manual/Cookb... and https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21684#c2 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26518 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |26639 --- Comment #9 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- See bug 26639 - Turn auto_savepoint ON which is, hopefully, the correct path to follow. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26639 [Bug 26639] Turn auto_savepoint ON -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26518 --- Comment #10 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 111389 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111389&action=edit Bug 26518: Hide expected DBI warnings -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26518 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff --- Comment #11 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- And tests are now passing on top of bug 26639! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26518 --- Comment #12 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Did we want to prevent the action at a distance that can add authority records at the same time? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26518 --- Comment #13 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Jonathan Druart from comment #7)
=> The city is added.
Which means that what we are doing in the "sub add_city" depends on how the caller is handling things, and that is very scary.
We are going to hit very weird side-effects.
The inner transaction does not do a rollback anymore. The outer transaction commits. We came across this already when calling some routines that include a txn_do from the test scripts. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26518 --- Comment #14 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- (In reply to Marcel de Rooy from comment #13)
(In reply to Jonathan Druart from comment #7)
=> The city is added.
Which means that what we are doing in the "sub add_city" depends on how the caller is handling things, and that is very scary.
We are going to hit very weird side-effects.
The inner transaction does not do a rollback anymore. The outer transaction commits. We came across this already when calling some routines that include a txn_do from the test scripts.
See bug 26639 Marcel, we've fixed the issue there. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26518 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #110902|0 |1 is obsolete| | Attachment #110903|0 |1 is obsolete| | Attachment #111387|0 |1 is obsolete| | Attachment #111389|0 |1 is obsolete| | --- Comment #15 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 111512 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111512&action=edit Bug 26518: Use Koha::Biblio[item] in AddBiblio Bug 26518: Does not return from the catch block -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26518 --- Comment #16 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 111513 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111513&action=edit Bug 26518: Raise exception if the insert failed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26518 --- Comment #17 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 111514 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111514&action=edit Bug 26518: Hide expected DBI warnings -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26518 --- Comment #18 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 111515 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111515&action=edit Bug 26518: Move BiblioAutoLink within the transaction We don't want the authorities to be created if the biblio insert fails later -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26518 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #19 from David Nind <david@davidnind.com> --- Created attachment 113046 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113046&action=edit Screenshot - After patch applied and attempting to save the record I can replicate the issue. After applying the patches I attempt to add another new record. When saving the record, I don't get the add new item screen - see the screenshot attached. The record is not added, it shows up in the reservoir, and there are these warnings are in the log: 66 [2020/11/05 08:29:42] [WARN] DBD::mysql::st execute failed: Data too long for column 'lccn' at row 1 [for Statement "INSERT INTO `biblioitems` ( `agerestriction`, `biblionumber`, `cn_class`, `cn_ite m`, `cn_sort`, `cn_source`, `cn_suffix`, `collectionissn`, `collectiontitle`, `collectionvolume`, `ean`, `editionresponsibility`, `editionstatement`, `illus`, `isbn`, `issn`, `itemtype`, `lccn`, `no tes`, `number`, `pages`, `place`, `publicationyear`, `publishercode`, `size`, `timestamp`, `totalissues`, `url`, `volume`, `volumedate`, `volumedesc`) VALUES ( ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, current_timestamp, ?, ?, ?, ?, ? )" with ParamValues: 0=undef, 1='448', 2=undef, 3=undef, 4='', 5="ddc", 6=undef, 7=undef, 8=undef, 9=undef, 10=undef, 11=undef, 12=undef, 13="ill. ;", 14="9780132480529 (pbk. : alk. paper) | 0132480522 (pbk. : alk. paper)", 15=undef, 16="BK", 17="ThisisgoingtobetoomanycharactersfortheLCCNfield", 18=undef, 19=undef, 20="xix, 281 p. :", 21="Upper Saddle River, NJ :", 22=undef, 23="IBM Press : | Pearson,", 24="24 cm.", 25=undef, 26=undef, 27=undef, 28=undef, 29=undef] at /usr/share/perl5/DBIx/Class/Storage/DBI.pm line 183 6. 67 [2020/11/05 08:29:42] [WARN] DBIx::Class::Storage::DBI::_dbh_execute(): Data too long for column 'lccn' at row 1 at /kohadevbox/koha/Koha/Object.pm line 169 68 [2020/11/05 08:29:42] [WARN] DBIx::Class::Storage::DBI::_dbh_execute(): Data too long for column 'lccn' at row 1 at /kohadevbox/koha/Koha/Object.pm line 169 69 [2020/11/05 08:29:42] [WARN] Use of uninitialized value $biblionumber in concatenation (.) or string at /kohadevbox/koha/cataloguing/addbiblio.pl line 870. 70 [2020/11/05 08:29:42] [WARN] Use of uninitialized value $searchid in concatenation (.) or string at /kohadevbox/koha/cataloguing/addbiblio.pl line 870. 71 [2020/11/05 08:29:42] [WARN] Use of uninitialized value $frameworkcode in string eq at /kohadevbox/koha/cataloguing/additem.pl line 432. 72 [2020/11/05 08:29:42] [WARN] GetMarcBiblio called with undefined biblionumber at /kohadevbox/koha/cataloguing/additem.pl line 453. My notes for testing (koha-testing-docker): 1. Run through the test plan in the bug description 2. Run the tests: prove -v t/db_dependent/Biblio.t - these should pass 3. Delete the record created 4. Apply the patches 5. Repeat the test plan, this time: - There should be no errors in /var/log/koha/kohadev/plack-intranet-error.log - You should be able to successfully add an item -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26518 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |victor@tuxayo.net --- Comment #20 from Victor Grousset/tuxayo <victor@tuxayo.net> ---
When saving the record, I don't get the add new item screen - see the screenshot attached.
Same error -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26518 --- Comment #21 from Victor Grousset/tuxayo <victor@tuxayo.net> --- I have still error in logs
[2020/11/12 22:42:00] [WARN] DBIx::Class::Storage::DBI::_dbh_execute(): Data too long for column 'lccn' at row 1 at /kohadevbox/koha/Koha/Object.pm line 169 [2020/11/12 22:42:00] [WARN] DBIx::Class::Storage::DBI::_dbh_execute(): Data too long for column 'lccn' at row 1 at /kohadevbox/koha/Koha/Object.pm line 169
-- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26518 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #22 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Yes, that's the expected behaviour. It's not perfect, we should display an error explaining what happened. The goal of this patch is to not create the entry in the biblio DB table if the biblioitem creation failed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26518 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #111512|0 |1 is obsolete| | --- Comment #23 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 113671 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113671&action=edit Bug 26518: Use Koha::Biblio[item] in AddBiblio Bug 26518: Does not return from the catch block Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26518 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #111513|0 |1 is obsolete| | --- Comment #24 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 113672 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113672&action=edit Bug 26518: Raise exception if the insert failed Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26518 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #111514|0 |1 is obsolete| | --- Comment #25 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 113673 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113673&action=edit Bug 26518: Hide expected DBI warnings Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26518 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #111515|0 |1 is obsolete| | --- Comment #26 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 113674 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113674&action=edit Bug 26518: Move BiblioAutoLink within the transaction We don't want the authorities to be created if the biblio insert fails later Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26518 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #27 from Victor Grousset/tuxayo <victor@tuxayo.net> ---
The goal of this patch is to not create the entry in the biblio DB table if the biblioitem creation failed.
Then it works, thanks for the explanations :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26518 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26518 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #113671|0 |1 is obsolete| | --- Comment #28 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 113917 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113917&action=edit Bug 26518: Use Koha::Biblio[item] in AddBiblio Bug 26518: Does not return from the catch block Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26518 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #113672|0 |1 is obsolete| | --- Comment #29 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 113918 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113918&action=edit Bug 26518: Raise exception if the insert failed Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26518 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #113673|0 |1 is obsolete| | --- Comment #30 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 113919 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113919&action=edit Bug 26518: Hide expected DBI warnings Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26518 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #113674|0 |1 is obsolete| | --- Comment #31 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 113920 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113920&action=edit Bug 26518: Move BiblioAutoLink within the transaction We don't want the authorities to be created if the biblio insert fails later Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26518 --- Comment #32 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 113921 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113921&action=edit Bug 26518: (QA follow-up) Expect warnings, don't supress them Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26518 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26518 --- Comment #33 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26518 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|20.11.00 |20.11.00, 20.05.07 released in| | CC| |andrew@bywatersolutions.com Status|Pushed to master |Pushed to stable --- Comment #34 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Pushed to 20.05.x for 20.05.07 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26518 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26518 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |27245 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27245 [Bug 27245] bulkmarcimport.pl error 'Already in a transaction' -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26518 --- Comment #35 from Victor Grousset/tuxayo <victor@tuxayo.net> --- I doesn't seem to work on 19.11.x 1. apply 2. restart services 3. optional: prove t/db_dependent/Biblio.t (passes) 4. fill a record with 010 = ThisisgoingtobetoomanycharactersfortheLCCNfield 5. save 6. error: "Bibliographic record not found." -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26518 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to oldstable |RESOLVED --- Comment #36 from Victor Grousset/tuxayo <victor@tuxayo.net> --- *It doesn't Not backporting unless this is need and a fix is provided. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26518 --- Comment #37 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Wait, I got confused. «Yes, that's the expected behaviour» Ok, will backport. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26518 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|20.11.00, 20.05.07 |20.11.00, 20.05.07, released in| |19.11.13 --- Comment #38 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Backported to 19.11.x branch for 19.11.13 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26518 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=28328 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org