[Bug 8971] New: Sort holds queue report using DataTables
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8971 Priority: P5 - low Change sponsored?: --- Bug ID: 8971 CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com Assignee: oleonard@myacpl.org Summary: Sort holds queue report using DataTables Severity: normal Classification: Unclassified OS: All Reporter: oleonard@myacpl.org Hardware: All Status: ASSIGNED Version: master Component: Circulation Product: Koha There are bugs with the sort on the holds queue report stemming from the fact that the tablesorter plugin doesn't handle whitespace and markup in table cells very well. The DataTables plugin doesn't seem to mind, so this is a worthwhile replacement. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8971 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8971 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 13056 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13056&action=edit Bug 8971 - Sort holds queue report using DataTables Replacing the old tablesorter plugin with DataTables on this page will fix sorting bugs related to whitespace and markup in table cells which tablesorter couldn't handle. I have also taken the liberty of changing the default sort from patron to call number, assuming that the librarian uses this list to pull items from the shelf, and the shelf is organized by call number. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8971 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #13056|0 |1 is obsolete| | --- Comment #2 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 13232 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13232&action=edit [SIGNED-OFF] Bug 8971 - Sort holds queue report using DataTables Replacing the old tablesorter plugin with DataTables on this page will fix sorting bugs related to whitespace and markup in table cells which tablesorter couldn't handle. I have also taken the liberty of changing the default sort from patron to call number, assuming that the librarian uses this list to pull items from the shelf, and the shelf is organized by call number. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8971 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |kyle@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8971 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj@kohaaloha.com --- Comment #3 from Mason James <mtj@kohaaloha.com> --- (In reply to comment #1)
Created attachment 13056 [details] Bug 8971 - Sort holds queue report using DataTables
Replacing the old tablesorter plugin with DataTables on this page will fix sorting bugs related to whitespace and markup in table cells which tablesorter couldn't handle.
I have also taken the liberty of changing the default sort from patron to call number, assuming that the librarian uses this list to pull items from the shelf, and the shelf is organized by call number.
hmm, can i get a url and/or screenshot for this bug? i dont know where/what to test, currently... -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8971 --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- "Holds queue" from the circulation home page: /cgi-bin/koha/circ/view_holdsqueue.pl To test, confirm that table sorting works correctly on all columns of the report, and consider whether sorting by call number by default is a helpful rather than harmful change. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8971 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |paul.poulain@biblibre.com QA Contact| |paul.poulain@biblibre.com --- Comment #5 from Paul Poulain <paul.poulain@biblibre.com> --- QA comment: * small patch, template only, no string change * passes koha-qa.pl * do the announced job passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8971 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #13232|0 |1 is obsolete| | --- Comment #6 from Paul Poulain <paul.poulain@biblibre.com> --- Created attachment 13549 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13549&action=edit Bug 8971 - Sort holds queue report using DataTables Replacing the old tablesorter plugin with DataTables on this page will fix sorting bugs related to whitespace and markup in table cells which tablesorter couldn't handle. I have also taken the liberty of changing the default sort from patron to call number, assuming that the librarian uses this list to pull items from the shelf, and the shelf is organized by call number. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Paul Poulain <paul.poulain@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8971 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|master |3.10 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8971 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |jcamins@cpbibliography.com --- Comment #7 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- This patch has been pushed to master. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8971 --- Comment #8 from Paul Poulain <paul.poulain@biblibre.com> --- Patch pushed to branch 3.10.x -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8971 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED CC| |chris@bigballofwax.co.nz Resolution|--- |FIXED --- Comment #9 from Chris Cormack <chris@bigballofwax.co.nz> --- Released in 3.10.0 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org