[Bug 20498] New: Move patron templates JavaScript to the footer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20498 Bug ID: 20498 Summary: Move patron templates JavaScript to the footer Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: major Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org CC: testopia@bugs.koha-community.org Depends on: 19641 My patch for Bug 19641 neglected to add members-menu.js to the patron entry template. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19641 [Bug 19641] Move patron templates JavaScript to the footer -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20498 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Move patron templates |Patron advanced search form |JavaScript to the footer |missing from patron entry | |page -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20498 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20498 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 73437 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73437&action=edit Bug 20498 - Patron advanced search form missing from patron entry page My patch moving patron-related templates' javascript to the footer left out a script from the patron entry template which is required if the patron header search menu is going to work. To test, apply the patch and go to Patrons -> New patron. Clicking the [+] link in the "Search patrons" header search form should expand the advanced search options. Test that the page's toolbar still "floats" correctly when you scroll the page. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20498 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |jonathan.druart@bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20498 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20498 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #73437|0 |1 is obsolete| | --- Comment #2 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 73438 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73438&action=edit Bug 20498: (bug 19641 follow-up) Patron advanced search form missing from patron entry page My patch moving patron-related templates' javascript to the footer left out a script from the patron entry template which is required if the patron header search menu is going to work. To test, apply the patch and go to Patrons -> New patron. Clicking the [+] link in the "Search patrons" header search form should expand the advanced search options. Test that the page's toolbar still "floats" correctly when you scroll the page. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20498 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Thanks Owen! Considered a follow-up of bug 19641, Pushed to master for 18.05 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org