https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28036 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28036 Amit Gupta <amitddng135@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |amitddng135@gmail.com Status|Needs Signoff |Patch doesn't apply --- Comment #2 from Amit Gupta <amitddng135@gmail.com> --- Bug 28036: Improve breadcrumbs of serial claims page This patch modifies the serial claims script and templates so that better context can be shown in the page title and page breadcrumbs when a vendor has been selected. To test, apply the patch and go to Serials -> Claims. - The initial state of the page title and breadcrumbs should show "Serials > Claims." - Select a vendor. The page title and breadcrumbs show show "Serials > Claims > Claims for <vendor name>." -------------------------- Apply? [y]es/[n]o/[e]dit/[v]iew patch/[a]ccept all: a Applying: Bug 28036: Improve breadcrumbs of serial claims page fatal: sha1 information is lacking or useless (koha-tmpl/intranet-tmpl/prog/en/modules/serials/claims.tt). error: could not build fake ancestor Patch failed at 0001 Bug 28036: Improve breadcrumbs of serial claims page The copy of the patch that failed is found in: .git/rebase-apply/patch When you have resolved this problem, run "git am --continue". If you prefer to skip this patch, run "git am --skip" instead. To restore the original branch and stop patching, run "git am --abort". ------------------ Patch not applied. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28036 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28036 --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- This works well, just wondering a tiny bit about the variable names. I think we should probably be using vendor, not supplier? Also seem to remember that we had standardized on booksellerid in the acq module at some point as a compromise. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28036 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #118871|0 |1 is obsolete| | --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 118913 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118913&action=edit Bug 28036: Improve breadcrumbs of serial claims page This patch modifies the serial claims script and templates so that better context can be shown in the page title and page breadcrumbs when a vendor has been selected. To test, apply the patch and go to Serials -> Claims. - The initial state of the page title and breadcrumbs should show "Serials > Claims." - Select a vendor. The page title and breadcrumbs show show "Serials > Claims > Claims for <vendor name>." Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28036 --- Comment #7 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.