[Bug 21982] New: Circulation statistics wizard does not count deleted items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21982 Bug ID: 21982 Summary: Circulation statistics wizard does not count deleted items Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Reports Assignee: koha-bugs@lists.koha-community.org Reporter: caroline.cyr-la-rose@inlibro.com QA Contact: testopia@bugs.koha-community.org A client noticed that deleted items are not counted in circulation stats when using the statistics wizard. Here is the test plan: 1) Search the catalog for a record with an available item 2) Loan out that item to a user and return it 3) Go in Reports > Statistics wizards > Circulation 4) Fill in the form - Choose a period that includes today - Choose "Type" = Checkout - Choose Item type for both "Row" and "Column" 5) Leave the rest as is and click "Submit" 6) Note the quantity of loans for the itemtype of your item 7) Go back to your item and delete it 8) Go back to your report and refresh 9) Notice that the amount of loans is less than it was before It's not because the item is deleted that the loan didn't happen The wizard should look at both items and deleted_items to calculate the amount of circulation transactions. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21982 --- Comment #1 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- It would be great for troubleshooting if the SQL query created by the wizard was available through a button on the page (like regular SQL reports). -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21982 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew@bywatersolutions.com --- Comment #2 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- +1 on this, having just run into the same question. By default, the circ wizard is limiting based on homebranch and holdingbranch, but only based on the items table, where items.homebranch and items.holdingbranch are null for things that only exist in deleteditems. If you set those dropdowns to blank and don't limit based on anything else that exists in items rather than statistics, then the wizard will include stats for deleted items. I'd be ok with an immediate quick-fix of just not making this default to limiting based on homebranch and holdingbranch. I'd be even happier about making the wizard look at both items and deleteditems. If we could also get some way to see the SQL used by the wizard, for diagnostic purposes, that'd be amazing. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21982 --- Comment #3 from Jérémy Breuillard <jeremy.breuillard@biblibre.com> --- Created attachment 128011 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128011&action=edit MT 34887: Statistic assistant - Circulation By default statistic assistant filter is set on the existing items and doesn't mind about deleted items. The patch corrects this. Items belong to the same library. Test plan: 1)Make sure to have at least 1 or more item(s) in deleteditems database table 2)Home > Reports > Circulation statistics 3)Fill up 'Issuing library', 'Home library' and 'Holding library' 4)Submit 5)Notice that only statistics for active items are shown 6)Apply patch and repeat from 2) to 5) 7)Now active items and deleted items are shown -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21982 Jérémy Breuillard <jeremy.breuillard@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff CC| |jeremy.breuillard@biblibre. | |com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21982 Jérémy Breuillard <jeremy.breuillard@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128011|MT 34887: Statistic |Bug 34887: Statistic description|assistant - Circulation |assistant - Circulation -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21982 Jérémy Breuillard <jeremy.breuillard@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128011|Bug 34887: Statistic |Bug 21982: Statistic description|assistant - Circulation |assistant - Circulation -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21982 --- Comment #4 from Jérémy Breuillard <jeremy.breuillard@biblibre.com> --- Created attachment 128012 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128012&action=edit BZ 34887: Statistic assistant - Circulation By default statistic assistant filter is set on the existing items and doesn't mind about deleted items. The patch corrects this. Items belong to the same library. Test plan: 1)Make sure to have at least 1 or more item(s) in deleteditems database table 2)Home > Reports > Circulation statistics 3)Fill up 'Issuing library', 'Home library' and 'Holding library' 4)Submit 5)Notice that only statistics for active items are shown 6)Apply patch and repeat from 2) to 5) 7)Now active items and deleted items are shown -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21982 Jérémy Breuillard <jeremy.breuillard@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128012|0 |1 is obsolete| | --- Comment #5 from Jérémy Breuillard <jeremy.breuillard@biblibre.com> --- Created attachment 128013 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128013&action=edit BZ 34887: Statistic assistant - Circulation By default statistic assistant filter is set on the existing items and doesn't mind about deleted items. The patch corrects this. Items belong to the same library. Test plan: 1)Make sure to have at least 1 or more item(s) in deleteditems database table 2)Home > Reports > Circulation statistics 3)Fill up 'Issuing library', 'Home library' and 'Holding library' 4)Submit 5)Notice that only statistics for active items are shown 6)Apply patch and repeat from 2) to 5) 7)Now active items and deleted items are shown -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21982 Jérémy Breuillard <jeremy.breuillard@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128011|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21982 Jérémy Breuillard <jeremy.breuillard@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128013|BZ 34887: Statistic |BZ 21982: Circulation description|assistant - Circulation |statistics wizard does not | |count deleted items -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21982 Jérémy Breuillard <jeremy.breuillard@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128013|BZ 21982: Circulation |Bug 21982: Circulation description|statistics wizard does not |statistics wizard does not |count deleted items |count deleted items -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21982 Jérémy Breuillard <jeremy.breuillard@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128013|0 |1 is obsolete| | --- Comment #6 from Jérémy Breuillard <jeremy.breuillard@biblibre.com> --- Created attachment 128026 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128026&action=edit Bug 21982: Circulation statistics wizard does not count deleted items By default statistic assistant filter is set on the existing items and doesn't mind about deleted items. The patch corrects this. Items belong to the same library. Test plan: 1)Make sure to have at least 1 or more item(s) in deleteditems database table 2)Home > Reports > Circulation statistics 3)Fill up 'Issuing library', 'Home library' and 'Holding library' 4)Submit 5)Notice that only statistics for active items are shown 6)Apply patch and repeat from 2) to 5) 7)Now active items and deleted items are shown -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21982 Sally <sally.healey@cheshiresharedservices.gov.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |sally.healey@cheshireshared | |services.gov.uk --- Comment #7 from Sally <sally.healey@cheshiresharedservices.gov.uk> --- Works as described, signing off. Thanks for the patch! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21982 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128026|0 |1 is obsolete| | --- Comment #8 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 138075 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138075&action=edit Bug 21982: Circulation statistics wizard does not count deleted items By default statistic assistant filter is set on the existing items and doesn't mind about deleted items. The patch corrects this. Items belong to the same library. Test plan: 1)Make sure to have at least 1 or more item(s) in deleteditems database table 2)Home > Reports > Circulation statistics 3)Fill up 'Issuing library', 'Home library' and 'Holding library' 4)Submit 5)Notice that only statistics for active items are shown 6)Apply patch and repeat from 2) to 5) 7)Now active items and deleted items are shown Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21982 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21982 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138075|0 |1 is obsolete| | --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 138106 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138106&action=edit Bug 21982: Circulation statistics wizard does not count deleted items By default statistic assistant filter is set on the existing items and doesn't mind about deleted items. The patch corrects this. Items belong to the same library. Test plan: 1)Make sure to have at least 1 or more item(s) in deleteditems database table 2)Home > Reports > Circulation statistics 3)Fill up 'Issuing library', 'Home library' and 'Holding library' 4)Submit 5)Notice that only statistics for active items are shown 6)Apply patch and repeat from 2) to 5) 7)Now active items and deleted items are shown Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21982 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |katrin.fischer@bsz-bw.de |ity.org | Severity|enhancement |minor -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21982 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |release-notes-needed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21982 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21982 --- Comment #10 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21982 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|release-notes-needed | Text to go in the| |This patch corrects a bug release notes| |in the Circulation | |statistics wizard. | |Previously, the wizard only | |looked at existing items to | |calculate statistics. It | |now includes transactions | |made on items that are now | |deleted. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21982 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|22.11.00 |22.11.00, 22.05.05 released in| | CC| |lucas@bywatersolutions.com --- Comment #11 from Lucas Gass <lucas@bywatersolutions.com> --- Backported to 22.05.x for 22.05.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21982 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.11.00, 22.05.05 |22.11.00,21.11, 22.05.05 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21982 --- Comment #12 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- Thanks! Pushed to 21.11 for 21.11.12 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21982 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor@tuxayo.net Resolution|--- |FIXED Status|Pushed to stable |RESOLVED --- Comment #13 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Not backported to oldoldstable (21.05.x). Feel free to ask if it's needed. Nothing to document it seems, marking resolved. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21982 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=32511 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org