[Bug 21486] New: SIP does not return checked out (charged) items on patron_information request
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21486 Bug ID: 21486 Summary: SIP does not return checked out (charged) items on patron_information request Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: SIP2 Assignee: koha-bugs@lists.koha-community.org Reporter: josef.moravec@gmail.com QA Contact: testopia@bugs.koha-community.org CC: colin.campbell@ptfs-europe.com You can test it with this: misc/sip_cli_emulator.pl -a localhost -p 6001 -su koha -sp koha -l CPL --patron 23529000126806 -s " Y " -m patron_information And see the "AU" field is empty: 64 00120181004 110729000000000001000000000000AOCPL|AA23529000126806|AEBrent Hopkins|BLY|CC5|AU|BD6692 Library Rd. Santa Cruz, CA 21234|BF(212) 555-1212|PB19771113|PCT|PIY|AFGreetings from Koha. | This is because commit bc001c2352fee419a2bbe20c0cf707afd9e5bd78 Bug 19935: Replace GetPendingIssues - SIP -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21486 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |19935 CC| |black23@gmail.com Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19935 [Bug 19935] Move C4::Members::GetPendingIssues to the Koha namespace -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21486 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |alexbuckley@catalyst.net.nz |ity.org | CC| |alexbuckley@catalyst.net.nz -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21486 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21486 --- Comment #1 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 80251 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80251&action=edit Bug 21486: Re-added get_pending_issues function to C4/SIP/ILS/Patron.pm This allows the list of a borrower's checked out items to be returned by SIP. Test plan: 1. Make sure SIP is working with the commands: sudo koha-enable-sip <instancename> sudo koha-start-sip <instancename> 2. Check SIP is working with the command: telnet localhost 6001 3. Choose a patron with items checked out to them and set their username and password in the SIPconfig.xml file 4. From inside the Koha-shell from the Koha home directory run the command: misc/sip_cli_emulator.pl -a localhost -p 6001 -su <sip_user_username> -sp <sip_user_password> -l <sip_user_librarybranch> --patron <sip_user_cardnumber> -s " Y " -m patron_information This command is PATRON_INFORMATION, it should return information about the patron. The Y in the 3rd position of the quotes means return the list of the borrowers charged items (items issued to the borrower). 5. Notice the "AU" field is empty: e.g. READ: 64 00120181008 161428000100000001000000000002AOCPL|AA8765432|AEMika SMith|BLY|CC5|AU|PCB|PIY|AFGreetings from Koha. | i.e. There should be a barcode after the AU field as the borrower has a item issued to them 6. Apply patch 7. Restart memcached and plack with the commands: sudo service memcached restart sudo koha-plack --restart <instancename> 8. Stop SIP: sudo koha-stop-sip <instancename> 9. Then enable and start SIP again: sudo koha-enable-sip <instancename> sudo koha-start-sip <instancename> 10. Repeat step 4 and notice the AU field does have a item barcode value: e.g. READ: 64 00120181008 161859000100000001000000000002AOCPL|AA8765432|AEMika SMith|BLY|CC5|AUTEST7474747474|PCB|PIY|AFGreetings from Koha. | In this case the item barcode value for the AU field is: TEST7474747474 Sponsored-By: Brimbank Library, Australia -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21486 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21486 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED --- Comment #2 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Actually I want to make a few more changes to this solution for master. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21486 --- Comment #3 from Colin Campbell <colin.campbell@ptfs-europe.com> --- Surely you dont need to fetch the info from borrowers - its being called from the ILS::Patron object we should have that info already -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21486 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21486 --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 80522 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80522&action=edit Bug 21486: Fix 'AU' for SIP -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21486 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Jonathan Druart from comment #4)
Created attachment 80522 [details] [review] Bug 21486: Fix 'AU' for SIP
We should not re-add code we removed :) One possible fix would be to call unblessed_all_relateds, but we should be more specific. The problem here is that I have no idea which info is needed in $ilspatron{items}. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21486 Colin Campbell <colin.campbell@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #80522|0 |1 is obsolete| | --- Comment #6 from Colin Campbell <colin.campbell@ptfs-europe.com> --- Created attachment 80655 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80655&action=edit Signed off patch Signed off Jonathan's patch as it works for me in testing, Alex can you confirm? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21486 --- Comment #7 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Jonathan Druart from comment #5)
The problem here is that I have no idea which info is needed in $ilspatron{items}.
Colin, do you know the answer? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21486 --- Comment #8 from Colin Campbell <colin.campbell@ptfs-europe.com> --- (In reply to Jonathan Druart from comment #7)
(In reply to Jonathan Druart from comment #5)
The problem here is that I have no idea which info is needed in $ilspatron{items}.
Colin, do you know the answer?
Yes (infact we collided) items is an array of barcodes of items issued to this patron -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21486 --- Comment #9 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Colin Campbell from comment #8)
(In reply to Jonathan Druart from comment #7)
(In reply to Jonathan Druart from comment #5)
The problem here is that I have no idea which info is needed in $ilspatron{items}.
Colin, do you know the answer?
Yes (infact we collided) items is an array of barcodes of items issued to this patron
So we only need the barcodes, for other (if exist) calls as well? If so I can provide a better patch. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21486 --- Comment #10 from Colin Campbell <colin.campbell@ptfs-europe.com> --- (In reply to Jonathan Druart from comment #9)
(In reply to Colin Campbell from comment #8)
(In reply to Jonathan Druart from comment #7)
(In reply to Jonathan Druart from comment #5)
The problem here is that I have no idea which info is needed in $ilspatron{items}.
Colin, do you know the answer?
Yes (infact we collided) items is an array of barcodes of items issued to this patron
So we only need the barcodes, for other (if exist) calls as well? If so I can provide a better patch.
Yes the logic in the client machines is to get a list of relevant barcodes for the queries and it can then issue item information queries of those. The exception (theres always one) is fine items as item_id does not give you relevant info (thats not specific to Koha, it a fairly useless option in most LMSs) Koha has some specific code there -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21486 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #80655|0 |1 is obsolete| | --- Comment #11 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 80729 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80729&action=edit Bug 21486: Fix 'AU' for SIP Signed-off-by: Colin Campbell <colin.campbell@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21486 --- Comment #12 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 80730 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80730&action=edit Bug 21486: Only fetch the items' barcodes and avoid unecessary processing -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21486 Colin Campbell <colin.campbell@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #80730|0 |1 is obsolete| | --- Comment #13 from Colin Campbell <colin.campbell@ptfs-europe.com> --- Created attachment 80976 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80976&action=edit patch restricting to barcodes Tested patch and works as advertised - signed off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21486 --- Comment #14 from Colin Campbell <colin.campbell@ptfs-europe.com> --- I've signed off Jonathan's two patches they restore the previous behaviour. Alex can you confirm this does all you envisioned and can go with it in place of your original patch? We should endeavour to get this into 18.11 or their is potential for working setups to be broken -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21486 --- Comment #15 from Alex Buckley <alexbuckley@catalyst.net.nz> --- (In response to Colin Campbell in comment 14): Yes I can confirm Jonathan's patches do what I had envisaged and can replace my patch. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21486 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #80251|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21486 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #80729|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21486 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #80976|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21486 --- Comment #16 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 81001 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81001&action=edit Bug 21486: Fix 'AU' for SIP Signed-off-by: Colin Campbell <colin.campbell@ptfs-europe.com> Signed-off-by: Alex Buckley <alexbuckley@catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21486 --- Comment #17 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 81002 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81002&action=edit Bug 21486: Only fetch the items' barcodes and avoid unecessary processing Signed-off-by: Colin Campbell <colin.campbell@ptfs-europe.com> Tested and found correct AU data is returned, and passes QA test tool Signed-off-by: Alex Buckley <alexbuckley@catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21486 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21486 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21486 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|alexbuckley@catalyst.net.nz |jonathan.druart@bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21486 --- Comment #18 from Colin Campbell <colin.campbell@ptfs-europe.com> --- Bonus - fixes a failure to process renew requests I've just spotted -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21486 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|major |critical --- Comment #19 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Upgrading severity as it impacts the last stable version. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21486 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21486 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #81001|0 |1 is obsolete| | Attachment #81002|0 |1 is obsolete| | --- Comment #20 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 81050 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81050&action=edit Bug 21486: Fix 'AU' for SIP Signed-off-by: Colin Campbell <colin.campbell@ptfs-europe.com> Signed-off-by: Alex Buckley <alexbuckley@catalyst.net.nz> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21486 --- Comment #21 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 81051 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81051&action=edit Bug 21486: Only fetch the items' barcodes and avoid unecessary processing Signed-off-by: Colin Campbell <colin.campbell@ptfs-europe.com> Tested and found correct AU data is returned, and passes QA test tool Signed-off-by: Alex Buckley <alexbuckley@catalyst.net.nz> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21486 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |josef.moravec@gmail.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21486 Magnus Enger <magnus@libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |magnus@libriotech.no --- Comment #22 from Magnus Enger <magnus@libriotech.no> --- (In reply to Jonathan Druart from comment #19)
Upgrading severity as it impacts the last stable version.
Yes, this is definitely needed in 18.05.x. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21486 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #23 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21486 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |martin.renvoize@ptfs-europe | |.com --- Comment #24 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Pushed to 18.05.x for 18.05.06 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21486 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Status|Pushed to Stable |RESOLVED Resolution|--- |FIXED --- Comment #25 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Depends on Bug 19935 not in 17.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21486 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aniltiwari86@hotmail.com --- Comment #26 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- *** Bug 20493 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org