[Bug 16517] New: A server error is raised when creating a new list with an existing name
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16517 Bug ID: 16517 Summary: A server error is raised when creating a new list with an existing name Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: critical Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart@bugs.koha-community.org Reporter: jonathan.druart@bugs.koha-community.org QA Contact: testopia@bugs.koha-community.org Depends on: 14544 A very bad typo causes a server error when a librarian try to create a list with an existing list's name. This is caused by bug 14544 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544 [Bug 14544] Move the list related code to Koha::Virtualshelves -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16517 --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- For my defense it looks like a merge conflict error when rebasing bug 14544, but I plead guilty :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16517 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16517 --- Comment #2 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 51482 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51482&action=edit Bug 16517: Do not crash when creating a list with an existing name A typo has been made during a merge conflict when rebasing bug 16517. it should be eval { Koha::Object->new->store; }; instead of eval { Koha::Object->new; }->store; Test plan:
From the result list (intranet side), check some entries and add them to a new list Use an existing list's name => Without this patch you will get a server error (exception 'Duplicate shelf object' raised by Koha::Virtualshelf->new->store) => With this patch you must get a friendly error message
-- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16517 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Component|Architecture, internals, |Lists |and plumbing | CC| |m.de.rooy@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16517 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |16519 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16519 [Bug 16519] Do not use global variables in [opac-]addbybiblionumbers.pl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16517 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|critical |major -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16517 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16517 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51482|0 |1 is obsolete| | --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 51491 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51491&action=edit [SIGNED-OFF] Bug 16517: Do not crash when creating a list with an existing name A typo has been made during a merge conflict when rebasing bug 16517. it should be eval { Koha::Object->new->store; }; instead of eval { Koha::Object->new; }->store; Test plan:
From the result list (intranet side), check some entries and add them to a new list Use an existing list's name => Without this patch you will get a server error (exception 'Duplicate shelf object' raised by Koha::Virtualshelf->new->store) => With this patch you must get a friendly error message
Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16517 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16517 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51491|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 51604 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51604&action=edit [PASSED QA] Bug 16517: Do not crash when creating a list with an existing name A typo has been made during a merge conflict when rebasing bug 16517. it should be eval { Koha::Object->new->store; }; instead of eval { Koha::Object->new; }->store; Test plan:
From the result list (intranet side), check some entries and add them to a new list Use an existing list's name => Without this patch you will get a server error (exception 'Duplicate shelf object' raised by Koha::Virtualshelf->new->store) => With this patch you must get a friendly error message
Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16517 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |kyle@bywatersolutions.com --- Comment #5 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to master for Koha 16.05, thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16517 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |julian.maurice@biblibre.com --- Comment #6 from Julian Maurice <julian.maurice@biblibre.com> --- Patch pushed to 3.22.x, will be in 3.22.7 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org