[Bug 24484] New: Add explanatory text to batch patron deletion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24484 Bug ID: 24484 Summary: Add explanatory text to batch patron deletion Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Tools Assignee: koha-bugs@lists.koha-community.org Reporter: andrew@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org On the first page of the batch patron deletion tool, it'd be helpful to have text explaining which types of patrons will be skipped in the deletion. Right now, there is a brief bit of descriptive text that reads: "This tool allows you to delete patrons and anonymize checkout history. For deleting patrons, any combination of limits can be used." I'd like that amended to: "This tool allows you to delete patrons and anonymize checkout history. For deleting patrons, any combination of limits can be used. Patrons will not be deleted if they meet one of more of the following conditions: - They have items currently checked out. - They have a non-zero account balance. - They are the guarantor to another patron. - They in a patron category of type Staff." -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24484 --- Comment #1 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Missed a word in my last bullet: "They sre in a patron category of type Staff." -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24484 David Roberts <david.roberts@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |david.roberts@ptfs-europe.c |ity.org |om CC| |david.roberts@ptfs-europe.c | |om -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24484 --- Comment #2 from David Roberts <david.roberts@ptfs-europe.com> --- Created attachment 97795 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97795&action=edit Bug 24484 - Add explanatory text to batch patron deletion -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24484 David Roberts <david.roberts@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff --- Comment #3 from David Roberts <david.roberts@ptfs-europe.com> --- To test: 1) Open up the Batch patron deletion and anonymisation tool 2) Check the help text near the top of the screen 3) Install the patch and repeat steps 1 and 2 4) Check the help text has changed to the new version -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24484 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |katrin.fischer@bsz-bw.de --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi David, thx for the patch! Please include the test plan in your commit message and also a small sentence as to what is changed here (see Noticed something to fix too: +<p> - They are in a patron category of type Staff..</p> should be: staff. Instead of paragraphs a bullet list might work nicer here too semantically. Then you don't need to hardcode the "- " which might be missed in translation. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24484 --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Forgot the link: https://wiki.koha-community.org/wiki/Commit_messages -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24484 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com --- Comment #6 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- To explain that last bit... You have <p> - Stuff </p> <p> - Stuff </p> . . . <p> = Paragraph.. so it works mostly.. but semantically we're actually talking about a list so... So... <ul> <li> Stuff </li> <li> Stuff </li> </ul> This is cleaner as it's semantically describing the content more accurately.. <ul> = Unordered list, <li> = List item. :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24484 --- Comment #7 from David Roberts <david.roberts@ptfs-europe.com> --- I'm having problems adding patches with git bz attach -e - it only works without the -e at the moment, which means I can't put the test plan in the right place! Bear with me.... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24484 --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to David Roberts from comment #7)
I'm having problems adding patches with git bz attach -e - it only works without the -e at the moment, which means I can't put the test plan in the right place! Bear with me....
Hi David, you can do it like this (the -e won't help possibly): git commit --amend This will bring up the commit message of the last patch on your branch and you can edit/add to it. Then you can do a: git bz attach 24484 HEAD And then you can obsolete the old patch here using bugzilla: Klick on details > edit details > obsolete checkbox. The -e allows you to obsolete patches and change status but afaik it won't change the patch you upload. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24484 --- Comment #9 from David Roberts <david.roberts@ptfs-europe.com> --- Thank you - now I understand! :-) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24484 David Roberts <david.roberts@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #97795|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24484 --- Comment #10 from David Roberts <david.roberts@ptfs-europe.com> --- Created attachment 97812 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97812&action=edit Bug 24484 - Add explanatory text to batch patron deletion This patch adds a more detailed explanation about what the tool can do. To test: 1) Open up the Batch patron deletion and anonymisation tool 2) Check the help text near the top of the screen 3) Install the patch and repeat steps 1 and 2 4) Check the help text has changed to the new version -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24484 David Roberts <david.roberts@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #11 from David Roberts <david.roberts@ptfs-europe.com> --- Hopefully this is better now! :-) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24484 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #97812|0 |1 is obsolete| | --- Comment #12 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 97813 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97813&action=edit Bug 24484 - Add explanatory text to batch patron deletion This patch adds a more detailed explanation about what the tool can do. To test: 1) Open up the Batch patron deletion and anonymisation tool 2) Check the help text near the top of the screen 3) Install the patch and repeat steps 1 and 2 4) Check the help text has changed to the new version Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24484 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #13 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Thanks for jumping right on this, David! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24484 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |String patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24484 --- Comment #14 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 97943 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97943&action=edit Bug 24484: Add explanatory text to batch patron deletion This patch adds a more detailed explanation about what the tool can do. To test: 1) Open up the Batch patron deletion and anonymisation tool 2) Check the help text near the top of the screen 3) Install the patch and repeat steps 1 and 2 4) Check the help text has changed to the new version Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24484 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #97813|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24484 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24484 --- Comment #15 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24484 Joy Nelson <joy@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joy@bywatersolutions.com Version(s)|20.05.00 |20.05.00, 19.11.03 released in| | Status|Pushed to master |Pushed to stable --- Comment #16 from Joy Nelson <joy@bywatersolutions.com> --- Pushed to 19.11.x branch for 19.11.03 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24484 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Version(s)|20.05.00, 19.11.03 |20.05.00, 19.11.03, released in| |19.05.08 Status|Pushed to stable |Pushed to oldstable --- Comment #17 from Lucas Gass <lucas@bywatersolutions.com> --- backported to 19.05.x for 19.05.08 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24484 Hayley Mapley <hayleymapley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |Pushed to oldoldstable CC| |hayleymapley@catalyst.net.n | |z Version(s)|20.05.00, 19.11.03, |20.05.00, 19.11.03, released in|19.05.08 |19.05.08, 18.11.14 --- Comment #18 from Hayley Mapley <hayleymapley@catalyst.net.nz> --- Backported to 18.11.x for 18.11.14. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org