[Bug 13161] New: Report name should be mandatory when editing saved reports
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13161 Bug ID: 13161 Summary: Report name should be mandatory when editing saved reports Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Reports Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org Bug 2969 made report name mandatory for new reports but failed to do the same when editing existing reports. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13161 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=2969 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13161 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13161 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 32932 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32932&action=edit Bug 13161 - Report name should be mandatory when editing saved reports When Bug 2969 made report name required for SQL reports, it did so only for new reports. This patch makes the same requirement true when editing existing reports. Other changes: - Removed unused "type" setting from edit screen (already removed from creation form). - Added form field size attribute to report name field to match creation form. - Moved SQL textarea into its own fieldset and marked it as required, matching the report creation form. To test, apply the patch and edit an existing saved SQL report. You should be prevented from saving your report with either the report name or SQL field blank. Test with JavaScript enable and disabled. Confirm that after entering valid data your report runs correctly. Compare the new SQL report form with the update SQL report form. They should be structured the same. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13161 Nick Clemens <nick@quecheelibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13161 Nick Clemens <nick@quecheelibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #32932|0 |1 is obsolete| | --- Comment #2 from Nick Clemens <nick@quecheelibrary.org> --- Created attachment 32934 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32934&action=edit [SIGNED OFF] Bug 13161 - Report name should be mandatory when editing saved reports When Bug 2969 made report name required for SQL reports, it did so only for new reports. This patch makes the same requirement true when editing existing reports. Other changes: - Removed unused "type" setting from edit screen (already removed from creation form). - Added form field size attribute to report name field to match creation form. - Moved SQL textarea into its own fieldset and marked it as required, matching the report creation form. To test, apply the patch and edit an existing saved SQL report. You should be prevented from saving your report with either the report name or SQL field blank. Test with JavaScript enable and disabled. Confirm that after entering valid data your report runs correctly. Compare the new SQL report form with the update SQL report form. They should be structured the same. Signed-off-by: Nick Clemens <nick@quecheelibrary.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13161 --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 32956 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32956&action=edit [PASSED QA] Bug 13161 - Report name should be mandatory when editing saved reports When Bug 2969 made report name required for SQL reports, it did so only for new reports. This patch makes the same requirement true when editing existing reports. Other changes: - Removed unused "type" setting from edit screen (already removed from creation form). - Added form field size attribute to report name field to match creation form. - Moved SQL textarea into its own fieldset and marked it as required, matching the report creation form. To test, apply the patch and edit an existing saved SQL report. You should be prevented from saving your report with either the report name or SQL field blank. Test with JavaScript enable and disabled. Confirm that after entering valid data your report runs correctly. Compare the new SQL report form with the update SQL report form. They should be structured the same. Signed-off-by: Nick Clemens <nick@quecheelibrary.org> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Passes tests and QA script. Works as described. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13161 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13161 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #32934|0 |1 is obsolete| | Attachment #32956|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 32957 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32957&action=edit [PASSED QA] Bug 13161 - Report name should be mandatory when editing saved reports When Bug 2969 made report name required for SQL reports, it did so only for new reports. This patch makes the same requirement true when editing existing reports. Other changes: - Removed unused "type" setting from edit screen (already removed from creation form). - Added form field size attribute to report name field to match creation form. - Moved SQL textarea into its own fieldset and marked it as required, matching the report creation form. To test, apply the patch and edit an existing saved SQL report. You should be prevented from saving your report with either the report name or SQL field blank. Test with JavaScript enable and disabled. Confirm that after entering valid data your report runs correctly. Compare the new SQL report form with the update SQL report form. They should be structured the same. Signed-off-by: Nick Clemens <nick@quecheelibrary.org> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Passes tests and QA script. Works as described. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13161 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen@gmail.com --- Comment #5 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patch pushed to master. Thanks Owen! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org