[Bug 19262] New: pod_spell.t does not work
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19262 Bug ID: 19262 Summary: pod_spell.t does not work Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Test Suite Assignee: jonathan.druart@bugs.koha-community.org Reporter: jonathan.druart@bugs.koha-community.org QA Contact: testopia@bugs.koha-community.org If you run `prove xt/author/pod_spell.t` without having Test::Spelling installed, it will skip the tests. If you install the lib-test-spelling-perl, the test will fail: xt/author/pod_spell.t .. You said to run 0 tests at xt/author/pod_spell.t line 21. xt/author/pod_spell.t .. Dubious, test returned 25 (wstat 6400, 0x1900) No subtests run This is because the call to all_pod_files_spelling_ok is expecting a path If we try to fix it with adding "." as parameter, the tests will raise tone of errors: # Failed test 'POD spelling for ./acqui/invoice.pl' # at xt/author/pod_spell.t line 21. # Errors: # pl # Failed test 'POD spelling for ./acqui/neworderempty.pl' # at xt/author/pod_spell.t line 21. # Errors: # CGI # MARCfindbreeding # basketno # biblio # booksellerid # breedingid # neworderempty # ordernumber # pl # suggestionid # Failed test 'POD spelling for ./acqui/addorder.pl' # at xt/author/pod_spell.t line 21. # Errors: # CGI # ISBN # addorder # biblio # cgi # copyrightdate # neworderbiblio # neworderempty # newordersuggestion # pl And much more... Let's remove this file -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19262 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19262 --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 66871 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66871&action=edit Bug 19262: Remove xt/author/pod_spell.t If you run `prove xt/author/pod_spell.t` without having Test::Spelling installed, it will skip the tests. If you install the lib-test-spelling-perl, the test will fail: xt/author/pod_spell.t .. You said to run 0 tests at xt/author/pod_spell.t line 21. xt/author/pod_spell.t .. Dubious, test returned 25 (wstat 6400, 0x1900) No subtests run This is because the call to all_pod_files_spelling_ok is expecting a path If we try to fix it with adding "." as parameter, the tests will raise tone of errors. Let's remove this file -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19262 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19262 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #66871|0 |1 is obsolete| | --- Comment #2 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 66896 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66896&action=edit Bug 19262: Remove xt/author/pod_spell.t If you run `prove xt/author/pod_spell.t` without having Test::Spelling installed, it will skip the tests. If you install the lib-test-spelling-perl, the test will fail: xt/author/pod_spell.t .. You said to run 0 tests at xt/author/pod_spell.t line 21. xt/author/pod_spell.t .. Dubious, test returned 25 (wstat 6400, 0x1900) No subtests run This is because the call to all_pod_files_spelling_ok is expecting a path If we try to fix it with adding "." as parameter, the tests will raise tone of errors. Let's remove this file Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19262 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19262 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 17.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19262 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Status|Pushed to Master |Pushed to Stable --- Comment #4 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Pushed to 17.05.x, will be in 17.05.06. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19262 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- This patch has been pushed to 16.11.x and will be in 16.11.14. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19262 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj@kohaaloha.com --- Comment #6 from Mason James <mtj@kohaaloha.com> --- Pushed to 16.05.x, for 16.05.19 release -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org