http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8700 --- Comment #1 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 11877 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11877&action=edit Bug 8700 - RESERVESLIP fields not being replaced correctly The slip RESERVESLIP is not replacing fields correctly. C4::Reserves::ReserveSlip calls C4::Letters::GetPreparedLetter, and passes the $reserve hashref to it for each table except branches ( which is passed the branchcode ). The problem is, if you pass a hashref for a table, it uses that hashref for the replacing, rather than looking up the data from the database. Fixed by passing the correct keys for each of the tables requested. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8700 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |kyle@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8700 --- Comment #3 from Kyle M Hall <kyle@bywatersolutions.com> --- Test plan: 1) Edit the slip RESERVESLIP, set it to the following: borrowers.title: <<borrowers.title>> <br/> biblio.copyrightdate: <<biblio.copyrightdate>> <br/> items.replacementprice: <<items.replacementprice>> 2) Place a reserve for a borrower. Make sure that borrower has a borrowers.title value in the database ( I prefer "King of the World" ), as well as biblio.copyrightdate, and items.replacementprice 3) Return the item, confirm hold and print slip. The slip will probably show the *item's* title in borrowers.title. It did for me. The other two will probably by blank. 4) Apply the patch, repeat step 2 and 3, the values should now be correct and accurate. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8700 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |veron@veron.ch -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8700 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |paul.poulain@biblibre.com --- Comment #6 from Paul Poulain <paul.poulain@biblibre.com> --- QA comment * tiny & trivial (from a QA POV) patch passed QA -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8700 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris@bigballofwax.co.nz --- Comment #8 from Chris Cormack <chris@bigballofwax.co.nz> --- Pushed to 3.8.x, will be in 3.8.6 -- You are receiving this mail because: You are watching all bug changes.