https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38233 --- Comment #1 from David Cook <dcook@prosentient.com.au> --- Fortunately, this is a super easy fix! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38233 --- Comment #2 from David Cook <dcook@prosentient.com.au> --- Created attachment 173187 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173187&action=edit Bug 38233: respect OPAC visibility for ILS-DI GetRecords This change makes the ILS-DI GetRecords service use the OPAC version of the MARCXML and filters items based on their OPAC visibility Test plan: 1. Apply the patch 2. koha-plack --restart kohadev 3. Go to http://localhost:8081/cgi-bin/koha/admin/preferences.pl?op=search&searchfield=ILS-DI and enable syspref 4. Go to http://localhost:8081/cgi-bin/koha/admin/preferences.pl?op=search&searchfield=OpacHiddenItems and add the following: withdrawn: [1] 5. Go to http://localhost:8081/cgi-bin/koha/admin/preferences.pl?op=search&searchfield=hidelostitems Change syspref to "Don't show" 6. Go to http://localhost:8081/cgi-bin/koha/catalogue/detail.pl?biblionumber=29 7. Add a withdrawn item and a lost item with barcodes of "test1" and "test2" respectively 8. Go to http://localhost:8080/cgi-bin/koha/ilsdi.pl?service=GetRecords&id=29 9. Note the items with barcodes test1 and test2 do not appear in the "items" tree and they don't appear in the "marcxml" tree. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38233 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38233 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com Text to go in the| |This updates the ILS-DI release notes| |GetRecords service to use | |the OPAC version of the | |MARCXML and filter items | |based on their OPAC | |visibility. For example, if | |OpacHiddenItems includes | |"withdrawn: [1]" (hide | |items with a withdrawn | |status of 1) and | |hidelostitems is set to | |"Don't show", then an | |ILS_DI request for a record | |will not show items with a | |withdrawn status = 1 | |(Withdrawn). Previously, | |there was no way to hide | |hidden items from the | |ILS-DI request. --- Comment #4 from David Nind <david@davidnind.com> --- Not related to this bug, but just noting. If I set an item with for a record with a lost status = 1 (Lost), then when viewing the record in the staff interface, it sits on "Processing". To replicate: 1. Find any record in the staff interface with an existing item and add a new item. 2. Note that when you select the "Normal" view, the holdings section lists the existing item and the new one that you created. 3. Edit the item you created and change "1 - Lost status" to "Lost". 4. Select the "Normal" view for the record again and note that a dialog box appears saying "Processing" and the holdings table does not list any items. I've created bug 38248 for this. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38233 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |pedro.amorim@ptfs-europe.co |y.org |m CC| |pedro.amorim@ptfs-europe.co | |m --- Comment #6 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Looking here -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38233 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #173236|0 |1 is obsolete| | --- Comment #7 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 173609 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173609&action=edit Bug 38233: respect OPAC visibility for ILS-DI GetRecords This change makes the ILS-DI GetRecords service use the OPAC version of the MARCXML and filters items based on their OPAC visibility Test plan: 1. Apply the patch 2. koha-plack --restart kohadev 3. Go to http://localhost:8081/cgi-bin/koha/admin/preferences.pl?op=search&searchfield=ILS-DI and enable syspref 4. Go to http://localhost:8081/cgi-bin/koha/admin/preferences.pl?op=search&searchfield=OpacHiddenItems and add the following: withdrawn: [1] 5. Go to http://localhost:8081/cgi-bin/koha/admin/preferences.pl?op=search&searchfield=hidelostitems Change syspref to "Don't show" 6. Go to http://localhost:8081/cgi-bin/koha/catalogue/detail.pl?biblionumber=29 7. Add a withdrawn item and a lost item with barcodes of "test1" and "test2" respectively 8. Go to http://localhost:8080/cgi-bin/koha/ilsdi.pl?service=GetRecords&id=29 9. Note the items with barcodes test1 and test2 do not appear in the "items" tree and they don't appear in the "marcxml" tree. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38233 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|ILS-DI GetRecords should |ILS-DI GetRecords should |filter_by_visible_in_opac |filter out items hidden in |and use OPAC MARCXML |OPAC and use OPAC MARCXML -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38233 --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.11! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38233 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38233 --- Comment #12 from David Cook <dcook@prosentient.com.au> --- It looks like this patch wasn't properly applied to main for 24.11.00. The following line change exists in 24.05.06 but not 24.11.xx or main: my $record = $biblio->metadata->record({ embed_items => 1, opac => 1, }); -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38233 --- Comment #13 from David Cook <dcook@prosentient.com.au> --- (In reply to David Cook from comment #12)

It looks like this patch wasn't properly applied to main for 24.11.00. The following line change exists in 24.05.06 but not 24.11.xx or main:

my $record = $biblio->metadata->record({ embed_items => 1, opac => 1, });

Actually, it looks like it probably was applied correctly, but then bug 31224 undid it by accident a few days later. -- You are receiving this mail because: You are watching all bug changes.