[Bug 8766] New: OPACBaseURL still called as OPACBaseurl in many files
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8766 Priority: P5 - low Change sponsored?: --- Bug ID: 8766 Assignee: oleonard@myacpl.org Summary: OPACBaseURL still called as OPACBaseurl in many files Severity: minor Classification: Unclassified OS: All Reporter: dcook@prosentient.com.au Hardware: All Status: NEW Version: master Component: Templates Product: Koha OPACBaseurl is still being used in opac-results.tt and opac-opensearch.tt It also shows up in many Poodle files. Note: opac-results.tt doesn't currently get passed OPACBaseURL anyway, but it's still probably a good idea to have it spelled correctly. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8766 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=6975 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8766 --- Comment #1 from David Cook <dcook@prosentient.com.au> --- (In reply to comment #0)
OPACBaseurl is still being used in opac-results.tt and opac-opensearch.tt
It also shows up in many Poodle files.
Note: opac-results.tt doesn't currently get passed OPACBaseURL anyway, but it's still probably a good idea to have it spelled correctly.
Pootle :P -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8766 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8766 --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 12486 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12486&action=edit Bug 8766 - OPACBaseURL still called as OPACBaseurl in many files This patch fixes incorrect capitalization of the OPACBaseURL variable in three templates. The fix can be confirmed in opac-results.tt by inspecting the link attached to the RSS icon on the OPAC's search results screen. The same fix is included in opac-opensearch.tt and search/results.tt but I'm not sure how you confirm that this change fixes anything, if it does. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8766 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12486|0 |1 is obsolete| | --- Comment #3 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 12579 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12579&action=edit [SIGNED-OFF] Bug 8766 - OPACBaseURL still called as OPACBaseurl in many files This patch fixes incorrect capitalization of the OPACBaseURL variable in three templates. The fix can be confirmed in opac-results.tt by inspecting the link attached to the RSS icon on the OPAC's search results screen. The same fix is included in opac-opensearch.tt and search/results.tt but I'm not sure how you confirm that this change fixes anything, if it does. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8766 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |kyle@bywatersolutions.com --- Comment #4 from Kyle M Hall <kyle@bywatersolutions.com> --- OPACBaseURL is set by get_template_and_user so having a script in the opac directory set it as well is superfluous, but not harmful. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8766 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |paul.poulain@biblibre.com --- Comment #5 from Paul Poulain <paul.poulain@biblibre.com> --- QA comment: tiny patch, just change capitalization -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8766 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master Version|master |rel_3_8 --- Comment #6 from Paul Poulain <paul.poulain@biblibre.com> --- Patch pushed to master -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8766 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz --- Comment #7 from Chris Cormack <chris@bigballofwax.co.nz> --- Patch doesn't apply on 3.8.x, please rebase and submit if it is needed. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8766 --- Comment #8 from David Cook <dcook@prosentient.com.au> --- (In reply to comment #7)
Patch doesn't apply on 3.8.x, please rebase and submit if it is needed.
It seems to me that the patch is getting hung up on opac-tmpl\prog\en\modules\search\results.tt, which doesn't exist in 3.8.x as it is a file specific to BibLibre's work with Solr in master. Wouldn't this be a case where the commit needs to be cherrypicked to 3.8.x from master and the bit about search\results.tt removed while the rest of the patch remains relevant? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8766 --- Comment #9 from Chris Cormack <chris@bigballofwax.co.nz> --- (In reply to comment #8)
(In reply to comment #7)
Patch doesn't apply on 3.8.x, please rebase and submit if it is needed.
It seems to me that the patch is getting hung up on opac-tmpl\prog\en\modules\search\results.tt, which doesn't exist in 3.8.x as it is a file specific to BibLibre's work with Solr in master.
Wouldn't this be a case where the commit needs to be cherrypicked to 3.8.x from master and the bit about search\results.tt removed while the rest of the patch remains relevant?
Exactly, but what I want is the patch author to do that, so and attach a 3.8.x patch, so I don't muck it up :) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8766 --- Comment #10 from Chris Cormack <chris@bigballofwax.co.nz> --- Still waiting on a 3.8.x patch for this -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8766 --- Comment #11 from David Cook <dcook@prosentient.com.au> --- (In reply to Kyle M Hall from comment #4)
OPACBaseURL is set by get_template_and_user so having a script in the opac directory set it as well is superfluous, but not harmful.
At the time, I don't think I 100% understood what you meant by this, but I do now. I suppose it's not harmful so long as it doesn't tamper with the https detection happening in Auth.pm. That said, at the moment, I think the OPACBaseURL set by get_template_and_user is using an environmental "SERVER_NAME" variable (which appears to be the domain name that a user puts into their browser, rather than the ServerName in the Apache conf), rather than the OPACBaseURL system preference. While this might not be an issue in many cases, it appears to cause issues for Koha instances sitting behind proxy servers... I'm opening bug 11575 to deal with that... -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8766 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=11575 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org