http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9211 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|--- |Sponsored Assignee|koha-bugs@lists.koha-commun |tomascohen@gmail.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9211 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9211 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |kyle@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9211 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |9209 -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9211 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |paul.poulain@biblibre.com --- Comment #5 from Paul Poulain <paul.poulain@biblibre.com> --- QA Comment: * checking usage of days_between = - in C4/Circulation, it's used in _debar_user_on_return. The relevant lines are: my $deltadays = $calendar->days_between( $dt_due, $dt_today ); if ( $deltadays->subtract($grace)->is_positive() ) { => seems logical that $deltadays is positive - in C4/Overdues.pm, it's used in _get_chargeable_units $charge_duration = $calendar->days_between( $dt1, $dt2 ); => seems OK as well * patch passes koha-qa.pl * prove t/Calendar.t is working well after a tiny followup i'll attach TO RM = I don't see anything wrong with this patch, but it's a sensible one, so it's worth looking deeply !!! -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9211 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #13946|0 |1 is obsolete| | Attachment #14400|0 |1 is obsolete| | --- Comment #7 from Paul Poulain <paul.poulain@biblibre.com> --- Created attachment 14401 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14401&action=edit Bug 9211 follow-up fixing 2 tiny mistakes in unit test * the new test was not announced (26 announced, 27 run) * $daycount already declared, resulting in "my" variable $daycount masks earlier declaration in same scope at t/Calendar.t line 93. with this patch prove t/Calendar.t is green ;-) -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9211 --- Comment #9 from Paul Poulain <paul.poulain@biblibre.com> --- Created attachment 14403 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14403&action=edit Bug 9211 follow-up fixing 2 tiny mistakes in unit test * the new test was not announced (26 announced, 27 run) * $daycount already declared, resulting in "my" variable $daycount masks earlier declaration in same scope at t/Calendar.t line 93. with this patch prove t/Calendar.t is green ;-) -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9211 --- Comment #11 from Tomás Cohen Arazi <tomascohen@gmail.com> --- (In reply to comment #10)

(sorry for multiple attachment, made a mistake...)

I recall there were tests for this in 9109 already (pushed). I added 3, on a per syspref setup basis, To capture the syspref independent nature. I might be erong too, on my phone right now -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9211 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #14402|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9211 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #14402|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9211 --- Comment #13 from Tomás Cohen Arazi <tomascohen@gmail.com> --- (In reply to comment #12)

Could we get a test plan so I can test this in the interface and not just in the unit test?

I haven't found through the code an usage example that leaded to having the dates swapped. I assume the days_between method is intended to work whether the dates are ordered or not just in case it is needed. In that case, this bug just makes the implementation match the documented API. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9211 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris@bigballofwax.co.nz --- Comment #15 from Chris Cormack <chris@bigballofwax.co.nz> --- Pushed to 3.10.x and 3.8.x will be in 3.10.3 and 3.8.10 -- You are receiving this mail because: You are watching all bug changes.